Commit 27be3f4c authored by Ximin Luo's avatar Ximin Luo
Browse files

comparators: add a test for fallback_recognizes and improve the behaviour

parent 7b8b9ae7

diffoscope/comparators/cbfs.py

+2 −2
Original line number Diff line number Diff line
@@ -101,8 +101,8 @@ def is_header_valid(buf, size, offset=0): 
class CbfsFile(File):

    CONTAINER_CLASS = CbfsContainer



    @staticmethod

    def recognizes(file):

    @classmethod

    def recognizes(cls, file):

        size = os.stat(file.path).st_size

        if size < CBFS_HEADER_SIZE or size > CBFS_MAXIMUM_FILE_SIZE:

            return False

diffoscope/comparators/deb.py

+4 −4
Original line number Diff line number Diff line
@@ -125,8 +125,8 @@ class DebFile(File): 




class Md5sumsFile(File):

    @staticmethod

    def recognizes(file):

    @classmethod

    def recognizes(cls, file):

        return isinstance(file, ArchiveMember) and \

               file.name == './md5sums' and \

               isinstance(file.container.source, ArchiveMember) and \
@@ -179,8 +179,8 @@ class DebTarContainer(TarContainer): 
class DebDataTarFile(File):

    CONTAINER_CLASS = DebTarContainer



    @staticmethod

    def recognizes(file):

    @classmethod

    def recognizes(cls, file):

        return isinstance(file, ArchiveMember) and \

               isinstance(file.container.source, ArchiveMember) and \

               DebContainer.RE_DATA_TAR.match(file.container.source.name) and \

diffoscope/comparators/device.py

+2 −2
Original line number Diff line number Diff line
@@ -31,8 +31,8 @@ logger = logging.getLogger(__name__) 




class Device(File):

    @staticmethod

    def recognizes(file):

    @classmethod

    def recognizes(cls, file):

        return file.is_device()



    def get_device(self):

diffoscope/comparators/directory.py

+2 −2
Original line number Diff line number Diff line
@@ -146,8 +146,8 @@ def compare_directories(path1, path2, source=None): 




class Directory(object):

    @staticmethod

    def recognizes(file):

    @classmethod

    def recognizes(cls, file):

        return file.is_directory()



    @classmethod

diffoscope/comparators/elf.py

+2 −2
Original line number Diff line number Diff line
@@ -312,8 +312,8 @@ class ElfSection(File): 
    def fuzzy_hash(self):

        return None



    @staticmethod

    def recognizes(file):

    @classmethod

    def recognizes(cls, file):

        # No file should be recognized as an elf section

        return False