Commit 465176e0 authored by Vibhu Agrawal's avatar Vibhu Agrawal

Modified zip.py to handle ENOSPC

Added a try except block to handle OSError 28 and make the diffoscope
fail more gracefully.
parent d4a77886
Pipeline #41921 failed with stage
in 15 minutes and 8 seconds
......@@ -156,7 +156,6 @@ class ZipContainer(Archive):
if (ose.errno == 28):
sys.tracebacklimit = 0
raise ose
else:
raise
......
  • I think here you pushed to the wrong branch or remote. Not to mention that this fails the tests.

    Looking at that other commit you did, d4a77886, I think you are following a not perfect git workflow. In particular, there you should have probably used git pull --rebase, and avoided merge commits in master. Not to mention, it feels like you are doing your tests and development effort in the "master" branch, which I generally discourage unless you know you are going to push to master without going through external review, as you should.

    I'm going to revert these commits.

  • mentioned in commit 0761d330

    Toggle commit list
  • I will try to correct these issues before creating the next MR.

Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment