external_tools: list `lipo` and `otool`, and a test to make sure they are all listed

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

diffoscope/external_tools.py

@@ -103,6 +103,7 @@ EXTERNAL_TOOLS = {
         "guix": "python-jsbeautifier",
     },
     "kbxutil": {"debian": "gnupg-utils", "guix": "gnupg"},
+    "lipo": {},
     "llvm-bcanalyzer": {"debian": "llvm", "arch": "llvm", "guix": "llvm"},
     "llvm-config": {"debian": "llvm", "arch": "llvm"},
     "llvm-dis": {"debian": "llvm", "arch": "llvm", "guix": "llvm"},
@@ -144,6 +145,7 @@ EXTERNAL_TOOLS = {
     "odt2txt": {"debian": "odt2txt", "arch": "odt2txt", "guix": "odt2txt"},
     "oggDump": {"debian": "oggvideotools"},
     "openssl": {"debian": "openssl", "guix": "openssl"},
+    "otool": {},
     "pgpdump": {"debian": "pgpdump", "arch": "pgpdump", "guix": "pgpdump"},
     "pdftotext": {
         "debian": "poppler-utils",

tests/test_tools.py

@@ -42,3 +42,17 @@ def test_required_tool_not_found():
 
     with pytest.raises(RequiredToolNotFound):
         fn()
+
+
+def test_all_tools_are_listed():
+    from diffoscope.comparators import ComparatorManager
+    from diffoscope.external_tools import EXTERNAL_TOOLS
+    from diffoscope.tools import tool_required
+
+    ComparatorManager().reload()
+
+    tools = set(tool_required.all)
+
+    for x in tools:
+        if x not in EXTERNAL_TOOLS:
+            pytest.fail(f"{x} is not present in EXTERNAL_TOOLS")