Commit 8eb852ac authored by Chris Lamb's avatar Chris Lamb 👀
Browse files

Factor out the set of the Config() global out of the run_diffoscope method. 

(diff is kinda misleading; nothing is actually changed.)
parent 21cb69c2

diffoscope/main.py

+20 −15
Original line number Diff line number Diff line
@@ -603,21 +603,7 @@ def maybe_set_limit(config, parsed_args, key): 
        setattr(config, key, float("inf"))





def run_diffoscope(parsed_args):

    """

    (This should not be considered a stable API suitable for external

    consumption, and the lack of configuration of globals may result in

    unpredictable behaviour.)

    """



    logger.debug("Starting diffoscope %s", VERSION)



    ProfileManager().setup(parsed_args)

    PresenterManager().configure(parsed_args)

    if not tlsh:

        logger.warning(

            'Fuzzy-matching is currently disabled as the "tlsh" module is unavailable.'

        )

def configure(parsed_args):

    maybe_set_limit(Config(), parsed_args, "max_report_size")

    maybe_set_limit(Config(), parsed_args, "max_text_report_size")

    maybe_set_limit(Config(), parsed_args, "max_diff_block_lines")
@@ -660,6 +646,25 @@ def run_diffoscope(parsed_args): 
        parsed_args.tool_prefix_binutils,

        *"ar as ld ld.bfd nm objcopy objdump ranlib readelf strip".split(),

    )





def run_diffoscope(parsed_args):

    """

    (This should not be considered a stable API suitable for external

    consumption, and the lack of configuration of globals may result in

    unpredictable behaviour.)

    """



    logger.debug("Starting diffoscope %s", VERSION)



    ProfileManager().setup(parsed_args)

    PresenterManager().configure(parsed_args)

    if not tlsh:

        logger.warning(

            'Fuzzy-matching is currently disabled as the "tlsh" module is unavailable.'

        )



    configure(parsed_args)

    set_path()

    normalize_environment()

    path1, path2 = parsed_args.path1, parsed_args.path2