Commit fee25e59 authored by Chris Lamb's avatar Chris Lamb 👀
Browse files

Drop --max-report-size-child and --max-diff-block-lines-parent; scheduled for...

Drop --max-report-size-child and --max-diff-block-lines-parent; scheduled for removal in January 2018.
parent d377d3b7
Loading
Loading
Loading
Loading
+0 −35
Original line number Diff line number Diff line
@@ -257,14 +257,6 @@ def create_parser():
        'effect even with --no-default-limits)',
        default=str(Config().max_page_size_child),
    ).completer = RangeCompleter(Config().max_page_size_child)
    # TODO: old flag kept for backwards-compat, drop 6 months after v84
    group2.add_argument(
        '--max-report-size-child',
        metavar='BYTES',
        type=int,
        help=argparse.SUPPRESS,
        default=None,
    )
    group2.add_argument(
        '--max-page-diff-block-lines',
        metavar='LINES',
@@ -277,14 +269,6 @@ def create_parser():
        'effect even with --no-default-limits)',
        default=Config().max_page_diff_block_lines,
    ).completer = RangeCompleter(Config().max_page_diff_block_lines)
    # TODO: old flag kept for backwards-compat, drop 6 months after v84
    group2.add_argument(
        "--max-diff-block-lines-parent",
        metavar='LINES',
        type=int,
        help=argparse.SUPPRESS,
        default=None,
    )

    group3 = parser.add_argument_group('diff calculation')
    group3.add_argument(
@@ -611,26 +595,7 @@ def configure(parsed_args):
            setattr(Config(), x, float("inf"))

    Config().max_page_size = parsed_args.max_page_size
    # TODO: old flag kept for backwards-compat, drop 6 months after v84
    if parsed_args.max_report_size_child is not None:
        logger.warning(
            "Detected deprecated flag --max-report-size-child; use --max-page-size-child instead."
        )
        Config().max_page_size_child = parsed_args.max_report_size_child

    Config().max_page_size_child = parsed_args.max_page_size_child
    # TODO: old flag kept for backwards-compat, drop 6 months after v84
    if parsed_args.max_diff_block_lines_parent is not None:
        logger.warning(
            "Detected deprecated flag --max-diff-block-lines-parent; use --max-page-diff-block-lines instead."
        )
        logger.warning(
            "Note that the new flag --max-page-diff-block-lines also applies to --html output."
        )
        Config().max_page_diff_block_lines = (
            parsed_args.max_diff_block_lines_parent
        )

    Config().max_page_diff_block_lines = parsed_args.max_page_diff_block_lines

    Config().new_file = parsed_args.new_file