Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Gbp-Dch: Ignore
Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Gbp-Dch: Ignore
Signed-off-by: Mattia Rizzolo <mattia@debian.org>

A change was made to ImageMagick in April which caused "File size"
from identify -verbose to display base 2 numbers, instead of the
previous base 10. This caused test_diff_meta to fail on newer
versions of ImageMagick.

ImageMagick commits #b6b00dad #ed597120: "SI units for filesize"

Signed-off-by: Juliana Oliveira Rodrigues <juliana.orod@gmail.com>

Gbp-Dch: Ignore
Signed-off-by: Mattia Rizzolo <mattia@debian.org>

d/rules: recommends the defusedxml python package, to avoid using the python3's standard xml library and its security holes

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Removes duplicated code from XMLFile comparator by using File.recognizes.

Signed-off-by: Juliana Oliveira Rodrigues <juliana.orod@gmail.com>

Rolls back imports to previous format

Signed-off-by: Juliana Oliveira Rodrigues <juliana.orod@gmail.com>

The enconding update was made on a previous patch and reflects
the result in this updated diff.

Signed-off-by: Juliana Oliveira Rodrigues <juliana.orod@gmail.com>

This patch handles UnicodeDecodeError exception, which is caused
by decoding an invalid XML File. When this error is raised, XMLFile
returns False for recognizes() method, indicating for other object
calls that the given file is not a XMLFile.

Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com>

This patch fixes test_android_manifest to use new XMLFile
structure.

Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com>

Guangyuan Yang authored Jul 20, 2017 and Mattia Rizzolo committed Jul 21, 2017

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Gbp-Dch: ignore

Gbp-Dch: Ignore

Gbp-Dch: Ignore

Juliana Rodrigues authored Jul 20, 2017 and Chris Lamb committed Jul 21, 2017

Signed-off-by: Juliana Rodrigues <juliana.orod@gmail.com>
Signed-off-by: Chris Lamb <lamby@debian.org>

comparators.apk: APK files can also be identified as "DOS/MBR boot sector". This is reasonably safe unless you have a real boot sector with an .apk extension. Thanks to Hans-Christoph Steiner <hans@eds.org> for the report and testcases. (Closes: #868486)

Signed-off-by: Chris Lamb <lamby@debian.org>

comparators.sqlite: Simplify file detection by rewriting manual `recognizes` call with a `Sqlite3Database.RE_FILE_TYPE` definition.

- make stat(1) warning textually like the other warnings
- bump stat(1) warning into an error
- use getfacl(1) before lsattr(1) as it's more general

The try clause really does nothing (and leaks logic from another part of the
program into this one), remove it.

Gbp-Dch: ignore

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

tools: add a get_package_provider() function, returning the package name that best matches the system

This function uses distro.like() to obtain a list of distributions
similar to the one we are running on.
It means that we will, for example, be able to suggest Debian packages
when running under Ubuntu.

Gbp-Dch: Short
Signed-off-by: Mattia Rizzolo <mattia@debian.org>

platform.linux_distribution() has been deprecated some time ago, and the
only viable alternative seems to be this external package.
Add it as an optioanl dependency, as without it distribution detection
(i.e. `diffoscope --list-tools`) won't work.

Also add it as a Debian dependency, as it's a very lightway package, and
the usefulness it brings are great.

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Signed-off-by: Mattia Rizzolo <mattia@debian.org>