Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Gbp-Dch: Ignore
Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Juliana Oliveira authored Jan 25, 2018 and Mattia Rizzolo committed Feb 28, 2018

There is no need for two stderr properties.

Signed-off-by: Juliana Oliveira <juliana.orod@gmail.com>

Juliana Oliveira authored Feb 10, 2018 and Mattia Rizzolo committed Feb 28, 2018

Since wait() now only returns its process returncode, there is no need
to keep it. This patch adds a returncode property to Command and
replaces .wait when catching exit codes.

Juliana Oliveira authored Feb 10, 2018 and Mattia Rizzolo committed Feb 28, 2018

Popen requires thread/IO micromanaging, and locks some interactions
with multiprocess lib due to its combined behavior with subprocess.PIPE, being
unusable with .map function. Subprocess.run simplifies command execution
by managing threads/IO and is also recommended over Popen since Python
3.5.

As a result, stderr and stdout were also simplified.

Signed-off-by: Juliana Oliveira <juliana.orod@gmail.com>
Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Add support for comparing Berkeley DB files. This is currently incomplete because the Berkeley DB libraries do not return the same uid/hash reliably (it returns "random" memory contents) so we must strip those from the human-readable output. (Closes: #890528)

Gbp-Dch: Ignore
Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Juliana Oliveira authored Jan 31, 2018 and Mattia Rizzolo committed Feb 05, 2018

Uses procyon-decompiler as main option for ClassFiles and javap
as a fallback. (Closes: #849386)

Signed-off-by: Juliana Oliveira <juliana.orod@gmail.com>
Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Signed-off-by: Mattia Rizzolo <mattia@debian.org>

FileNotFoundError is randomly found when spawning async processes

Signed-off-by: Juliana Oliveira <juliana.orod@gmail.com>

Actually this reveals that the Config() singleton pattern does not play nicely
with our tests, eventually this should be cleaned up.

i.e. exclude metadata by default, when not comparing two directories.

The reasoning is explained in the additional help text, and is implicitly why
"compare_meta" was always defined in directory.py and why originally
--no-exclude-directory-metadata did not apply to file comparison. (It now does,
to fix #888402).

Show extended filesystem metadata (etc.) even when directly comparing two files, not just when we specify two directories. (Closes: #888402)

Chris Lamb authored Jan 25, 2018 and Mattia Rizzolo committed Jan 25, 2018

Closes: #887180
Signed-off-by: Mattia Rizzolo <mattia@debian.org>

Gbp-Dch: ignore

Gbp-Dch: ignore

tests.comparators.test_elf: Return "unknown" if we can't parse the readelf version number eg. for FreeBSD. We don't skip those tests; as they should still run. (Closes: #886963)