• Juliana Oliveira Rodrigues's avatar
    tests: test_elf: fixed readelf exit code 1 · 9e2013fe
    Juliana Oliveira Rodrigues authored
    Due to a recent code change in readelf, when no section was found,
    readelf returned code 1 instead of the previous code 0. This behaviour
    change caused diffoscope to not append details whenever a section wasn't
    found, including in our own tests.
    
    The modification was made in version 2.29 of binutils and – although was
    quickly fixed in version 2.29.1 – leaves a version hole where diffoscope
    might not work as expected without further information.
    
    This patch adds a version checker for readelf where a few tests are
    ignored if someone happens to be using binutils 2.29.
    
    For more information on the change:
    binutils/readelf.c:get_section_contents
    
    Fixes #877728
    Signed-off-by: 's avatarJuliana Oliveira Rodrigues <juliana.orod@gmail.com>
    9e2013fe
Name
Last commit
Last update
bin Loading commit data...
debian Loading commit data...
diffoscope Loading commit data...
doc Loading commit data...
tests Loading commit data...
.coveragerc Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.travis.yml Loading commit data...
CONTRIBUTING.rst Loading commit data...
COPYING Loading commit data...
MANIFEST.in Loading commit data...
README.rst Loading commit data...
logo.svg Loading commit data...
setup.py Loading commit data...