Allow to remove sudo without a root password (needed for the "run piuparts" job)
Merge request reports
Activity
mentioned in merge request samba-team/samba!10 (merged)
mentioned in commit samba-team/samba@599f4648
As this is not intended to be a replacement of piuparts.d.o, we'd rather run piuparts as strict as is run in there.
Digging a bit, @tin found that they run with
--warn-on-others --allow-database --warn-on-leftovers-after-purge
.From
--warn-others
:If a package that is brought in as a dependency doesn’t purge cleanly, the test will not fail because of it (but a warning message will be printed).
Would you mind running your pipeline with this configs?
This is orthogonal to the sudo problem, which is about empty root password.
Currently I can't run the pipeline with those configs as I'm stuck with the experimental pb (see samba-team/samba!10 (comment 47396))
The first question we asked us when we saw this was... Hey, why this works on piuparts.d.o? Then, we found that we are not using the same command line.
We want to run piuparts in the exact same way that piuparts.d.o does, so we are going to change it passing the parameters that @ina-guest pointed above. If I understood correctly, releasing the current master of samba package won't pass in piuparts.d.o neither because it'll need experimental. Just trying to understand what are the differences between running piuparts here and the service provided by debian-qa.
This sudo problem is fixed on piuparts.debian.org by setting the password:
#!/bin/sh set -e # sudo refuses removal if no root password is set, so set one # do this unconditionally, as there are quite some packages depending on sudo # (and since its harmless and fast) yes "yes" 2>/dev/null | passwd
(See https://salsa.debian.org/debian/piuparts/blob/develop/custom-scripts/scripts/pre_test_root_password)
Maybe we should use
--scriptdir
?It is not possible to use
--warn-on-others
as this "could be problematic" "with multiple packages given" (See piuparts (1)).I will propose this, once debian/piuparts!2 (merged) is fixed:
piuparts --scriptsdir /etc/piuparts/scripts --allow-database --warn-on-leftovers-after-purge --hard-link -e ${CHROOT_PATH} ${WORKING_DIR}/*.deb
Replaced by !40 (merged) (with
--scriptsdir
)