• Stefan Metzmacher's avatar
    dbcheck: detect the change after deletion bug · 107883df
    Stefan Metzmacher authored
    Old versions of 'samba-tool dbcheck' could reanimate
    deleted objects, when running at the same time as the
    tombstone garbage collection.
    
    When the (deleted) parent of a deleted object
    (with the DISALLOW_MOVE_ON_DELETE bit in systemFlags),
    is removed before the object itself, dbcheck moved
    it in the LostAndFound[Config] subtree of the partition
    as an originating change. That means that the object
    will be in tombstone state again for 180 days on the local
    DC. And other DCs fail to replicate the object as
    it's already removed completely there and the replication
    only gives the name and lastKnownParent attributes, because
    all other attributes should already be known to the other DC.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13816Signed-off-by: 's avatarStefan Metzmacher <metze@samba.org>
    Reviewed-by: 's avatarAndrew Bartlett <abartlet@samba.org>
    (cherry picked from commit a1658b30)
    107883df
dbchecker.py 123 KB