• Volker Lendecke's avatar
    smbd: Fix a panic · bd511655
    Volker Lendecke authored
    Opening a file with a stale (smbd died) LEVEL_II oplock makes
    
    vfs_set_filelen-> ... ->contend_level2_oplocks_begin_default
    
    trigger the immediate leading to do_break_to_none. This goes through
    because fsp->oplock_type is not initialized yet, thus 0. Also,
    file_has_read_oplocks is still valid, because the smbd that has died
    could not clean up the brlock.tdb entry.
    
    Later in the code the exclusive oplock is granted, which is then found
    by do_break_to_none, making it panic.
    
    This patch just runs the direct FTRUNCATE instead of vfs_set_filelen.
    This means the contend_level2_oplock code is skipped.
    
    The relevant break (LEVEL_II to NONE) is now done in delay_for_oplock()
    with the nice effect of removing a comment that was very confusing to
    me.
    
    Bug: https://bugzilla.samba.org/show_bug.cgi?id=13957Signed-off-by: 's avatarVolker Lendecke <vl@samba.org>
    Reviewed-by: 's avatarRalph Boehme <slow@samba.org>
    
    Autobuild-User(master): Ralph Böhme <slow@samba.org>
    Autobuild-Date(master): Wed May 22 20:09:29 UTC 2019 on sn-devel-184
    bd511655