Commit 2332c99c authored by Ralph Boehme's avatar Ralph Boehme Committed by Karolin Seeger

libcli/smb: don't overwrite status code

The original commit c5cd22b5 from bug
9175 never worked, as the preceeding signing check overwrote the status
variable.

Bug: https://bugzilla.samba.org/show_bug.cgi?id=9175Signed-off-by: default avatarRalph Boehme <slow@samba.org>
Reviewed-by: default avatarStefan Metzmacher <metze@samba.org>

Autobuild-User(master): Ralph Böhme <slow@samba.org>
Autobuild-Date(master): Tue Nov 13 17:28:45 CET 2018 on sn-devel-144

(cherry picked from commit 5a8583ed)
parent 739ce2c7
......@@ -3908,15 +3908,17 @@ static NTSTATUS smb2cli_conn_dispatch_incoming(struct smbXcli_conn *conn,
}
if (signing_key) {
status = smb2_signing_check_pdu(*signing_key,
state->conn->protocol,
&cur[1], 3);
if (!NT_STATUS_IS_OK(status)) {
NTSTATUS signing_status;
signing_status = smb2_signing_check_pdu(*signing_key,
state->conn->protocol,
&cur[1], 3);
if (!NT_STATUS_IS_OK(signing_status)) {
/*
* If the signing check fails, we disconnect
* the connection.
*/
return status;
return signing_status;
}
}
......
^samba3.smb2.session krb5.expire_disconnect\(ad_dc\)
^samba3.smb2.session krb5.expire_disconnect\(ad_member\)
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment