1. 17 May, 2019 8 commits
  2. 15 May, 2019 6 commits
  3. 14 May, 2019 2 commits
  4. 07 May, 2019 5 commits
  5. 01 May, 2019 3 commits
  6. 30 Apr, 2019 2 commits
  7. 24 Apr, 2019 12 commits
  8. 15 Apr, 2019 2 commits
    • Amitay Isaacs's avatar
      ctdb-common: Avoid race between fd and signal events · 945a41d3
      Amitay Isaacs authored
      BUG: https://bugzilla.samba.org/show_bug.cgi?id=13895
      
      In run_proc, there was an implicit assumption that when a process exits,
      fd event (pipe between parent and child) would be processed first and
      signal event (SIGCHLD for the child) would be processed later.
      
      However, that is not the case.  SIGCHLD can be received asynchronously
      any time even when the pipe data has not fully been read.  This causes
      run_proc to miss some of the output from child process in tests.
      
      When SIGCHLD is being processed, if the pipe between parent and child is
      still open, then do an explict read from the pipe to ensure we read any
      data still in the pipe before closing the pipe.
      Signed-off-by: 's avatarAmitay Isaacs <amitay@gmail.com>
      Reviewed-by: 's avatarMartin Schwenke <martin@meltin.net>
      
      Autobuild-User(master): Amitay Isaacs <amitay@samba.org>
      Autobuild-Date(master): Fri Apr 12 08:19:29 UTC 2019 on sn-devel-144
      
      (cherry picked from commit 289201277cd983b27cdfd5376c607eab112b4082)
      
      Autobuild-User(v4-9-test): Karolin Seeger <kseeger@samba.org>
      Autobuild-Date(v4-9-test): Mon Apr 15 12:55:46 UTC 2019 on sn-devel-144
      945a41d3
    • Martin Schwenke's avatar
      ctdb-daemon: Revert "We can not assume that just because we could complete a TCP handshake" · d9c47cb8
      Martin Schwenke authored
      We also can not assume that nodes can be marked as connected via only
      the keepalive mechanism.  Keepalives are not sent to disconnected
      nodes so, in the absence of other packets (e.g. broadcasts), 2 nodes
      may never become marked as connected to each other.
      
      Revert to marking nodes as connected in the TCP transport code.  If a
      connection is to a non(-operational) ctdbd then it will revert to
      disconnected after a short while and may actually flap.  This should
      be rare.
      
      This reverts commit 66919db3.
      
      BUG: https://bugzilla.samba.org/show_bug.cgi?id=13888Signed-off-by: 's avatarMartin Schwenke <martin@meltin.net>
      Reviewed-by: 's avatarAmitay Isaacs <amitay@gmail.com>
      (cherry picked from commit 38dc6d11a26c2e9a2cae7927321f2216ceb1c5ec)
      d9c47cb8