Skip to content
Commits on Source (87)
Show whitespace changes
Inline Side-by-side
VERSION
View file @ 6d3c629b
......@@ -25,7 +25,7 @@
########################################################
SAMBA_VERSION_MAJOR=4
SAMBA_VERSION_MINOR=11
SAMBA_VERSION_RELEASE=0
SAMBA_VERSION_RELEASE=1
########################################################
# If a official release has a serious bug #
......
WHATSNEW.txt
View file @ 6d3c629b
==============================
Release Notes for Samba 4.11.1
October 18, 2019
==============================
This is the latest stable release of the Samba 4.11 release series.
Changes since 4.11.0:
---------------------
o Michael Adam <obnox@samba.org>
* BUG 14141: getpwnam and getpwuid need to return data for ID_TYPE_BOTH
group.
o Jeremy Allison <jra@samba.org>
* BUG 14094: smbc_readdirplus() is incompatible with smbc_telldir() and
smbc_lseekdir().
* BUG 14152: s3: smbclient: Stop an SMB2-connection from blundering into
SMB1-specific calls.
o Ralph Boehme <slow@samba.org>
* BUG 14137: Fix stale file handle error when using mkstemp on a share.
o Isaac Boukris <iboukris@gmail.com>
* BUG 14106: Fix spnego fallback from kerberos to ntlmssp in smbd server.
* BUG 14140: Overlinking libreplace against librt and pthread against every
binary or library causes issues.
o Günther Deschner <gd@samba.org>
* BUG 14130: s3-winbindd: Fix forest trusts with additional trust attributes.
* BUG 14134: auth/gensec: Fix non-AES schannel seal.
o Amitay Isaacs <amitay@gmail.com>
* BUG 14147: Deleted records can be resurrected during recovery.
o Björn Jacke <bj@sernet.de>
* BUG 14136: Fix uncaught exception in classicupgrade.
* BUG 14139: fault.c: Improve fault_report message text pointing to our wiki.
o Bryan Mason <bmason@redhat.com>
* BUG 14128: s3:client: Use DEVICE_URI, instead of argv[0], for Device URI.
o Stefan Metzmacher <metze@samba.org>
* BUG 14124: pam_winbind with krb5_auth or wbinfo -K doesn't work for users
of trusted domains/forests.
o Mathieu Parent <math.parent@gmail.com>
* BUG 14131: Remove 'pod2man' as it is no longer needed.
o Andreas Schneider <asn@samba.org>
* BUG 13884: Joining Active Directory should not use SAMR to set the
password.
* BUG 14140: Overlinking libreplace against librt and pthread against every
binary or library causes issues.
* BUG 14155: 'kpasswd' fails when built with MIT Kerberos.
o Martin Schwenke <martin@meltin.net>
* BUG 14129: Exit code of ctdb nodestatus should not be influenced by deleted
nodes.
#######################################
Reporting bugs & Development Discussion
#######################################
Please discuss this release on the samba-technical mailing list or by
joining the #samba-technical IRC channel on irc.freenode.net.
If you do report problems then please try to send high quality
feedback. If you don't provide vital information to help us track down
the problem then you will probably be ignored. All bug reports should
be filed under the "Samba 4.1 and newer" product in the project's Bugzilla
database (https://bugzilla.samba.org/).
======================================================================
== Our Code, Our Bugs, Our Responsibility.
== The Samba Team
======================================================================
Release notes for older releases follow:
----------------------------------------
==============================
Release Notes for Samba 4.11.0
September 17, 2019
......
auth/gensec/schannel.c
View file @ 6d3c629b
......@@ -296,6 +296,15 @@ static NTSTATUS netsec_do_seal(struct schannel_state *state,
ZERO_ARRAY(_sealing_key);
return gnutls_error_to_ntstatus(rc, NT_STATUS_CRYPTO_SYSTEM_INVALID);
}
gnutls_cipher_deinit(cipher_hnd);
rc = gnutls_cipher_init(&cipher_hnd,
GNUTLS_CIPHER_ARCFOUR_128,
&sealing_key,
NULL);
if (rc < 0) {
ZERO_ARRAY(_sealing_key);
return gnutls_error_to_ntstatus(rc, NT_STATUS_CRYPTO_SYSTEM_INVALID);
}
rc = gnutls_cipher_encrypt(cipher_hnd,
data,
length);
......
auth/gensec/spnego.c
View file @ 6d3c629b
......@@ -136,6 +136,7 @@ struct spnego_state {
bool done_mic_check;
bool simulate_w2k;
bool no_optimistic;
/*
* The following is used to implement
......@@ -187,6 +188,10 @@ static NTSTATUS gensec_spnego_client_start(struct gensec_security *gensec_securi
spnego_state->simulate_w2k = gensec_setting_bool(gensec_security->settings,
"spnego", "simulate_w2k", false);
spnego_state->no_optimistic = gensec_setting_bool(gensec_security->settings,
"spnego",
"client_no_optimistic",
false);
gensec_security->private_data = spnego_state;
return NT_STATUS_OK;
......@@ -511,7 +516,11 @@ static NTSTATUS gensec_spnego_client_negTokenInit_start(
}
n->mech_idx = 0;
n->mech_types = spnego_in->negTokenInit.mechTypes;
/* Do not use server mech list as it isn't protected. Instead, get all
* supported mechs (excluding SPNEGO). */
n->mech_types = gensec_security_oids(gensec_security, n,
GENSEC_OID_SPNEGO);
if (n->mech_types == NULL) {
return NT_STATUS_INVALID_PARAMETER;
}
......@@ -658,13 +667,30 @@ static NTSTATUS gensec_spnego_client_negTokenInit_finish(
DATA_BLOB *out)
{
struct spnego_data spnego_out;
const char *my_mechs[] = {NULL, NULL};
const char * const *mech_types = NULL;
bool ok;
my_mechs[0] = spnego_state->neg_oid;
if (n->mech_types == NULL) {
DBG_WARNING("No mech_types list\n");
return NT_STATUS_INVALID_PARAMETER;
}
for (mech_types = n->mech_types; *mech_types != NULL; mech_types++) {
int cmp = strcmp(*mech_types, spnego_state->neg_oid);
if (cmp == 0) {
break;
}
}
if (*mech_types == NULL) {
DBG_ERR("Can't find selected sub mechanism in mech_types\n");
return NT_STATUS_INVALID_PARAMETER;
}
/* compose reply */
spnego_out.type = SPNEGO_NEG_TOKEN_INIT;
spnego_out.negTokenInit.mechTypes = my_mechs;
spnego_out.negTokenInit.mechTypes = mech_types;
spnego_out.negTokenInit.reqFlags = data_blob_null;
spnego_out.negTokenInit.reqFlagsPadding = 0;
spnego_out.negTokenInit.mechListMIC = data_blob_null;
......@@ -676,7 +702,7 @@ static NTSTATUS gensec_spnego_client_negTokenInit_finish(
}
ok = spnego_write_mech_types(spnego_state,
my_mechs,
mech_types,
&spnego_state->mech_types);
if (!ok) {
DBG_ERR("failed to write mechTypes\n");
......@@ -1295,6 +1321,10 @@ static NTSTATUS gensec_spnego_server_negTokenInit_step(
spnego_state->mic_requested = true;
}
if (sub_in.length == 0) {
spnego_state->no_optimistic = true;
}
/*
* Note that 'cur_sec' is temporary memory, but
* cur_sec->oid points to a const string in the
......@@ -1923,6 +1953,21 @@ static void gensec_spnego_update_pre(struct tevent_req *req)
* blob and NT_STATUS_OK.
*/
state->sub.status = NT_STATUS_OK;
} else if (spnego_state->state_position == SPNEGO_CLIENT_START &&
spnego_state->no_optimistic) {
/*
* Skip optimistic token per conf.
*/
state->sub.status = NT_STATUS_MORE_PROCESSING_REQUIRED;
} else if (spnego_state->state_position == SPNEGO_SERVER_START &&
state->sub.in.length == 0 && spnego_state->no_optimistic) {
/*
* If we didn't like the mechanism for which the client sent us
* an optimistic token, or if he didn't send any, don't call
* the sub mechanism just yet.
*/
state->sub.status = NT_STATUS_MORE_PROCESSING_REQUIRED;
spnego_state->no_optimistic = false;
} else {
/*
* MORE_PROCESSING_REQUIRED =>
......
ctdb/doc/ctdb-etcd.7
View file @ 6d3c629b
......@@ -2,12 +2,12 @@
.\" Title: ctdb-etcd
.\" Author:
.\" Generator: DocBook XSL Stylesheets v1.79.1 <http://docbook.sf.net/>
.\" Date: 09/17/2019
.\" Date: 10/18/2019
.\" Manual: CTDB - clustered TDB database
.\" Source: ctdb
.\" Language: English
.\"
.TH "CTDB\-ETCD" "7" "09/17/2019" "ctdb" "CTDB \- clustered TDB database"
.TH "CTDB\-ETCD" "7" "10/18/2019" "ctdb" "CTDB \- clustered TDB database"
.\" -----------------------------------------------------------------
.\" * Define some portability stuff
.\" -----------------------------------------------------------------
......
ctdb/doc/ctdb-script.options.5
View file @ 6d3c629b
......@@ -2,12 +2,12 @@
.\" Title: ctdb-script.options
.\" Author:
.\" Generator: DocBook XSL Stylesheets v1.79.1 <http://docbook.sf.net/>
.\" Date: 09/17/2019
.\" Date: 10/18/2019
.\" Manual: CTDB - clustered TDB database
.\" Source: ctdb
.\" Language: English
.\"
.TH "CTDB\-SCRIPT\&.OPTIO" "5" "09/17/2019" "ctdb" "CTDB \- clustered TDB database"
.TH "CTDB\-SCRIPT\&.OPTIO" "5" "10/18/2019" "ctdb" "CTDB \- clustered TDB database"
.\" -----------------------------------------------------------------
.\" * Define some portability stuff
.\" -----------------------------------------------------------------
......
ctdb/doc/ctdb-statistics.7
View file @ 6d3c629b
......@@ -2,12 +2,12 @@
.\" Title: ctdb-statistics
.\" Author:
.\" Generator: DocBook XSL Stylesheets v1.79.1 <http://docbook.sf.net/>
.\" Date: 09/17/2019
.\" Date: 10/18/2019
.\" Manual: CTDB - clustered TDB database
.\" Source: ctdb
.\" Language: English
.\"
.TH "CTDB\-STATISTICS" "7" "09/17/2019" "ctdb" "CTDB \- clustered TDB database"
.TH "CTDB\-STATISTICS" "7" "10/18/2019" "ctdb" "CTDB \- clustered TDB database"
.\" -----------------------------------------------------------------
.\" * Define some portability stuff
.\" -----------------------------------------------------------------
......
ctdb/doc/ctdb-tunables.7
View file @ 6d3c629b
......@@ -2,12 +2,12 @@
.\" Title: ctdb-tunables
.\" Author:
.\" Generator: DocBook XSL Stylesheets v1.79.1 <http://docbook.sf.net/>
.\" Date: 09/17/2019
.\" Date: 10/18/2019
.\" Manual: CTDB - clustered TDB database
.\" Source: ctdb
.\" Language: English
.\"
.TH "CTDB\-TUNABLES" "7" "09/17/2019" "ctdb" "CTDB \- clustered TDB database"
.TH "CTDB\-TUNABLES" "7" "10/18/2019" "ctdb" "CTDB \- clustered TDB database"
.\" -----------------------------------------------------------------
.\" * Define some portability stuff
.\" -----------------------------------------------------------------
......
ctdb/doc/ctdb.1
View file @ 6d3c629b
......@@ -2,12 +2,12 @@
.\" Title: ctdb
.\" Author:
.\" Generator: DocBook XSL Stylesheets v1.79.1 <http://docbook.sf.net/>
.\" Date: 09/17/2019
.\" Date: 10/18/2019
.\" Manual: CTDB - clustered TDB database
.\" Source: ctdb
.\" Language: English
.\"
.TH "CTDB" "1" "09/17/2019" "ctdb" "CTDB \- clustered TDB database"
.TH "CTDB" "1" "10/18/2019" "ctdb" "CTDB \- clustered TDB database"
.\" -----------------------------------------------------------------
.\" * Define some portability stuff
.\" -----------------------------------------------------------------
......
ctdb/doc/ctdb.7
View file @ 6d3c629b
......@@ -2,12 +2,12 @@
.\" Title: ctdb
.\" Author:
.\" Generator: DocBook XSL Stylesheets v1.79.1 <http://docbook.sf.net/>
.\" Date: 09/17/2019
.\" Date: 10/18/2019
.\" Manual: CTDB - clustered TDB database
.\" Source: ctdb
.\" Language: English
.\"
.TH "CTDB" "7" "09/17/2019" "ctdb" "CTDB \- clustered TDB database"
.TH "CTDB" "7" "10/18/2019" "ctdb" "CTDB \- clustered TDB database"
.\" -----------------------------------------------------------------
.\" * Define some portability stuff
.\" -----------------------------------------------------------------
......
ctdb/doc/ctdb.conf.5
View file @ 6d3c629b
......@@ -2,12 +2,12 @@
.\" Title: ctdb.conf
.\" Author:
.\" Generator: DocBook XSL Stylesheets v1.79.1 <http://docbook.sf.net/>
.\" Date: 09/17/2019
.\" Date: 10/18/2019
.\" Manual: CTDB - clustered TDB database
.\" Source: ctdb
.\" Language: English
.\"
.TH "CTDB\&.CONF" "5" "09/17/2019" "ctdb" "CTDB \- clustered TDB database"
.TH "CTDB\&.CONF" "5" "10/18/2019" "ctdb" "CTDB \- clustered TDB database"
.\" -----------------------------------------------------------------
.\" * Define some portability stuff
.\" -----------------------------------------------------------------
......
ctdb/doc/ctdb.sysconfig.5
View file @ 6d3c629b
......@@ -2,12 +2,12 @@
.\" Title: ctdb.sysconfig
.\" Author:
.\" Generator: DocBook XSL Stylesheets v1.79.1 <http://docbook.sf.net/>
.\" Date: 09/17/2019
.\" Date: 10/18/2019
.\" Manual: CTDB - clustered TDB database
.\" Source: ctdb
.\" Language: English
.\"
.TH "CTDB\&.SYSCONFIG" "5" "09/17/2019" "ctdb" "CTDB \- clustered TDB database"
.TH "CTDB\&.SYSCONFIG" "5" "10/18/2019" "ctdb" "CTDB \- clustered TDB database"
.\" -----------------------------------------------------------------
.\" * Define some portability stuff
.\" -----------------------------------------------------------------
......
ctdb/doc/ctdb_diagnostics.1
View file @ 6d3c629b
......@@ -2,12 +2,12 @@
.\" Title: ctdb_diagnostics
.\" Author:
.\" Generator: DocBook XSL Stylesheets v1.79.1 <http://docbook.sf.net/>
.\" Date: 09/17/2019
.\" Date: 10/18/2019
.\" Manual: CTDB - clustered TDB database
.\" Source: ctdb
.\" Language: English
.\"
.TH "CTDB_DIAGNOSTICS" "1" "09/17/2019" "ctdb" "CTDB \- clustered TDB database"
.TH "CTDB_DIAGNOSTICS" "1" "10/18/2019" "ctdb" "CTDB \- clustered TDB database"
.\" -----------------------------------------------------------------
.\" * Define some portability stuff
.\" -----------------------------------------------------------------
......
ctdb/doc/ctdb_mutex_ceph_rados_helper.7
View file @ 6d3c629b
......@@ -2,12 +2,12 @@
.\" Title: Ceph RADOS Mutex
.\" Author:
.\" Generator: DocBook XSL Stylesheets v1.79.1 <http://docbook.sf.net/>
.\" Date: 09/17/2019
.\" Date: 10/18/2019
.\" Manual: CTDB - clustered TDB database
.\" Source: ctdb
.\" Language: English
.\"
.TH "CEPH RADOS MUTEX" "7" "09/17/2019" "ctdb" "CTDB \- clustered TDB database"
.TH "CEPH RADOS MUTEX" "7" "10/18/2019" "ctdb" "CTDB \- clustered TDB database"
.\" -----------------------------------------------------------------
.\" * Define some portability stuff
.\" -----------------------------------------------------------------
......
ctdb/doc/ctdbd.1
View file @ 6d3c629b
......@@ -2,12 +2,12 @@
.\" Title: ctdbd
.\" Author:
.\" Generator: DocBook XSL Stylesheets v1.79.1 <http://docbook.sf.net/>
.\" Date: 09/17/2019
.\" Date: 10/18/2019
.\" Manual: CTDB - clustered TDB database
.\" Source: ctdb
.\" Language: English
.\"
.TH "CTDBD" "1" "09/17/2019" "ctdb" "CTDB \- clustered TDB database"
.TH "CTDBD" "1" "10/18/2019" "ctdb" "CTDB \- clustered TDB database"
.\" -----------------------------------------------------------------
.\" * Define some portability stuff
.\" -----------------------------------------------------------------
......
ctdb/doc/ctdbd_wrapper.1
View file @ 6d3c629b
......@@ -2,12 +2,12 @@
.\" Title: ctdbd_wrapper
.\" Author:
.\" Generator: DocBook XSL Stylesheets v1.79.1 <http://docbook.sf.net/>
.\" Date: 09/17/2019
.\" Date: 10/18/2019
.\" Manual: CTDB - clustered TDB database
.\" Source: ctdb
.\" Language: English
.\"
.TH "CTDBD_WRAPPER" "1" "09/17/2019" "ctdb" "CTDB \- clustered TDB database"
.TH "CTDBD_WRAPPER" "1" "10/18/2019" "ctdb" "CTDB \- clustered TDB database"
.\" -----------------------------------------------------------------
.\" * Define some portability stuff
.\" -----------------------------------------------------------------
......
ctdb/doc/ltdbtool.1
View file @ 6d3c629b
......@@ -2,12 +2,12 @@
.\" Title: ltdbtool
.\" Author:
.\" Generator: DocBook XSL Stylesheets v1.79.1 <http://docbook.sf.net/>
.\" Date: 09/17/2019
.\" Date: 10/18/2019
.\" Manual: CTDB - clustered TDB database
.\" Source: ctdb
.\" Language: English
.\"
.TH "LTDBTOOL" "1" "09/17/2019" "ctdb" "CTDB \- clustered TDB database"
.TH "LTDBTOOL" "1" "10/18/2019" "ctdb" "CTDB \- clustered TDB database"
.\" -----------------------------------------------------------------
.\" * Define some portability stuff
.\" -----------------------------------------------------------------
......
ctdb/doc/onnode.1
View file @ 6d3c629b
......@@ -2,12 +2,12 @@
.\" Title: onnode
.\" Author:
.\" Generator: DocBook XSL Stylesheets v1.79.1 <http://docbook.sf.net/>
.\" Date: 09/17/2019
.\" Date: 10/18/2019
.\" Manual: CTDB - clustered TDB database
.\" Source: ctdb
.\" Language: English
.\"
.TH "ONNODE" "1" "09/17/2019" "ctdb" "CTDB \- clustered TDB database"
.TH "ONNODE" "1" "10/18/2019" "ctdb" "CTDB \- clustered TDB database"
.\" -----------------------------------------------------------------
.\" * Define some portability stuff
.\" -----------------------------------------------------------------
......
ctdb/doc/ping_pong.1
View file @ 6d3c629b
......@@ -2,12 +2,12 @@
.\" Title: ping_pong
.\" Author:
.\" Generator: DocBook XSL Stylesheets v1.79.1 <http://docbook.sf.net/>
.\" Date: 09/17/2019
.\" Date: 10/18/2019
.\" Manual: CTDB - clustered TDB database
.\" Source: ctdb
.\" Language: English
.\"
.TH "PING_PONG" "1" "09/17/2019" "ctdb" "CTDB \- clustered TDB database"
.TH "PING_PONG" "1" "10/18/2019" "ctdb" "CTDB \- clustered TDB database"
.\" -----------------------------------------------------------------
.\" * Define some portability stuff
.\" -----------------------------------------------------------------
......
ctdb/server/ctdb_vacuum.c
View file @ 6d3c629b
......@@ -814,7 +814,7 @@ static void ctdb_process_delete_list(struct ctdb_db_context *ctdb_db,
*/
records = (struct ctdb_marshall_buffer *)outdata.dptr;
rec = (struct ctdb_rec_data_old *)&records->data[0];
while (records->count-- > 1) {
while (records->count-- > 0) {
TDB_DATA reckey, recdata;
struct ctdb_ltdb_header *rechdr;
struct delete_record_data *dd;
......