Commits on Source (31)
-
Karolin Seeger authored
and re-enable GIT_SNAPSHOT. Signed-off-by:Karolin Seeger <kseeger@samba.org>
f1bf8d74 -
Gary Lockyer authored
It is not the job of the index code to enforce this, but do give a a warning given it has been detected. However, now that we do allow it, we must never return the same object twice to the caller, so filter for it in ltdb_index_filter(). The GUID list is sorted, which makes this cheap to handle, thankfully. Signed-off-by:
Gary Lockyer <gary@catalyst.net.nz> Reviewed-by:
Douglas Bagnall <douglas.bagnall@catalyst.net.nz> Reviewed-by:
Andrew Bartlett <abartlet@samba.org> BUG: https://bugzilla.samba.org/show_bug.cgi?id=13335 (cherry picked from commit 5c1504b9)
b1ac0944 -
Gary Lockyer authored
Tests for the index truncation code as well as the GUID index format in general. Covers truncation of both the DN and equality search keys. Signed-off-by:
3f15f1c6 -
Andrew Bartlett authoredThe re-index traverse can abort part-way though and we need to ensure that the transaction is never committed as that will leave an un-useable db. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13335 Signed-off-by:
7f70fcd8 -
Gary Lockyer authored
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13335 Signed-off-by:
89ce0d90 -
Andrew Bartlett authored
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13335 Signed-off-by:
21e10ff3 -
Andrew Bartlett authored
* Fix failure to upgrade to the GUID index DB format * Add tests for GUID index behaviour BUG: https://bugzilla.samba.org/show_bug.cgi?id=13306 Signed-off-by:
Stefan Metzmacher <metze@samba.org>
bf0a6646 -
Stefan Metzmacher authored
Bug: https://bugzilla.samba.org/show_bug.cgi?id=13400 Signed-off-by:
Volker Lendecke <vl@samba.org> (cherry picked from commit ffe97000) Autobuild-User(v4-8-test): Stefan Metzmacher <metze@samba.org> Autobuild-Date(v4-8-test): Wed May 2 18:56:45 CEST 2018 on sn-devel-144
13f23ec1 -
Jeremy Allison authored
When returning the stat struct for an xattr stream, we originally base the st_ex_mode field on the value from the base file containing the xattr. If the base file is a directory, it will have S_IFDIR set in st_ex_mode, but streams can never be directories, they must be reported as regular files. The original code OR'ed in S_IFREG, but neglected to AND out S_IFDIR. Note this is not a complete to fix bug 13380 as it doesn't fix the generic case with all streams modules. See later fix and regression test. Found in real-world use case by Andrew Walker <awalker@ixsystems.com>. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13380 Signed-off-by:
Jeremy Allison <jra@samba.org> Reviewed-by:
Ralph Böhme <slow@samba.org> (cherry picked from commit 4d839d0f)
ace735eb -
Jeremy Allison authored
According to MS-FSA a stream name does not have separate DOS attribute metadata, so we must return the DOS attribute from the base filename. With one caveat, a non-default stream name can never be a directory. As this is common to all streams data stores, we handle it here instead of inside all stream VFS modules. Otherwise identical logic would have to be added to all streams modules in their [f]get_dos_attribute_fn() VFS calls. Found in real-world use case by Andrew Walker <awalker@ixsystems.com>. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13380 Signed-off-by:
3d4a8f2c -
Jeremy Allison authored
Tests streams_xattr and also streams_depot. Inspired from a real-world test case by Andrew Walker <awalker@ixsystems.com>. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13380 Signed-off-by:
81e7736c -
Björn Jacke authored
Some print drivers inf files are broken and cause driver installation to fail on Samba servers. Windows returns WERR_APP_INIT_FAILURE in that case, we should do the same. Windows machines are less unlucky with that. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13395 Signed-off-by:
Bjoern Jacke <bjacke@samba.org> Reviewed-by:
Andreas Schneider <asn@samba.org> Autobuild-User(master): Björn Jacke <bj@sernet.de> Autobuild-Date(master): Wed Apr 25 13:55:25 CEST 2018 on sn-devel-144 (cherry picked from commit 35f2afe4)
24a933e7 -
Christof Schmitt authored
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13407 Signed-off-by:
Christof Schmitt <cs@samba.org> Reviewed-by:
b7b08709 -
Christof Schmitt authored
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13407 Signed-off-by:
2fcd26a3 -
Christof Schmitt authored
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13407 Signed-off-by:
7cfaf700 -
Amitay Isaacs authored
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13411 Signed-off-by:
Amitay Isaacs <amitay@gmail.com> Reviewed-by:
Martin Schwenke <martin@meltin.net> (cherry picked from commit 01c8dc7e)
bde66337 -
Jeremy Allison authored
This will allow me to ultimately simplify the VFS by removing the synchronous fsync VFS call. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13412 Signed-off-by:
0ccfe320 -
Ralph Boehme authored
Since 6423ca4b messaging_send_all() broadcasts messages in a cluster, so cleanupd receives those broadcasts and acts upon it by re-broadcasting the message. Result: message storm. By reactivating the currently unused MSG_SMB_BRL_VALIDATE for the trigger message to cleanupd we avoid the storm. Note that MSG_SMB_BRL_VALIDATE was unused only in the sense that noone *listened* to it, but we were still *sending* the message in smbd_parent_ctdb_reconfigured(). de6fe2a1 removed listening for MSG_SMB_BRL_VALIDATE from cleanupd. This commits brings it back. Bug: https://bugzilla.samba.org/show_bug.cgi?id=13414 Signed-off-by:
dc7b7bee -
Jeremy Allison authored
We shouldn't hard-code the connection error as ETIMEDOUT when we have a perfectly good NT_STATUS to map from. Found by the ChromeOS guys trying to connect an SMB2-only client to an SMB1-only supporting server. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13419 Signed-off-by:
Volker Lendecke <Volker.Lendecke@SerNet.DE> Autobuild-User(master): Jeremy Allison <jra@samba.org> Autobuild-Date(master): Thu May 3 02:42:20 CEST 2018 on sn-devel-144 (cherry picked from commit 795ec751) Autobuild-User(v4-8-test): Karolin Seeger <kseeger@samba.org> Autobuild-Date(v4-8-test): Mon May 7 14:25:28 CEST 2018 on sn-devel-144
02b898e4 -
Andreas Schneider authored
This also checks that the URI given via the environment variables starts with smb:// Signed-off-by:
Alexander Bokovoy <ab@samba.org> Reviewed-by:
David Disseldorp <ddiss@samba.org> (cherry picked from commit a6eac8f6)
4a9c164d -
Andreas Schneider authored
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13417 Signed-off-by:
bb5cee36 -
Ralph Boehme authored
MSG_SMB_UNLOCK should be send to smbd that are waiting on blocked byte-range-locks when a lock holder died. In smbd_cleanupd_unlock() we do this twice: once via a broadcast and then again via brl_revalidate() to processes that are actually recorded in brlock.tdb. As brl_revalidate() should already take care of signaling anyone who would be interested in the message, there's no need to broadcast. Bug: https://bugzilla.samba.org/show_bug.cgi?id=13416 Signed-off-by:
1b34b869 -
Andrew Bartlett authored
This is a regression introduced in ab7988aa. The state variable contains the data to be returned to the client and packed into NDR after the function returned. This memory needs to be kept (on mem_ctx as parent) until that is pushed and freed by the caller. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13420 Signed-off-by:
234216c1 -
Stefan Metzmacher authored
This completes the regression fix of commit 7e091e50. There might be strings allocated on state, which are part of the result. The reason for the TALLOC_FREE(state) was to cleanup the possible irpc_handle before leaving the function. Now we call TALLOC_FREE(state->wb.irpc_handle) explicitly in dcesrv_lsa_Lookup{Names,Sids}_base_done() instead. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13420 Signed-off-by:
060a0479 -
Vandana Rungta authored
Centralize error handling. https://bugzilla.samba.org/show_bug.cgi?id=13424 Signed-off-by:
Vandana Rungta <vrungta@amazon.com> Reviewed-by:
01c335dd -
David Disseldorp authored
As found by Jeremy, VFS modules that don't provide pread_send() or pwrite_send() hooks result in vfs_default fallback, which is catastrophic for VFS modules with non-mounted filesystems such as vfs_ceph. Bug: https://bugzilla.samba.org/show_bug.cgi?id=13425 Reported-by:
54c537a0 -
Andrew Bartlett authored
This domain is very close, in AD DC configurations over a internal ncacn_np pipe and otherwise in the same process via C linking. It is however very expensive to re-create the binding handle per SID->name lookup, so keep a cache. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13430 Signed-off-by:
7557c5df -
Andrew Bartlett authored
This is very, very unlikely but possible as in the AD case the RPC server is in another process that may eventually be able to restart. BUG: https://bugzilla.samba.org/show_bug.cgi?id=13430 Signed-off-by:
32a5538a -
Karolin Seeger authored
Signed-off-by:5be589c6 -
Karolin Seeger authored
Signed-off-by:e64d0d03 -
Mathieu Parent authored3e3df112
This diff is collapsed.