Skip to content
Commits on Source (123)
23 additional commits have been omitted to prevent performance issues.
Show whitespace changes
Inline Side-by-side
VERSION
View file @ 25ee556a
......@@ -25,7 +25,7 @@
########################################################
SAMBA_VERSION_MAJOR=4
SAMBA_VERSION_MINOR=8
SAMBA_VERSION_RELEASE=4
SAMBA_VERSION_RELEASE=5
########################################################
# If a official release has a serious bug #
......
WHATSNEW.txt
View file @ 25ee556a
=============================
Release Notes for Samba 4.8.5
August 24, 2018
=============================
This is the latest stable release of the Samba 4.8 release series.
Changes since 4.8.4:
--------------------
o Jeremy Allison <jra@samba.org>
* BUG 13474: python: pysmbd: Additional error path leak fix.
* BUG 13511: libsmbclient: Initialize written value before use.
* BUG 13519: ldb: Refuse to build Samba against a newer minor version of
ldb.
* BUG 13527: s3: libsmbclient: Fix cli_splice() fallback when reading less
than a complete file.
* BUG 13537: Using "sendfile = yes" with SMB2 can cause CPU spin.
o Andrew Bartlett <abartlet@samba.org>
* BUG 13575: ldb: Release LDB 1.3.6.
o Bailey Berro <baileyberro@chromium.org>
* BUG 13511: libsmbclient: Initialize written in cli_splice_fallback().
o Ralph Boehme <slow@samba.org>
* BUG 13318: Durable Handles reconnect fails in a cluster when the cluster
fs uses different device ids.
* BUG 13351: s3: smbd: Always set vuid in check_user_ok().
* BUG 13441: vfs_fruit: Delete 0 byte size streams if AAPL is enabled.
* BUG 13451: Fail renaming file if that file has open streams.
* BUG 13505: lib: smb_threads: Fix access before init bug.
* BUG 13535: s3: smbd: Fix path check in
smbd_smb2_create_durable_lease_check().
o Alexander Bokovoy <ab@samba.org>
* BUG 13538: samba-tool trust: Support discovery via netr_GetDcName.
o Samuel Cabrero <scabrero@suse.de>
* BUG 13540: ctdb_mutex_ceph_rados_helper: Set SIGINT signal handler.
o David Disseldorp <ddiss@samba.org>
* BUG 13506: vfs_ceph: Don't lie about flock support.
* BUG 13540: Fix deadlock with ctdb_mutex_ceph_rados_helper.
o Amitay Isaacs <amitay@gmail.com>
* BUG 13493: ctdb: Fix build on FreeBSD and AIX.
o Volker Lendecke <vl@samba.org>
* BUG 13553: libsmb: Fix CID 1438243 (Unchecked return value), CID 1438244
(Unsigned compared against 0), CID 1438245 (Dereference before null check),
CID 1438246 (Unchecked return value).
* BUG 13584: vfs_fruit: Fix a panic if fruit_access_check detects a locking
conflict.
o Gary Lockyer <gary@catalyst.net.nz>
* BUG 13536: The current position in the dns name was not advanced past the
'.' character.
o Stefan Metzmacher <metze@samba.org>
* BUG 13308: samba-tool domain trust: Fix trust compatibility to Windows
Server 1709 and FreeIPA.
o Oleksandr Natalenko <oleksandr@redhat.com>
* BUG 13559: systemd: Only start smb when network interfaces are up.
o Noel Power <noel.power@suse.com>
* BUG 13553: Fix quotas with SMB2.
* BUG 13563: s3/smbd: Ensure quota code is only called when quota support
detected.
o Anoop C S <anoopcs@redhat.com>
* BUG 13204: s3/libsmb: Explicitly set delete_on_close token for rmdir.
o Andreas Schneider <asn@samba.org>
* BUG 13489: krb5_plugin: Install plugins to krb5 modules dir.
* BUG 13503: s3:winbind: Do not lookup local system accounts in AD.
o Martin Schwenke <martin@meltin.net>
* BUG 13499: Don't use CTDB_BROADCAST_VNNMAP.
* BUG 13500: ctdb-daemon: Only consider client ID for local database attach.
o Justin Stephenson <jstephen@redhat.com>
* BUG 13485: s3:client: Add "--quiet" option to smbclient.
o Ralph Wuerthner <ralph.wuerthner@de.ibm.com>
* BUG 13568: s3: vfs: time_audit: Fix handling of token_blob in
smb_time_audit_offload_read_recv().
#######################################
Reporting bugs & Development Discussion
#######################################
Please discuss this release on the samba-technical mailing list or by
joining the #samba-technical IRC channel on irc.freenode.net.
If you do report problems then please try to send high quality
feedback. If you don't provide vital information to help us track down
the problem then you will probably be ignored. All bug reports should
be filed under the "Samba 4.1 and newer" product in the project's Bugzilla
database (https://bugzilla.samba.org/).
======================================================================
== Our Code, Our Bugs, Our Responsibility.
== The Samba Team
======================================================================
Release notes for older releases follow:
----------------------------------------
=============================
Release Notes for Samba 4.8.4
August 14, 2018
......@@ -85,8 +200,8 @@ database (https://bugzilla.samba.org/).
======================================================================
Release notes for older releases follow:
----------------------------------------
----------------------------------------------------------------------
=============================
Release Notes for Samba 4.8.3
......
buildtools/wafsamba/samba_autoconf.py
View file @ 25ee556a
......@@ -365,7 +365,7 @@ def CHECK_CODE(conf, code, define,
headers=None, msg=None, cflags='', includes='# .',
local_include=True, lib=None, link=True,
define_ret=False, quote=False,
on_target=True):
on_target=True, strict=False):
'''check if some code compiles and/or runs'''
if CONFIG_SET(conf, define):
......@@ -395,6 +395,16 @@ def CHECK_CODE(conf, code, define,
cflags = TO_LIST(cflags)
# Be strict when relying on a compiler check
# Some compilers (e.g. xlc) ignore non-supported features as warnings
if strict:
extra_cflags = None
if conf.env["CC_NAME"] == "gcc":
extra_cflags = "-Werror"
elif conf.env["CC_NAME"] == "xlc":
extra_cflags = "-qhalt=w"
cflags.append(extra_cflags)
if local_include:
cflags.append('-I%s' % conf.curdir)
......
buildtools/wafsamba/wscript
View file @ 25ee556a
......@@ -374,6 +374,7 @@ def configure(conf):
conf.CHECK_CODE('''int main(void) { return 0; }
__attribute__((visibility("default"))) void vis_foo2(void) {}''',
cflags=conf.env.VISIBILITY_CFLAGS,
strict=True,
define='HAVE_VISIBILITY_ATTR', addmain=False)
# check HAVE_CONSTRUCTOR_ATTRIBUTE
......@@ -391,6 +392,7 @@ def configure(conf):
''',
'HAVE_CONSTRUCTOR_ATTRIBUTE',
addmain=False,
strict=True,
msg='Checking for library constructor support')
# check HAVE_DESTRUCTOR_ATTRIBUTE
......@@ -408,6 +410,7 @@ def configure(conf):
''',
'HAVE_DESTRUCTOR_ATTRIBUTE',
addmain=False,
strict=True,
msg='Checking for library destructor support')
conf.CHECK_CODE('''
......@@ -424,6 +427,7 @@ def configure(conf):
''',
'HAVE___ATTRIBUTE__',
addmain=False,
strict=True,
msg='Checking for __attribute__')
if sys.platform.startswith('aix'):
......
ctdb/client/client_tunnel.c
View file @ 25ee556a
......@@ -431,8 +431,8 @@ struct tevent_req *ctdb_tunnel_request_send(TALLOC_CTX *mem_ctx,
};
if (destnode == CTDB_BROADCAST_ALL ||
destnode == CTDB_BROADCAST_VNNMAP ||
destnode == CTDB_BROADCAST_ALL) {
destnode == CTDB_BROADCAST_ACTIVE ||
destnode == CTDB_BROADCAST_CONNECTED) {
state->wait_for_reply = false;
}
if (! state->wait_for_reply) {
......
ctdb/common/ctdb_util.c
View file @ 25ee556a
......@@ -389,8 +389,8 @@ void ctdb_canonicalize_ip(const ctdb_sock_addr *ip, ctdb_sock_addr *cip)
sizeof(cip->ip.sin_addr));
} else {
cip->ip6.sin6_family = AF_INET6;
#ifdef HAVE_SOCK_SIN_LEN
cip->ip6.sin_len = sizeof(ctdb_sock_addr);
#ifdef HAVE_SOCK_SIN6_LEN
cip->ip6.sin6_len = sizeof(ctdb_sock_addr);
#endif
cip->ip6.sin6_port = ip->ip6.sin6_port;
memcpy(&cip->ip6.sin6_addr,
......
ctdb/common/sock_io.c
View file @ 25ee556a
......@@ -275,7 +275,7 @@ int sock_queue_write(struct sock_queue *queue, uint8_t *buf, size_t buflen)
{
struct tevent_req *req;
struct sock_queue_write_state *state;
bool status;
struct tevent_queue_entry *qentry;
if (buflen >= INT32_MAX) {
return -1;
......@@ -289,9 +289,9 @@ int sock_queue_write(struct sock_queue *queue, uint8_t *buf, size_t buflen)
state->pkt = buf;
state->pkt_size = (uint32_t)buflen;
status = tevent_queue_add_entry(queue->queue, queue->ev, req,
qentry = tevent_queue_add_entry(queue->queue, queue->ev, req,
sock_queue_trigger, queue);
if (! status) {
if (qentry == NULL) {
talloc_free(req);
return -1;
}
......
ctdb/common/system_util.c
View file @ 25ee556a
......@@ -154,7 +154,7 @@ static bool parse_ipv6(const char *s, const char *ifaces, unsigned port, ctdb_so
saddr->ip6.sin6_scope_id = if_nametoindex(ifaces);
}
#ifdef HAVE_SOCK_SIN_LEN
#ifdef HAVE_SOCK_SIN6_LEN
saddr->ip6.sin6_len = sizeof(*saddr);
#endif
return true;
......
ctdb/doc/ctdb-etcd.7
View file @ 25ee556a
......@@ -2,12 +2,12 @@
.\" Title: ctdb-etcd
.\" Author:
.\" Generator: DocBook XSL Stylesheets v1.79.1 <http://docbook.sf.net/>
.\" Date: 08/11/2018
.\" Date: 08/24/2018
.\" Manual: CTDB - clustered TDB database
.\" Source: ctdb
.\" Language: English
.\"
.TH "CTDB\-ETCD" "7" "08/11/2018" "ctdb" "CTDB \- clustered TDB database"
.TH "CTDB\-ETCD" "7" "08/24/2018" "ctdb" "CTDB \- clustered TDB database"
.\" -----------------------------------------------------------------
.\" * Define some portability stuff
.\" -----------------------------------------------------------------
......
ctdb/doc/ctdb-statistics.7
View file @ 25ee556a
......@@ -2,12 +2,12 @@
.\" Title: ctdb-statistics
.\" Author:
.\" Generator: DocBook XSL Stylesheets v1.79.1 <http://docbook.sf.net/>
.\" Date: 08/11/2018
.\" Date: 08/24/2018
.\" Manual: CTDB - clustered TDB database
.\" Source: ctdb
.\" Language: English
.\"
.TH "CTDB\-STATISTICS" "7" "08/11/2018" "ctdb" "CTDB \- clustered TDB database"
.TH "CTDB\-STATISTICS" "7" "08/24/2018" "ctdb" "CTDB \- clustered TDB database"
.\" -----------------------------------------------------------------
.\" * Define some portability stuff
.\" -----------------------------------------------------------------
......
ctdb/doc/ctdb-tunables.7
View file @ 25ee556a
......@@ -2,12 +2,12 @@
.\" Title: ctdb-tunables
.\" Author:
.\" Generator: DocBook XSL Stylesheets v1.79.1 <http://docbook.sf.net/>
.\" Date: 08/11/2018
.\" Date: 08/24/2018
.\" Manual: CTDB - clustered TDB database
.\" Source: ctdb
.\" Language: English
.\"
.TH "CTDB\-TUNABLES" "7" "08/11/2018" "ctdb" "CTDB \- clustered TDB database"
.TH "CTDB\-TUNABLES" "7" "08/24/2018" "ctdb" "CTDB \- clustered TDB database"
.\" -----------------------------------------------------------------
.\" * Define some portability stuff
.\" -----------------------------------------------------------------
......
ctdb/doc/ctdb.1
View file @ 25ee556a
......@@ -2,12 +2,12 @@
.\" Title: ctdb
.\" Author:
.\" Generator: DocBook XSL Stylesheets v1.79.1 <http://docbook.sf.net/>
.\" Date: 08/11/2018
.\" Date: 08/24/2018
.\" Manual: CTDB - clustered TDB database
.\" Source: ctdb
.\" Language: English
.\"
.TH "CTDB" "1" "08/11/2018" "ctdb" "CTDB \- clustered TDB database"
.TH "CTDB" "1" "08/24/2018" "ctdb" "CTDB \- clustered TDB database"
.\" -----------------------------------------------------------------
.\" * Define some portability stuff
.\" -----------------------------------------------------------------
......@@ -164,7 +164,7 @@ Sometimes this number will be shown as "INVALID"\&. This only means that the ctd
\fBVirtual Node Number (VNN) map\fR
.RS 4
.PP
Consists of the number of virtual nodes and mapping from virtual node numbers to physical node numbers\&. Virtual nodes host CTDB databases\&. Only nodes that are participating in the VNN map can become lmaster or dmaster for database records\&.
Consists of the number of virtual nodes and mapping from virtual node numbers to physical node numbers\&. Only nodes that are participating in the VNN map can become lmaster for database records\&.
.RE
.sp
.it 1 an-trap
......
ctdb/doc/ctdb.1.html
View file @ 25ee556a
......@@ -96,10 +96,9 @@
through a recovery.
</p></div><div class="refsect3"><a name="idm128"></a><h4>Virtual Node Number (VNN) map</h4><p>
Consists of the number of virtual nodes and mapping from
virtual node numbers to physical node numbers. Virtual
nodes host CTDB databases. Only nodes that are
participating in the VNN map can become lmaster or dmaster
for database records.
virtual node numbers to physical node numbers. Only nodes
that are participating in the VNN map can become lmaster for
database records.
</p></div><div class="refsect3"><a name="idm131"></a><h4>Recovery mode</h4><p>
This is the current recovery mode of the cluster. There are two possible modes:
</p><p>
......
ctdb/doc/ctdb.1.xml
View file @ 25ee556a
......@@ -292,10 +292,9 @@
<title>Virtual Node Number (VNN) map</title>
<para>
Consists of the number of virtual nodes and mapping from
virtual node numbers to physical node numbers. Virtual
nodes host CTDB databases. Only nodes that are
participating in the VNN map can become lmaster or dmaster
for database records.
virtual node numbers to physical node numbers. Only nodes
that are participating in the VNN map can become lmaster for
database records.
</para>
</refsect3>
......
ctdb/doc/ctdb.7
View file @ 25ee556a
......@@ -2,12 +2,12 @@
.\" Title: ctdb
.\" Author:
.\" Generator: DocBook XSL Stylesheets v1.79.1 <http://docbook.sf.net/>
.\" Date: 08/11/2018
.\" Date: 08/24/2018
.\" Manual: CTDB - clustered TDB database
.\" Source: ctdb
.\" Language: English
.\"
.TH "CTDB" "7" "08/11/2018" "ctdb" "CTDB \- clustered TDB database"
.TH "CTDB" "7" "08/24/2018" "ctdb" "CTDB \- clustered TDB database"
.\" -----------------------------------------------------------------
.\" * Define some portability stuff
.\" -----------------------------------------------------------------
......
ctdb/doc/ctdb_diagnostics.1
View file @ 25ee556a
......@@ -2,12 +2,12 @@
.\" Title: ctdb_diagnostics
.\" Author:
.\" Generator: DocBook XSL Stylesheets v1.79.1 <http://docbook.sf.net/>
.\" Date: 08/11/2018
.\" Date: 08/24/2018
.\" Manual: CTDB - clustered TDB database
.\" Source: ctdb
.\" Language: English
.\"
.TH "CTDB_DIAGNOSTICS" "1" "08/11/2018" "ctdb" "CTDB \- clustered TDB database"
.TH "CTDB_DIAGNOSTICS" "1" "08/24/2018" "ctdb" "CTDB \- clustered TDB database"
.\" -----------------------------------------------------------------
.\" * Define some portability stuff
.\" -----------------------------------------------------------------
......
ctdb/doc/ctdb_mutex_ceph_rados_helper.7
View file @ 25ee556a
......@@ -2,12 +2,12 @@
.\" Title: Ceph RADOS Mutex
.\" Author:
.\" Generator: DocBook XSL Stylesheets v1.79.1 <http://docbook.sf.net/>
.\" Date: 08/11/2018
.\" Date: 08/24/2018
.\" Manual: CTDB - clustered TDB database
.\" Source: ctdb
.\" Language: English
.\"
.TH "CEPH RADOS MUTEX" "7" "08/11/2018" "ctdb" "CTDB \- clustered TDB database"
.TH "CEPH RADOS MUTEX" "7" "08/24/2018" "ctdb" "CTDB \- clustered TDB database"
.\" -----------------------------------------------------------------
.\" * Define some portability stuff
.\" -----------------------------------------------------------------
......
ctdb/doc/ctdbd.1
View file @ 25ee556a
......@@ -2,12 +2,12 @@
.\" Title: ctdbd
.\" Author:
.\" Generator: DocBook XSL Stylesheets v1.79.1 <http://docbook.sf.net/>
.\" Date: 08/11/2018
.\" Date: 08/24/2018
.\" Manual: CTDB - clustered TDB database
.\" Source: ctdb
.\" Language: English
.\"
.TH "CTDBD" "1" "08/11/2018" "ctdb" "CTDB \- clustered TDB database"
.TH "CTDBD" "1" "08/24/2018" "ctdb" "CTDB \- clustered TDB database"
.\" -----------------------------------------------------------------
.\" * Define some portability stuff
.\" -----------------------------------------------------------------
......
ctdb/doc/ctdbd.conf.5
View file @ 25ee556a
......@@ -2,12 +2,12 @@
.\" Title: ctdbd.conf
.\" Author:
.\" Generator: DocBook XSL Stylesheets v1.79.1 <http://docbook.sf.net/>
.\" Date: 08/11/2018
.\" Date: 08/24/2018
.\" Manual: CTDB - clustered TDB database
.\" Source: ctdb
.\" Language: English
.\"
.TH "CTDBD\&.CONF" "5" "08/11/2018" "ctdb" "CTDB \- clustered TDB database"
.TH "CTDBD\&.CONF" "5" "08/24/2018" "ctdb" "CTDB \- clustered TDB database"
.\" -----------------------------------------------------------------
.\" * Define some portability stuff
.\" -----------------------------------------------------------------
......
ctdb/doc/ctdbd_wrapper.1
View file @ 25ee556a
......@@ -2,12 +2,12 @@
.\" Title: ctdbd_wrapper
.\" Author:
.\" Generator: DocBook XSL Stylesheets v1.79.1 <http://docbook.sf.net/>
.\" Date: 08/11/2018
.\" Date: 08/24/2018
.\" Manual: CTDB - clustered TDB database
.\" Source: ctdb
.\" Language: English
.\"
.TH "CTDBD_WRAPPER" "1" "08/11/2018" "ctdb" "CTDB \- clustered TDB database"
.TH "CTDBD_WRAPPER" "1" "08/24/2018" "ctdb" "CTDB \- clustered TDB database"
.\" -----------------------------------------------------------------
.\" * Define some portability stuff
.\" -----------------------------------------------------------------
......