ctdb/client/client.h

@@ -31,7 +31,7 @@
  *
  * @brief Client api to talk to ctdb daemon
  *
- * This API allows to connect to ctdb daemon, perform various database
+ * This API allows one to connect to ctdb daemon, perform various database
  * operations, send controls to ctdb daemon and send messages to other ctdb
  * clients.
  */
@@ -193,7 +193,7 @@ int ctdb_client_wait_timeout(struct tevent_context *ev, bool *done,
  * @brief Async computation start to wait till recovery is completed
  *
  * CTDB daemon does not perform many operations while in recovery (especially
- * database operations).  This computation allows to wait till ctdb daemon has
+ * database operations).  This computation allows one to wait till ctdb daemon has
  * finished recovery.
  *
  * @param[in] mem_ctx Talloc memory context

ctdb/common/run_event.h

@@ -30,7 +30,7 @@
  *
  * @brief Run scripts in a directory with specific event arguments.
  *
- * This abstraction allows to execute multiple scripts in a directory
+ * This abstraction allows one to execute multiple scripts in a directory
  * (specified by script_dir) with given event and arguments.
  *
  * At one time, only one event can be run.  Multiple run_event calls

ctdb/common/run_proc.h

@@ -28,7 +28,7 @@
  *
  * @brief Run a process and capture the output
  *
- * This abstraction allows to execute scripts with argumunts.
+ * This abstraction allows one to execute scripts with argumunts.
  */
 
 /**

ctdb/common/sock_client.h

@@ -28,7 +28,7 @@
  *
  * @brief A framework for a client based on unix-domain sockets.
  *
- * This abstraction allows to build clients that communicate using
+ * This abstraction allows one to build clients that communicate using
  * unix-domain sockets.  It takes care of the common boilerplate.
  */
 

ctdb/common/sock_daemon.c

@@ -689,7 +689,7 @@ static void sock_daemon_run_startup_done(struct tevent_req *subreq)
 		return;
 	}
 
-	D_NOTICE("startup completed succesfully\n");
+	D_NOTICE("startup completed successfully\n");
 
 	status = sock_daemon_run_socket_listen(req);
 	if (! status) {

ctdb/common/sock_daemon.h

@@ -30,7 +30,7 @@
  *
  * @brief A framework for a server based on unix-domain sockets.
  *
- * This abstraction allows to build simple servers that communicate using
+ * This abstraction allows one to build simple servers that communicate using
  * unix-domain sockets.  It takes care of the common boilerplate.
  */
 
@@ -110,7 +110,7 @@ struct sock_daemon_funcs {
  *
  * @param[in] client The new socket client context
  * @param[in] private_data Private data set with the socket
- * @retun true if connection should be accepted, false otherwise
+ * @return true if connection should be accepted, false otherwise
  *
  *
  * disconnect() is called  when client closes connection

ctdb/doc/ctdb-tunables.7.xml

@@ -608,7 +608,7 @@
       <para>
 	Some databases have seqnum tracking enabled, so that samba will
 	be able to detect asynchronously when there has been updates
-	to the database.  Everytime a database is updated its sequence
+	to the database.  Every time a database is updated its sequence
 	number is increased.
       </para>
       <para>

ctdb/server/ctdb_ltdb_server.c

@@ -1521,7 +1521,7 @@ int32_t ctdb_ltdb_update_seqnum(struct ctdb_context *ctdb, uint32_t db_id, uint3
 }
 
 /*
-  timer to check for seqnum changes in a ltdb and propogate them
+  timer to check for seqnum changes in a ltdb and propagate them
  */
 static void ctdb_ltdb_seqnum_check(struct tevent_context *ev,
 				   struct tevent_timer *te,
@@ -1531,7 +1531,7 @@ static void ctdb_ltdb_seqnum_check(struct tevent_context *ev,
 	struct ctdb_context *ctdb = ctdb_db->ctdb;
 	uint32_t new_seqnum = tdb_get_seqnum(ctdb_db->ltdb->tdb);
 	if (new_seqnum != ctdb_db->seqnum) {
-		/* something has changed - propogate it */
+		/* something has changed - propagate it */
 		TDB_DATA data;
 		data.dptr = (uint8_t *)&ctdb_db->db_id;
 		data.dsize = sizeof(uint32_t);

debian/changelog

+samba (2:4.8.1+dfsg-3) UNRELEASED; urgency=medium
+
+  * Fix lintian warnings with patches recently merged upstream:
+    - Add Fix-pidl-manpage-sections.patch
+    - Add Fix-spelling.patch
+    - Add Improve-vfs_linux_xfs_sgid-manpage.patch
+
+ -- Mathieu Parent <sathieu@debian.org>  Wed, 16 May 2018 06:42:59 +0200
+
 samba (2:4.8.1+dfsg-2) unstable; urgency=low
 
   * Upload to unstable

debian/patches/Fix-pidl-manpage-sections.patch

+From d4bbff5ce5705f877be326f32631b466daec5aed Mon Sep 17 00:00:00 2001
+From: Mathieu Parent <math.parent@gmail.com>
+Date: Tue, 1 May 2018 21:59:23 +0200
+Subject: [PATCH] Fix pidl manpage sections
+
+.TH header should match file name (i.e 3pm and not 3 for Parse::Pidl::NDR).
+
+Signed-off-by: Mathieu Parent <math.parent@gmail.com>
+Reviewed-by: Andrew Bartlett <abartlet@samba.org>
+Reviewed-by: Garming Sam <garming@catalyst.net.nz>
+---
+ pidl/wscript | 5 +++--
+ 1 file changed, 3 insertions(+), 2 deletions(-)
+
+diff --git a/pidl/wscript b/pidl/wscript
+index f4ff902812c..45cb17cea10 100644
+--- a/pidl/wscript
++++ b/pidl/wscript
+@@ -1,6 +1,6 @@
+ #!/usr/bin/env python
+ 
+-import os, Logs
++import os, string, Logs
+ from samba_utils import MODE_755
+ 
+ # This function checks if a perl module is installed on the system.
+@@ -67,7 +67,8 @@ def build(bld):
+     bld.SET_BUILD_GROUP('final')
+     if 'POD2MAN' in bld.env and bld.env['POD2MAN'] != '':
+         for src, manpage in pidl_manpages.iteritems():
+-            bld(rule='${POD2MAN} -c "Samba Documentation" ${SRC} ${TGT}',
++            section = string.rsplit(manpage, ".", 1)[1]
++            bld(rule='${POD2MAN} -c "Samba Documentation" -s %s ${SRC} ${TGT}' % section,
+                 shell=True,
+                 source=src,
+                 install_path=os.path.dirname(bld.EXPAND_VARIABLES('${MANDIR}/'+manpage)),
+-- 
+2.17.0
+

debian/patches/Improve-vfs_linux_xfs_sgid-manpage.patch

+From 674fd1c2834567d473a0b8483eb20e66a27882c0 Mon Sep 17 00:00:00 2001
+From: Mathieu Parent <math.parent@gmail.com>
+Date: Tue, 1 May 2018 20:35:52 +0200
+Subject: [PATCH] Improve vfs_linux_xfs_sgid manpage
+
+- Add missing refpurpose and describe the "circumstances"
+- Replace dangling link by archive.org backup
+- Add fixed Linux version and commit link
+
+Signed-off-by: Mathieu Parent <math.parent@gmail.com>
+Reviewed-by: Andrew Bartlett <abartlet@samba.org>
+Reviewed-by: Garming Sam <garming@catalyst.net.nz>
+---
+ docs-xml/manpages/vfs_linux_xfs_sgid.8.xml | 11 +++++++----
+ 1 file changed, 7 insertions(+), 4 deletions(-)
+
+diff --git a/docs-xml/manpages/vfs_linux_xfs_sgid.8.xml b/docs-xml/manpages/vfs_linux_xfs_sgid.8.xml
+index 21f7fab9d0a..2bc67e56a89 100644
+--- a/docs-xml/manpages/vfs_linux_xfs_sgid.8.xml
++++ b/docs-xml/manpages/vfs_linux_xfs_sgid.8.xml
+@@ -13,7 +13,7 @@
+ 
+ <refnamediv>
+ 	<refname>vfs_linux_xfs_sgid</refname>
+-	<refpurpose></refpurpose>
++	<refpurpose>Workaround XFS sgid bit not inherited during mkdir with default acl on Linux older than 3.1</refpurpose>
+ </refnamediv>
+ 
+ <refsynopsisdiv>
+@@ -31,9 +31,12 @@
+ 
+ 	<para>
+ 	<command>vfs_linux_xfs_sgid</command> is a VFS module to work around an
+-	old Linux XFS bug that still exists: Under certain circumstances the
+-	SGID bit is not inherited (<ulink url="http://oss.sgi.com/bugzilla/show_bug.cgi?id=280">
+-	http://oss.sgi.com/bugzilla/show_bug.cgi?id=280</ulink>).
++	old Linux XFS bug fixed in 3.11: the SGID bit is not inherited during mkdir
++	when a default ACL is set
++	(<ulink url="https://web.archive.org/web/20160320180937/http://oss.sgi.com/bugzilla/show_bug.cgi?id=280">
++	https://web.archive.org/web/20160320180937/http://oss.sgi.com/bugzilla/show_bug.cgi?id=280
++	</ulink> fixed by <ulink url="https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=42c49d7f249c2487f36d3314753d5d8ebcee8249">
++	https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=42c49d7f249c2487f36d3314753d5d8ebcee8249</ulink>).
+ 	The <command>vfs_linux_xfs_sgid</command> VFS module will work around this
+ 	bug by manually setting the SGID bit after a <command>mkdir</command>
+ 	if the parent directory had the SGID bit set.
+-- 
+2.17.0
+

debian/patches/series

@@ -6,3 +6,6 @@ usershare.patch
 VERSION.patch
 add-so-version-to-private-libraries
 heimdal-rfc3454.txt
+Fix-pidl-manpage-sections.patch
+Fix-spelling.patch
+Improve-vfs_linux_xfs_sgid-manpage.patch

docs-xml/manpages/ntlm_auth.1.xml

@@ -253,7 +253,7 @@
 
 		  <varlistentry>
 		    <term>Request-User-Session-Key</term>
-		    <listitem><para>Upon successful authenticaiton, return
+		    <listitem><para>Upon successful authentication, return
 		    the user session key associated with the login.</para>
 		    <varlistentry>
 		      <term>Examples:</term>
@@ -264,7 +264,7 @@
 
 		  <varlistentry>
 		    <term>Request-LanMan-Session-Key</term>
-		    <listitem><para>Upon successful authenticaiton, return
+		    <listitem><para>Upon successful authentication, return
 		    the LANMAN session key associated with the login.
 		    </para>
 		    <varlistentry>
@@ -279,7 +279,7 @@
 		</varlistentry>
 		</variablelist>
 		  <warning><para>Implementers should take care to base64 encode
-		  any data (such as usernames/passwords) that may contain malicous user data, such as
+		  any data (such as usernames/passwords) that may contain malicious user data, such as
 		  a newline. They may also need to decode strings from
 		  the helper, which likewise may have been base64 encoded.</para></warning>
 		</listitem>

docs-xml/manpages/samba.7.xml

@@ -26,7 +26,7 @@
 	<para>The Samba software suite is a collection of programs
 	that implements the Server Message Block (commonly abbreviated
 	as SMB) protocol for UNIX systems and provides Active Directory
-	services. The first version of the SMB protcol is sometimes also
+	services. The first version of the SMB protocol is sometimes also
 	referred to as the Common Internet File System (CIFS). For a more
 	thorough description, see <ulink url="http://www.ubiqx.org/cifs/">
 	http://www.ubiqx.org/cifs/</ulink>. Samba also implements the NetBIOS

docs-xml/manpages/vfs_fruit.8.xml

@@ -106,7 +106,7 @@
 	      </itemizedlist>
 
 	      <para>There's a set of per share options that come into play when
-	      <emphasis>fruit:aapl</emphasis> is enabled. These opions, listed
+	      <emphasis>fruit:aapl</emphasis> is enabled. These options, listed
 	      below, can be used to disable the computation of specific Mac
 	      metadata in the directory enumeration context, all are enabled by
 	      default:</para>

docs-xml/manpages/vfs_linux_xfs_sgid.8.xml

@@ -13,7 +13,7 @@
 
 <refnamediv>
 	<refname>vfs_linux_xfs_sgid</refname>
-	<refpurpose></refpurpose>
+	<refpurpose>Workaround XFS sgid bit not inherited during mkdir with default acl on Linux older than 3.1</refpurpose>
 </refnamediv>
 
 <refsynopsisdiv>
@@ -31,9 +31,12 @@
 
 	<para>
 	<command>vfs_linux_xfs_sgid</command> is a VFS module to work around an
-	old Linux XFS bug that still exists: Under certain circumstances the
-	SGID bit is not inherited (<ulink url="http://oss.sgi.com/bugzilla/show_bug.cgi?id=280">
-	http://oss.sgi.com/bugzilla/show_bug.cgi?id=280</ulink>).
+	old Linux XFS bug fixed in 3.11: the SGID bit is not inherited during mkdir
+	when a default ACL is set
+	(<ulink url="https://web.archive.org/web/20160320180937/http://oss.sgi.com/bugzilla/show_bug.cgi?id=280">
+	https://web.archive.org/web/20160320180937/http://oss.sgi.com/bugzilla/show_bug.cgi?id=280
+	</ulink> fixed by <ulink url="https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=42c49d7f249c2487f36d3314753d5d8ebcee8249">
+	https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=42c49d7f249c2487f36d3314753d5d8ebcee8249</ulink>).
 	The <command>vfs_linux_xfs_sgid</command> VFS module will work around this
 	bug by manually setting the SGID bit after a <command>mkdir</command>
 	if the parent directory had the SGID bit set.

docs-xml/smbdotconf/winbind/winbindignoredomains.xml

@@ -3,7 +3,7 @@
                  type="cmdlist"
                  xmlns:samba="http://www.samba.org/samba/DTD/samba-doc">
 <description>
-       <para>Allows to enter a list of trusted domains winbind should
+       <para>Allows one to enter a list of trusted domains winbind should
        ignore (untrust). This can avoid the overhead of resources from
        attempting to login to DCs that should not be communicated with.
        </para>

lib/krb5_wrap/krb5_samba.c

@@ -1196,7 +1196,7 @@ krb5_error_code smb_krb5_enctype_to_string(krb5_context context,
 /**
  * @brief Open a key table readonly or with readwrite access.
  *
- * Allows to use a different keytab than the default one using a relative
+ * Allows one to use a different keytab than the default one using a relative
  * path to the keytab.
  *
  * @param[in]  context  The library context
@@ -1334,7 +1334,7 @@ out:
 /**
  * @brief Open a key table readonly or with readwrite access.
  *
- * Allows to use a different keytab than the default one. The path needs to be
+ * Allows one to use a different keytab than the default one. The path needs to be
  * an absolute path or an error will be returned.
  *
  * @param[in]  context  The library context

lib/util/util_net.c

@@ -869,7 +869,7 @@ char *print_canonical_sockaddr(TALLOC_CTX *ctx,
 	char *dest = NULL;
 	int ret;
 
-	/* Linux getnameinfo() man pages says port is unitialized if
+	/* Linux getnameinfo() man pages says port is uninitialized if
 	   service name is NULL. */
 
 	ret = sys_getnameinfo((const struct sockaddr *)pss,