• Tim Beale's avatar
    CVE-2019-3870 tests: Extend smbd tests to check for umask being overwritten · 40af26fa
    Tim Beale authored
    The smbd changes the umask - if the code fails to restore the umask to
    what it was, then this is very bad. Add an extra check to every
    smbd-related test that the umask at the end of the test is the same as
    what it was at the beginning (i.e. if the smbd code changed the umask
    then it correctly restored the value afterwards).
    
    As the selftest sets the umask for all tests to zero, it makes it hard
    to detect this problem, so the test setUp() needs to set it to something
    else first.
    
    This extra checking is added to the setUp()/tearDown() so that it
    applies to all test-cases. However, any failure that occur with this
    approach will not be able to be known-failed.
    
    BUG: https://bugzilla.samba.org/show_bug.cgi?id=13834Signed-off-by: 's avatarTim Beale <timbeale@catalyst.net.nz>
    Reviewed-by: 's avatarAndrew Bartlett <abartlet@samba.org>
    
    (This backport to Samba 4.9 by Andrew Bartlett was not a pure
    cherry-pick due to merge conflicts)
    40af26fa
Name
Last commit
Last update
auth Loading commit data...
buildtools Loading commit data...
coverity Loading commit data...
ctdb Loading commit data...
debian Loading commit data...
dfs_server Loading commit data...
docs/manpages Loading commit data...
docs-xml Loading commit data...
dynconfig Loading commit data...
examples Loading commit data...
file_server Loading commit data...
include Loading commit data...
lib Loading commit data...
libcli Loading commit data...
libds/common Loading commit data...
libgpo Loading commit data...
librpc Loading commit data...
nsswitch Loading commit data...
packaging Loading commit data...
pidl Loading commit data...
python Loading commit data...
release-scripts Loading commit data...
script Loading commit data...
selftest Loading commit data...
source3 Loading commit data...
source4 Loading commit data...
testdata Loading commit data...
testprogs Loading commit data...
tests Loading commit data...
testsuite Loading commit data...
third_party Loading commit data...
wintest Loading commit data...
.gitlab-ci-private.yml Loading commit data...
.gitlab-ci.yml Loading commit data...
.testr.conf Loading commit data...
.travis.yml Loading commit data...
.ycm_extra_conf.py Loading commit data...
BUILD_SYSTEMS.txt Loading commit data...
COPYING Loading commit data...
Makefile Loading commit data...
PFIF.txt Loading commit data...
README Loading commit data...
README.Coding Loading commit data...
README.cifs-utils Loading commit data...
README.contributing Loading commit data...
VERSION Loading commit data...
WHATSNEW.txt Loading commit data...
callcatcher-exceptions.grep Loading commit data...
configure Loading commit data...
configure.developer Loading commit data...
install_with_python.sh Loading commit data...
simple-dc-steps.sh Loading commit data...
wscript Loading commit data...
wscript_build Loading commit data...
wscript_build_embedded_heimdal Loading commit data...
wscript_build_system_heimdal Loading commit data...
wscript_build_system_mitkrb5 Loading commit data...
wscript_configure_system_mitkrb5 Loading commit data...