Commit 84ed180b authored by Jerome Benoit's avatar Jerome Benoit

hidden serious bug - eg/t_test_by_rows - fix

parent 15a85ee2
apophenia (0.999e+ds-4) UNRELEASED; urgency=medium
* bug fix release:
- eg/t_test_by_rows TYPO and hidden numerical FAILURE, isolate and fix.
-- Jerome Benoit <calculus@rezozer.net> Fri, 16 Oct 2015 00:08:20 +0000
apophenia (0.999e+ds-3) unstable; urgency=medium
* RC bug fix release (Closes: #793998):
......
upstream-typo-eg_t_test_by_rows.patch
upstream-bug-793998-eg_test_updating.patch
upstream-bug-793998-tests_distribution_tests.patch
debianization.patch
......
Description: upstream -- typo -- eg/t_test_by_rows
Fix a faulty left parenthesis that had hidden a serious numerical bug.
The so raised bug has been submitted alongside to the upstream maintainer:
the numerical fix was provided by him.
Origin: debian/upstream
Author:
Jerome Benoit <calculus@rezozer.net>
Ben Klemens <fluffmail@f-m.fm>
Last-Update: 2015-10-16
Comment:
The typo and the raised numerical issue were isolated by Jerome Benoit on
behalf of the Debian Science Team; the numerical fix was provided by Ben
Klemens as upstream maintainer.
--- a/eg/t_test_by_rows.c
+++ b/eg/t_test_by_rows.c
@@ -32,7 +32,7 @@
assert(apop_data_get(means, i, -1) * apop_data_get(tstats, i, -1) >=0);
//inverse of P-value should be the t statistic.
- assert(fabs(gsl_cdf_tdist_Pinv(apop_data_get(confidences, i, -1),100)
- - apop_data_get(tstats, i, -1) < 1e-3));
+ assert(fabs(gsl_cdf_tdist_Pinv(apop_data_get(confidences, i, -1), 99)
+ - apop_data_get(tstats, i, -1)) < 1e-5);
}
}
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment