Commit f9a40402 authored by Peter Palfrader's avatar Peter Palfrader

Also add a unique constraint on binpkg(name,version,srcpkg_id).

We had a hand full of instances of double entries, breaking our assumptions in
index_binary_package of the snapshot indexer (also see #905687)

These double entries probably came from a race where two indexers were
running at the same time.  While that should now be prevented from happending
by locks on the indexer, a constraint is still the right thing to have.
parent 45fdab79
#!/usr/bin/python
#
# Copyright (c) 2010 Peter Palfrader
#
# Permission is hereby granted, free of charge, to any person obtaining a copy
# of this software and associated documentation files (the "Software"), to deal
# in the Software without restriction, including without limitation the rights
# to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
# copies of the Software, and to permit persons to whom the Software is
# furnished to do so, subject to the following conditions:
#
# The above copyright notice and this permission notice shall be included in
# all copies or substantial portions of the Software.
#
# THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
# IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
# FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
# AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
# LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
# OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
# SOFTWARE.
def upgrade(db):
"""A unique constraint for srcpkg"""
db.execute("""
ALTER TABLE binpkg ADD CONSTRAINT binpkg_unique_name_version_srcpkg_id UNIQUE (name, version, srcpkg_id)
""")
db.execute("UPDATE config SET value='20' WHERE name='db_revision' AND value='19'")
# vim:set et:
# vim:set ts=4:
# vim:set shiftwidth=4:
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment