Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • S squid
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Merge requests 3
    • Merge requests 3
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • Debian Squid Maintainers
  • squid
  • Merge requests
  • !4

Squid4 dep8 fixes

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Andreas Hasenack requested to merge ahasenack/squid:squid4-dep8-fixes into master Aug 10, 2018
  • Overview 0
  • Commits 7
  • Pipelines 0
  • Changes 4

Hi, here are some DEP8 fixes that should make the tests pass. Currently they are failing in Debian CI at https://ci.debian.net/packages/s/squid/testing/amd64/.

Here is the log of a good run with these fixes applied, using the current master branch plus the fixes from this MR: http://people.ubuntu.com/~ahasenack/dep8-debian-squid-4.2-1-unreleased/

Please let me know what your preferences are regarding commit messages, d/changelog updates, etc.

The lack of ssl-cert is what is causing the current failure in ci.debian.net. In Ubuntu, ssl-cert is a dependency of the squid package. For Debian I chose to add it as a test dependency only, because I figured this would be a less controversial change. I might revisit suggesting that delta to Debian at some other time.

The apparmor test could use some work I suppose, because for some reason apparmor_parser doesn't fail when given a file that does not exist:

# apparmor_parser --verbose /does/not/exist; echo $?
File /does/not/exist not found, skipping...
0

I fixed the profile name, but it still doesn't give me confidence in that test, since it was passing before when given a profile that didn't exist. Something to revisit.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: squid4-dep8-fixes