Skip to content
Commit 451ddeb4 authored by Erik Faye-Lund's avatar Erik Faye-Lund Committed by Dylan Baker
Browse files

gallium/auxiliary/indices: consistently apply start only to input



The majority of these only apply the start argument to the input, but a
few of them also does for the output-array. util_primconvert, the only
user of this argument expects this pass a non-zero start-argument does
not expect this to be applied to the output; if it is, it will write
outside of allocated memory, leading to VRAM corruption.

The reason this doesn't seem to have been noticed before, is that no
driver currently use util_primconvert to convert a primitive-type to
itself, which is the cases where this was broken. But for Zink, this
will no longer be true, because we need to eliminate the use of 8-bit
index-buffers.

Signed-off-by: default avatarErik Faye-Lund <erik.faye-lund@collabora.com>
Fixes: 28f3f8d4 ("gallium/auxiliary/indices: add start param")
Reviewed-by: default avatarRob Clark <robdclark@chromium.org>
(cherry picked from commit 52af1427)
parent 6ac1d9b4
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment