Skip to content
Commit 7333112e authored by Neil Roberts's avatar Neil Roberts Committed by Dylan Baker
Browse files

i965: Fix output register sizes when variable ranges are interleaved



In 6f5abf31 this code was fixed to calculate the maximum size of
an attribute in a seperate pass and then allocate the registers to
that size. However this wasn’t taking into account ranges that overlap
but don’t have the same starting location. For example:

layout(location = 0, component = 0) out float a[4];
layout(location = 2, component = 1) out float b[4];

Previously, if ‘a’ was processed first then it would allocate a
register of size 4 for location 0 and it wouldn’t allocate another
register for location 2 because it would already be covered by the
range of 0. Then if something tries to write to b[2] it would try to
write past the end of the register allocated for ‘a’ and it would hit
an assert.

This patch changes it to scan for any overlapping ranges that start
within each range to calculate the maximum extent and allocate that
instead.

Fixed Piglit’s arb_enhanced_layouts/execution/component-layout/
vs-fs-array-interleave-range.shader_test

Reviewed-by: default avatarCaio Marcelo de Oliveira Filho <caio.oliveira@intel.com>
Fixes: 6f5abf31 "i965: Fix output register sizes when multiple variables
       share a slot."
(cherry picked from commit 2d5ddbe9)
parent 83716106
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment