Skip to content
Commit 8d5f09e8 authored by Francisco Jerez's avatar Francisco Jerez Committed by Juan A. Suarez Romero
Browse files

Revert "mesa: simplify _mesa_is_image_unit_valid for buffers"



This reverts commit c0ed52f6.  It was
preventing the image format validation from being done on buffer
textures, which is required to ensure that the application doesn't
attempt to bind a buffer texture with an internal format incompatible
with the image unit format (e.g. of different texel size), which is
not allowed by the spec (it's not allowed for *any* texture target,
whether or not there is spec wording restricting this behavior
specifically for buffer textures) and will cause the driver to
calculate texel bounds incorrectly and potentially crash instead of
the expected behavior.

Cc: mesa-stable@lists.freedesktop.org
Reviewed-by: default avatarMarek Olšák <marek.olsak@amd.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106465


Reviewed-by: default avatarNanley Chery <nanley.g.chery@intel.com>
(cherry picked from commit 5a681478)
parent a93a86a4
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment