Commits on Source (43)
-
Juan A. Suarez Romero authored
Signed-off-by:Juan A. Suarez Romero <jasuarez@igalia.com>
-
Faith Ekstrand authored
If the block in which the jump is inserted is the predecessor of a phi then we need to remove phi sources otherwise the phi may end up with things improperly connected. This fixes the following CTS test when dEQP is run with SPIR-V optimization recipe 1: dEQP-VK.glsl.functions.control_flow.return_in_nested_loop_vertex Cc: mesa-stable@lists.freedesktop.org Reviewed-by:
Iago Toral Quiroga <itoral@igalia.com> (cherry picked from commit bfc89c66)
-
Józef Kucia authored
Fixes GPU hangs. Cc: 18.1 18.2 <mesa-stable@lists.freedesktop.org> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107857 Signed-off-by:
Józef Kucia <joseph.kucia@gmail.com> Signed-off-by:
Marek Olšák <marek.olsak@amd.com> (cherry picked from commit e24a4e05)
-
Emil Velikov authored
As the newly introduced comment says: The pipe loader takes ownership of the fd Thus, there's no need to close it again. Cc: Patrick Rudolph <siro@das-labor.org> Cc: Axel Davy <davyaxel0@gmail.com> Cc: mesa-stable@lists.freedesktop.org> Signed-off-by:
Emil Velikov <emil.velikov@collabora.com> Reviewed-by:
Axel Davy <davyaxel0@gmail.com> (cherry picked from commit 7b8d1b31)
-
Emil Velikov authored
As the spec says, the function is a no-op when the surface is not a window one. That spec implies that EGL_TRUE should be returned in that case, yet the ARM driver seems to return EGL_FALSE + EGL_BAD_SURFACE. The Nvidia driver returns EGL_TRUE. We follow that behaviour until a decision is made. https://gitlab.khronos.org/egl/API/merge_requests/17 Cc: samiuddi <sami.uddin.mohammad@intel.com> Cc: Erik Faye-Lund <kusmabite@gmail.com> Cc: Tomasz Figa <tfiga@chromium.org> Cc: <mesa-stable@lists.freedesktop.org> Signed-off-by:
Eric Engestrom <eric.engestrom@intel.com> (cherry picked from commit 64b4ccde)
-
Emil Velikov authored
Analogous to the previous commit - the spec says the function is a no-op when a pbuffer or pixmap surface is used. Cc: samiuddi <sami.uddin.mohammad@intel.com> Cc: Erik Faye-Lund <kusmabite@gmail.com> Cc: Tomasz Figa <tfiga@chromium.org> Cc: <mesa-stable@lists.freedesktop.org> Signed-off-by:
-
Faith Ekstrand authored
On Broadwell and above, we have to use different MOCS settings to allow the kernel to take over and disable caching when needed for external buffers. On Broadwell, this is especially important because the kernel can't disable eLLC so we have to do it in userspace. We very badly don't want to do that on everything so we need separate MOCS for external and internal BOs. In order to do this, we add an anv-specific BO flag for "external" and use that to distinguish between buffers which may be shared with other processes and/or display and those which are entirely internal. That, together with an anv_mocs_for_bo helper lets us choose the right MOCS settings for each BO use. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=99507 Cc: mesa-stable@lists.freedesktop.org Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> (cherry picked from commit 7a89a0d9) [Juan A. Suarez: resolve trivial conflicts] Signed-off-by:
-
Marek Olšák authored
Cc: 18.2 <mesa-stable@lists.freedesktop.org> (cherry picked from commit 8e0b4cb8)
-
Tapani Pälli authored
v2: check types of both operands (Ian) Cc: mesa-stable@lists.freedesktop.org Signed-off-by:
Tapani Pälli <tapani.palli@intel.com> Reviewed-by:
Ian Romanick <ian.d.romanick@intel.com> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108012 (cherry picked from commit d1fa69ed)
-
Ilia Mirkin authored
This happens in situations where we might do vec.wzyx[i] = ... The swizzle would get effectively ignored because of the interaction between how ir_assignment->set_lhs works and overwriting the write_mask. There are two cases, one where i is a constant, and another where i is variable. We have to be extra-careful in both cases. Fixes the following WebGL test: https://www.khronos.org/registry/webgl/sdk/tests/conformance2/glsl3/vector-dynamic-indexing-swizzled-lvalue.html And the new piglit tests: swizzled-writemask-indexing-nonconst.shader_test swizzled-writemask-indexing.shader_test Signed-off-by:
Ilia Mirkin <imirkin@alum.mit.edu> Reviewed-by:
-
Ilia Mirkin authored
This helps st/mesa avoid some (apparently) buggy fallbacks. Specifically the CopyTexSubImage fallback tries to read texture A as RGBA_FLOAT and write back that data into the target format, which fails for integer formats which have no appropriate logic to do the conversion. Since integer formats don't blend, there's no harm in the fact that the "A" component gets written anyways. Fixes, among others: https://www.khronos.org/registry/webgl/sdk/tests/conformance2/textures/canvas/tex-2d-rgb8ui-rgb_integer-unsigned_byte.html Signed-off-by:
-
Ilia Mirkin authored
The current state tracker can generate these sometimes. Fixing this is more involved, and due to some integer math we can generate divisions-by-zero. Signed-off-by:
Karol Herbst <kherbst@redhat.com> Cc: mesa-stable@lists.freedesktop.org (cherry picked from commit 9bf06141)
-
Ilia Mirkin authored
For some reason the 2d engine can't handle this. Red formats get special treatment there, so perhaps related. Fixes dEQP-GLES3 tests of the form: dEQP-GLES3.functional.fbo.blit.conversion.r{8,16f,32f}_to_srgb8_alpha8 Signed-off-by: -
Faith Ekstrand authored
This fixes a bunch of Vulkan subgroup tests on little core platforms. Fixes: 4150920b "intel/fs: Add a helper for emitting scan operations" Reviewed-by:
Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com> Tested-by:
Mark Janes <mark.a.janes@intel.com> Reviewed-by:
-
Faith Ekstrand authored
We already call nir_rematerialize_derefs_in_use_blocks_impl prior to calling nir_lower_ssa_defs_to_regs_block so the assertion that all deref uses in the block should hold. This fixes the following CTS test when SPIR-V optimization recipe 1: dEQP-VK.glsl.struct.local.loop_nested_struct_array_vertex Fixes: 606eb56a "intel/nir: Only lower load/store derefs" Reviewed-by:
-
Fritz Koenig authored
In the GL_MESA_framebuffer_flip_y implementation _mesa_is_winsys_fbo checks were replaced with FlipY checks. rb->Name is also used to determine if a buffer is winsys. v2: Fixes annotation [for emil] Fixes: ab05dd18 ("i965: implement GL_MESA_framebuffer_flip_y [v3]") Reviewed-by:
Jason Ekstrand <jason@jlekstrand.net> Reviewed-by:
Chad Versace <chadversary@chromium.org> (cherry picked from commit 08f97407)
-
Emil Velikov authored
Earlier commit added support for 'front_buffers', erroneously adding a return in vl_dri3_screen_destroy. Effectively leaking a lot of state. Fixes: 8d7ac0a4 ("vl/dri3: implement DRI3 BufferFromPixmap") Cc: Leo Liu <leo.liu@amd.com> Cc: Christian König <christian.koenig@amd.com> Signed-off-by:
Leo Liu <leo.liu@amd.com> (cherry picked from commit d081ad2a)
-
Emil Velikov authored
This reverts commit 3d81e11b. As reported by Federico, some games require the 'sort by year' since they truncate the extensions which do not fit the fixed size string array. Seemingly I did not consider that, as the documentation (both Mesa and Nvidia) mentions about program crashes ... which are worked around by setting the env. variable. This commit reinstates the workaround and enhances the documentation. Cc: Marek Olšák <maraeo@gmail.com> Cc: Ian Romanick <idr@freedesktop.org> Reported-by:
Federico Dossena <info@fdossena.com> Fixes: 3d81e11b ("mesa: remove unnecessary 'sort by year' for the GL extensions") Reviewed-by:
Timothy Arceri <tarceri@itsqueeze.com> Reviewed-by:
Roland Scheidegger <sroland@vmware.com> Tested-by:
-
Faith Ekstrand authored
Previously, we just went ahead and emitted MI_BATCH_BUFFER_START as normal. If we are near enough to the end, this can cause us to start a new BO just for the MI_BATCH_BUFFER_START which messes up chaining. We always reserve enough space at the end for an MI_BATCH_BUFFER_START so we can just increment cmd_buffer->batch.end prior to emitting the command. Fixes: a0b13328 "anv/batch_chain: Simplify secondary batch return..." Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107926 Tested-by:
Alex Smith <asmith@feralinteractive.com> Reviewed-by:
-
Faith Ekstrand authored
The ssa_for_alu_src helper will correctly handle swizzles and other source modifiers for you. The expansions for unpack_half_2x16, pack_uvec2_to_uint, and pack_uvec4_to_uint were all broken with regards to swizzles. The brokenness of unpack_half_2x16 was causing rendering errors in Rise of the Tomb Raider on Intel ever since c11833ab which added an extra copy propagation to the optimization pipeline and caused us to start seeing swizzles where we hadn't seen any before. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107926 Fixes: 9ce90105 "nir: Add lowering of nir_op_unpack_half_2x16." Fixes: 9b8786eb "nir: Add lowering support for packing opcodes." Tested-by:
Matt Turner <mattst88@gmail.com> (cherry picked from commit dd553bc6)
-
Gert Wollny authored
The transfer size used in virglrenderer refers to uint32_t, so one must add 3 and then divide by 4 instead of adding 3/4 which is a no-op with integers. Fixes: b3b82fe8 virgl/vtest: add vtest driver Signed-off-by:
Gert Wollny <gert.wollny@collabora.com> Reviewed-by:
Gurchetan Singh <gurchetansingh@chromium.org> (cherry picked from commit 5d7858f1)
-
Eric Engestrom authored
Fixes: 6f3aee40 "radv: using tls to store llvm related info and speed up compiles (v10)" Cc: Dave Airlie <airlied@redhat.com> Signed-off-by:
Dylan Baker <dylan@pnwbakers.com> (cherry picked from commit 97618873)
-
Dylan Baker authored
Currently mesa only supports EGL on Unix like systems, cygwin, and haiku. Meson should actually enforce this. This fixes the default build on MacOS. v2: - invert the condition, mark darwin and windows as not supported instead of trying to mark what is supported. v3: - add missing ) v3: - Update comment to reflect condition change in v2 CC: 18.2 <mesa-stable@lists.freedesktop.org> Reviewed-by: -
Faith Ekstrand authored
This fixes a bug uncovered by my NIR integer division by constant optimization series. Fixes: 19f9cb72 "i965/fs: Add pass to propagate conditional..." Fixes: 627f94b7 "i965/vec4: adding vec4_cmod_propagation..." Reviewed-by:
-
Dave Airlie authored
Not going to matter, but be consistent. Found by coverity Reviewed-by:
-
Timothy Arceri authored
The Nvidia/AMD binary drivers allow this, as does GCC. This fixes shader compilation issues in the latest update of No Mans Sky. Reviewed-by:
-
Timothy Arceri authored
Timestamp can be zero for example when Flatpak is used. In this case just disable the cache rather then segfaulting when incompatible cache items are loaded. V2: actually return false when mtime is 0. Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> (cherry picked from commit ea66bfda)
-
Timothy Arceri authored
Only some drivers use a timestamp here. Others use things such as build-id, or even a combination of build-ids from Mesa and LLVM. Reviewed-by:
-
Timothy Arceri authored
This can be used as a drop in replacement for disk_cache_get_function_timestamp(). Here we use build-id to generate a driver-id rather than build timestamp if available. This should resolve issues such as distros using reproducable builds and flatpak not having real build timestamps. Reviewed-by:
-
Timothy Arceri authored
Reviewed-by:
-
Timothy Arceri authored
Reviewed-by:
-
Timothy Arceri authored
Reviewed-by:
-
Timothy Arceri authored
-
Timothy Arceri authored
This game is looking for some odd extension after creating a core context such as ARB_vertex_program and EXT_framebuffer_object. Rather then enabling these in core this forces the game to use compat. This allows the game to run and seems to work without issues. All other id tech games/engines use a compat profile. Reviewed-by:
-
Samuel Pitoiset authored
Otherwise, Yakuza and The Evil Within hang the GPU with DXVK. This apparently only works on Polaris. Suggested by Marek. Cc: mesa-stable@lists.freedesktop.org Signed-off-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by:
-
Boyuan Zhang authored
vlVaGetImage should respect the width, height, and coordinates x and y that passed in. Therefore, pipe_box should be created with the passed in values instead of surface width/height. v2: add input size check, return error when size out of bounds v3: fix the size check for vaimage v4: add size adjustment for x and y coordinates Signed-off-by:
Boyuan Zhang <boyuan.zhang@amd.com> Cc: "18.2" <mesa-stable@lists.freedesktop.org> Reviewed-by:
Christian König <christian.koenig@amd.com> (cherry picked from commit d76c2774)
-
Vinson Lee authored
sb/sb_bc_parser.cpp:620:27: warning: use of logical '&&' with constant operand [-Wconstant-logical-operand] if (cf->bc.op_ptr->flags && FF_GDS) ^ ~~~~~~ sb/sb_bc_parser.cpp:620:27: note: use '&' for a bitwise operation if (cf->bc.op_ptr->flags && FF_GDS) ^~ & sb/sb_bc_parser.cpp:620:27: note: remove constant to silence this warning if (cf->bc.op_ptr->flags && FF_GDS) ~^~~~~~~~~ Fixes: da977ad9 ("r600/sb: start adding GDS support") Signed-off-by:Vinson Lee <vlee@freedesktop.org> Reviewed-by:
Dave Airlie <airlied@redhat.com> (cherry picked from commit cc33621e)
-
Timothy Arceri authored
For some reason wine will sometimes give us a windows style path for an application. For example when running the 64bit version of Rage wine gives a Unix style path, but when running the 32bit version is gives a windows style path. If we detect no '/' in the path at all it should be safe to assume we have a wine application and instead look for a '\'. Reviewed-by:
-
Timothy Arceri authored
This allows the game to run on wine (tested on radeonsi where we have compat profile support). (cherry picked from commit 0da93de9)
-
Juan A. Suarez Romero authored
Signed-off-by: -
Juan A. Suarez Romero authored
Signed-off-by: -
Andreas Boll authored
mesa-18.2.3
-
Andreas Boll authored
docs/relnotes/18.2.3.html
0 → 100644