Commits on Source (50)
-
Dylan Baker authored
-
Marek Olšák authored
GL_STENCIL_INDEX uses GL_INTENSITY for the border color, which is nicer to hardware that doesn't read the stencil border value from the X channel. This fixes a bunch of dEQP tests on Vega & Raven. Cc: 18.1 18.2 <mesa-stable@lists.freedesktop.org> (cherry picked from commit 725e8ad5)
-
Dylan Baker authored
-
Gert Wollny authored
Fixes crash with piglit/bin/map_buffer_range-invalidate CopyBufferSubData \ increment-offset -auto -fbo * Resize the resource storage already when the count is equal to the allocated size, fixes: Invalid write of size 8 at 0xB72E4CF: virgl_drm_add_res (virgl_drm_winsys.c:629) by 0xB72E4CF: virgl_drm_emit_res (virgl_drm_winsys.c:663) by 0xB72A44A: virgl_encode_resource_copy_region (virgl_encode.c:776) by 0xB40CD12: st_copy_buffer_subdata (st_cb_bufferobjects.c:585) by 0xB244A3B: _mesa_CopyBufferSubData (bufferobj.c:2940) by 0x109A1E: upload (invalidate.c:169) by 0x109C2F: piglit_display (invalidate.c:215) by 0x4F80FBE: run_test (piglit_fbo_framework.c:52) by 0x4F66E5F: piglit_gl_test_run (piglit-framework-gl.c:229) by 0x10949D: main (invalidate.c:47) Address 0xbe07d30 is 0 bytes after a block of size 4,096 alloc'd at 0x4C31B25: calloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) by 0xB72DAAF: virgl_drm_cmd_buf_create (virgl_drm_winsys.c:567) * Also resize the space allocated for the handles, fixes: Invalid write of size 4 at 0xB72E4F0: virgl_drm_add_res (virgl_drm_winsys.c:631) by 0xB72E4F0: virgl_drm_emit_res (virgl_drm_winsys.c:663) by 0xB72A44A: virgl_encode_resource_copy_region (virgl_encode.c:776) by 0xB40CD12: st_copy_buffer_subdata (st_cb_bufferobjects.c:585) by 0xB244A3B: _mesa_CopyBufferSubData (bufferobj.c:2940) by 0x109A1E: upload (invalidate.c:169) by 0x109C2F: piglit_display (invalidate.c:215) by 0x4F80FBE: run_test (piglit_fbo_framework.c:52) by 0x4F66E5F: piglit_gl_test_run (piglit-framework-gl.c:229) by 0x10949D: main (invalidate.c:47) Address 0xbe08570 is 0 bytes after a block of size 2,048 alloc'd at 0x4C2FB0F: malloc ( in /usr/lib/valgrind/vgpreload_memcheck-amd64- linux.so) by 0xB72DAC8: virgl_drm_cmd_buf_create (virgl_drm_winsys.c:572) Fixes: 4b15b5e8 ("virgl: resize resource bo allocation if we need to.") v2: - Use REALLOC macro and avoid memory leak when re-allocation fails - add Fixes tag (both Emil Velikov) - reorder commit message Signed-off-by:Gert Wollny <gert.wollny@collabora.com> (cherry picked from commit 9b0e8d87)
-
Dylan Baker authored
We require a single version of libdrm for all of our libdrm dependencies (core and driver), but the way this is structured can make the error message less than helpful, as one driver might be the one setting the libdrm requirement, while another might be the one that generates the version failure. This adds a simple message to the output announcing which libdrm module set the version, which might be more helpful. v2: - Use message suggested by Eric Engstrom Fixes: c445b1d5 ("meson: Use the same version for all libdrm checks") Reviewed-by:
Eric Engestrom <eric.engestrom@intel.com> (cherry picked from commit d25a27ec)
-
Mathias Fröhlich authored
Fix an other regression of mesa: Make gl_vertex_array contain pointers to first order VAO members. The regression showed up with drivers using the tnl module and was reproducible using xonotic-glx -benchmark demos/the-big-keybench.dem. Fixes: 64d2a204 mesa: Make gl_vertex_array contain pointers to first order VAO members. Tested-by:
Ville Syrjälä <ville.syrjala@linux.intel.com> Reviewed-by:
Ian Romanick <ian.d.romanick@intel.com> Signed-off-by:
Mathias Fröhlich <Mathias.Froehlich@web.de> (cherry picked from commit a6232b69) Conflicts resolved by Dylan Conflicts: src/mesa/tnl/t_split_copy.c
-
Timothy Arceri authored
If we have something like: #ifdef NOT_DEFINED #define A_MACRO(x) \ if (x) #endif The # on the #define is not skipped but the define itself is so this then gets recognised as #if. Until 28a3731e this didn't happen because we ended up in <HASH>{NONSPACE} where BEGIN INITIAL was called stopping the problem from happening. This change makes sure we never call RETURN_TOKEN_NEVER_SKIP for if/else/endif when processing a define. Cc: Ian Romanick <idr@freedesktop.org> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107772
-
Faith Ekstrand authored
The brw_vs_prog_data::double_inputs_read field comes directly from shader_info::double_inputs which may contain inputs which are not actually read. Instead of using it directly, AND it with inputs_read which is only things which are read. Otherwise, we may end up subtracting too many elements when computing elem_count. Cc: mesa-stable@lists.freedesktop.org Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103241 Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> (cherry picked from commit 7b267418)
-
Sergii Romantsov authored
Seems in case of 32-bit library, usage of msse2 makes some stack corruption or incorrect instructions. Usage with mstackrealign fixes that case. v2: Fixed meson. v3: Definition of c_sse2_args moved on the top (L.Landwerlin). Added mstackrealign for Android's mks where msee4.1 is used. v4: Added for Vulkan also. v5: Commit message correction. CC: <mesa-stable@lists.freedesktop.org> Fixes: 6b05c080 (i965: Compile with -msse3) Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107779 Signed-off-by:Sergii Romantsov <sergii.romantsov@globallogic.com> Reviewed-by:
Dylan Baker <dylan@pnwbakers.com> Reviewed-by:
Emil Velikov <emil.velikov@collabora.com> Reviewed-by:
-
Dylan Baker authored
-
Andrii Simiklit authored
Each invocation of va_copy() must be matched by a corresponding invocation of va_end() Reviewed-by:
Andrii Simiklit <andrii.simiklit@globallogic.com> (cherry picked from commit 267ed292)
-
Andrii Simiklit authored
The first usage of the 'va_list' instance could change it. Reviewed-by:
-
Andrii Simiklit authored
We should exit from the function 'util_vasprintf' with error code -1 for case where 'malloc' returns NULL Reviewed-by:
-
Andrii Simiklit authored
MSDN: "va_end must be called on each argument list that's initialized with va_start or va_copy before the function returns." Reviewed-by:
-
Dylan Baker authored
-
Faith Ekstrand authored
gen9 hardware has a bug in the sampler cache that can cause GPU hangs whenever an texture with aux compression enabled is in the sampler cache together with an ASTC5x5 texture. Because we can't control what the client binds at any given time, we have two options: resolve the CCS or decompresss the ASTC. Doing a CCS or HiZ resolve is far less drastic and will likely have a smaller performance impact. Cc: mesa-stable@lists.freedesktop.org Reviewed-by:
Kristian H. Kristensen <hoegsberg@google.com> Tested-by:
Tapani Pälli <tapani.palli@intel.com> Reviewed-by:
Topi Pohjolainen <topi.pohjolainen@intel.com> (cherry picked from commit f9e630e2)
-
Faith Ekstrand authored
Some of the bits of VERTEX_BUFFER_STATE such as access type, instance data step rate, and pitch come from the pipeline. Cc: mesa-stable@lists.freedesktop.org Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> (cherry picked from commit c643c5e1)
-
Faith Ekstrand authored
I have no idea if I'm correct about what's going wrong or if this is the correct fix. However, in my multiple weeks of banging my head on this hang, a VUE reference counting bug seems to match all the symptoms and it definitely fixes the hang. Cc: mesa-stable@lists.freedesktop.org Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107280 Reviewed-by:
-
Faith Ekstrand authored
The Vulkan 1.1.81 spec says: "It is legal for offset.x + extent.width or offset.y + extent.height to exceed the dimensions of the framebuffer - the scissor test still applies as defined above. Rasterization does not produce fragments outside of the framebuffer, so such fragments never have the scissor test performed on them." Elsewhere, the Vulkan 1.1.81 spec says: "The application must ensure (using scissor if necessary) that all rendering is contained within the render area, otherwise the pixels outside of the render area become undefined and shader side effects may occur for fragments outside the render area. The render area must be contained within the framebuffer dimensions." Unfortunately, there's some room for interpretation here as to what the consequences are of having the render area set to exactly the framebuffer dimensions and having a scissor that is larger than the framebuffer. Given that GL and other APIs provide automatic clipping to the framebuffer, it makes sense that applications would assume that Vulkan does this as well. It costs us very little to play it safe and just clamp client-provided scissors to the framebuffer dimensions. Fortunately, the user is required to provide us with at least one scissor so we don't need to handle the case where they don't. Fixes: fb2a5ceb "anv: Emit DRAWING_RECTANGLE once at driver..." Reviewed-by: -
Dave Airlie authored
This fixes the situation where we'd send a shader with just the header and no data. piglit/glsl-max-varyings test was causing this to happen, and the renderer fix was breaking it. v2: drop fprintf Fixes: a8987b88 "virgl: add driver for virtio-gpu 3D (v2)" Reviewed-by:
Erik Faye-Lund <erik.faye-lund@collabora.com> (cherry picked from commit 240af614)
-
Marek Olšák authored
VI uses addrlib so it's unaffected. Cc: 18.1 18.2 <mesa-stable@lists.freedesktop.org> Tested-by:
Dieter Nützel <Dieter@nuetzel-hh.de> (cherry picked from commit a1b9a00f) Conflicts resolved by Dylan Conflicts: src/gallium/drivers/radeonsi/si_texture.c
-
Marek Olšák authored
Cc: 18.1 18.2 <mesa-stable@lists.freedesktop.org> Tested-by:
-
Marek Olšák authored
important for debugging Cc: 18.1 18.2 <mesa-stable@lists.freedesktop.org> Tested-by:
-
Christopher Egert authored
Since commit af3685d1 various OpenGL applications regressed on the classic mesa radeon driver. Signed-off-by:
Christopher Egert <cme3000@gmail.com> CC: 18.1 18.2 <mesa-stable@lists.freedesktop.org> Signed-off-by:
Marek Olšák <marek.olsak@amd.com> (cherry picked from commit 51995f69)
-
Dylan Baker authored
-
Michel Dänzer authored
We don't need to wait before drawing to the fake front buffer, as front buffer rendering by definition is allowed to produce artifacts. Fixes hangs in some cases when re-using the fake front buffer, due to it still being busy (i.e. in use for presentation). Cc: mesa-stable@lists.freedesktop.org Bugzilla: https://bugs.freedesktop.org/106404 Bugzilla: https://bugs.freedesktop.org/107757 Tested-by:
Olivier Fourdan <ofourdan@redhat.com> Reviewed-by:
Thomas Hellstrom <thellstrom@vmware.com> (cherry picked from commit aefac10f)
-
Erik Faye-Lund authored
If we end up never taking the loop that writes ret, we can end up with an uninitialized value, and if we're *really* unlucky, that value can be -1, causing us to go down an error-path instead of a success path. This was obviously not intended, so let's just initialize this to zero. Noticed by Valgrind: Conditional jump or move depends on uninitialised value(s) at 0xBA640A0: virgl_drm_winsys_resource_cache_create (virgl_drm_winsys.c:348) by 0xBA62FCF: virgl_buffer_create (virgl_buffer.c:170) by 0xBA605AC: virgl_resource_create (virgl_resource.c:60) by 0xBCF816F: bufferobj_data (st_cb_bufferobjects.c:344) by 0xBCF816F: st_bufferobj_data (st_cb_bufferobjects.c:390) by 0xBB7E836: vbo_use_buffer_objects (vbo_exec_api.c:1136) by 0xBCFCC6E: st_create_context_priv (st_context.c:414) by 0xBCFD3CD: st_create_context (st_context.c:590) by 0xBBB30CA: st_api_create_context (st_manager.c:896) by 0xB981E76: dri_create_context (dri_context.c:155) by 0xB97BDCE: driCreateContextAttribs (dri_util.c:473) by 0x5288331: dri3_create_context_attribs (dri3_glx.c:309) by 0x5264D64: glXCreateContextAttribsARB (create_context.c:78) Fixes: a8987b88 ("virgl: add driver for virtio-gpu 3D (v2)") Signed-off-by:
-
Dylan Baker authored
-
Erik Faye-Lund authored
When we're mapping temp-resources, we clip the resource to the transfer-box, which means the stride might not be correct any more. So let's update the stride from the temp-resource, and recompute the layer-stride. This fixes crashes when running dEQP with --deqp-gl-config-name=rgba8888d24s8ms4 Signed-off-by:
Dave Airlie <airlied@redhat.com> (cherry picked from commit fa5e9f1f)
-
Pierre Moreau authored
Those operations do not map to actual hardware instructions, therefore those should always be lowered to 32-bit instructions. Fixes: 009c54aa "nv50/ir: Split 64-bit integer MAD/MUL operations" Signed-off-by:
Pierre Moreau <pierre.morrow@free.fr> Reviewed-by:
Karol Herbst <kherbst@redhat.com> Signed-off-by:
-
Josh Pieper authored
When using Freecad, I was getting intermittent segfaults inside of mesa. I traced it down to this path in st_cb_drawpixels.c where the result of pipe_transfer_map wasn't being checked. In my case, it was returning NULL because nouveau_bo_new returned ENOENT. I'm by no means a mesa developer, but this patch solves the problem for me and seems reasonable enough. v2: Marek - also unmap the PBO and release the texture, and call the make_texture function sooner for less cleanup Cc: 18.1 18.2 <mesa-stable@lists.freedesktop.org> (cherry picked from commit 936e0dcd) -
Bas Nieuwenhuizen authored
To get an useful UUID for systems that have a non-useful mtime for the binaries. I started using SHA1 to ensure we get reasonable mixing in the various possibilities and the various build id lengths. CC: <mesa-stable@lists.freedesktop.org> Reviewed-by:
Timothy Arceri <tarceri@itsqueeze.com> (cherry picked from commit d17443a4)
-
Kenneth Feng authored
No changes here compared to Raven. Reviewed-by:
Huang Rui <ray.huang@amd.com> Signed-off-by:
Kenneth Feng <kenneth.feng@amd.com> Signed-off-by:
-
Faith Ekstrand authored
Each query slot is a uint64_t and we were only zeroing half of it. Fixes: 7ec6e4e6 "anv/query: implement multiview interactions" Reviewed-by:
-
Dylan Baker authored
-
Bas Nieuwenhuizen authored
Apparently for compute there are only 16 instead of the 32 for the graphics path. Fixes dEQP-VK.binding_model.descriptorset_random.sets16.noarray.ubolimitlow.sbolimitlow.imglimitlow.noiub.comp.0 CC: <mesa-stable@lists.freedesktop.org> Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> (cherry picked from commit 0dd8189f) Conflicts Resolved by Dylan Conflicts: src/amd/vulkan/radv_nir_to_llvm.c
-
Bas Nieuwenhuizen authored
Otherwise using 32 user SGPRs would be broken. CC: <mesa-stable@lists.freedesktop.org> Reviewed-by:
-
Michal Srb authored
This is equivalent to commit a65db0ad, but for dri_kms_init_screen. Without this gbm_dri_is_format_supported always returns false. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104926 Fixes: e14fe41e ("st/dri: implement createImageFromRenderbuffer(2)") Reviewed-by:
Adam Jackson <ajax@redhat.com> Tested-by:
Adam Williamson <adamwill@fedoraproject.org> (cherry picked from commit 194bf0a2)
-
Mauro Rossi authored
Backport to mesa 18.1 Fixes the following building error, happening when building both intel and broadcom: Gen Header: libmesa_broadcom_genxml_32 <= v3d_packet_v21_pack.h FAILED: out/target/product/x86_64/gen/STATIC_LIBRARIES/libmesa_broadcom_genxml_intermediates/broadcom/cle/v3d_packet_v21_pack.h /bin/bash -c "python external/mesa/src/broadcom/cle/gen_pack_header.py \ external/mesa/src/broadcom/cle/v3d_packet_v21.xml \ > out/target/product/x86_64/gen/STATIC_LIBRARIES/libmesa_broadcom_genxml_intermediates/broadcom/cle/v3d_packet_v21_pack.h" Traceback (most recent call last): File "external/mesa/src/broadcom/cle/gen_pack_header.py", line 626, in <module> p = Parser(sys.argv[2]) IndexError: list index out of range header-gen macro is already defined by Intel genxml building rules and the existing header-gen does not have the $(PRIVATE_VER) argument, infact the bash command line logged in the building error is missing exactly $(PRIVATE_VER) argument Renaming the macro as pack-header-gen in src/broadcom/Android.genxml.mk solves the building error, another possible way is to keep the gen rules commands expanded and not use the macros. Fixes: 7f80a9ff ("vc4: Introduce XML-based packet header generation like Intel's.") Acked-by:Eric Anholt <eric@anholt.net> Reviewed-by:
Mauro Rossi <issor.oruam@gmail.com>
-
Mauro Rossi authored
Fixes the following building error: In file included from external/mesa/src/broadcom/cle/v3d_decoder.c:38: In file included from external/mesa/src/broadcom/cle/v3d_packet_helpers.h:29: external/mesa/src/gallium/auxiliary/util/u_math.h:42:10: fatal error: 'pipe/p_compiler.h' file not found ^~~~~~~~~~~~~~~~~~~ 1 error generated. Fixes: 5b102160 ("broadcom/genxml: Introduce a V3D packet/struct decoder.") Cc: "18.2" <mesa-stable@lists.freedesktop.org> Acked-by: -
Mauro Rossi authored
Fixes the following building error in vc4 build: In file included from external/mesa/src/gallium/drivers/vc4/kernel/vc4_render_cl.c:34: In file included from external/mesa/src/gallium/drivers/vc4/kernel/vc4_drv.h:27: In file included from external/mesa/src/gallium/drivers/vc4/vc4_simulator_validate.h:34: In file included from external/mesa/src/gallium/drivers/vc4/vc4_context.h:39: In file included from external/mesa/src/gallium/drivers/vc4/vc4_cl.h:56: out/target/product/x86_64/gen/STATIC_LIBRARIES/libmesa_broadcom_genxml_intermediates/broadcom/cle/v3d_packet_v21_pack.h:12:10: fatal error: 'cle/v3d_packet_helpers.h' file not found ^~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. Fixes: 5b102160 ("broadcom/genxml: Introduce a V3D packet/struct decoder.") Cc: "18.2" <mesa-stable@lists.freedesktop.org> Acked-by: -
Dylan Baker authored
-
Bas Nieuwenhuizen authored
Was missing the init, found by Emil. Fixes: d17443a4 "radv: Use build ID if available for cache UUID." CC: <mesa-stable@lists.freedesktop.org> Reviewed-by:
-
Dylan Baker authored
-
Dylan Baker authored
-
Andreas Boll authored
mesa-18.1.9
-
Andreas Boll authored
-
It is needed to destroy the v vector in scalar_argument Fixes memory leaks on parameter set/bind. v2: Drop redundant sclara_argument destructor Signed-off-by:
Jan Vesely <jan.vesely@rutgers.edu> Reviewed-by:
Francisco Jerez <currojerez@riseup.net> (cherry picked from commit 2f1ad72a)
-
Andreas Boll authored
-
Andreas Boll authored
docs/relnotes/18.1.9.html
0 → 100644