Commits on Source (46)
-
José Fonseca authored
Now we do full S3TC decompression they should no longer fail. Reviewed-by:
Roland Scheidegger <sroland@vmware.com> Fixes: 34cf3c43 ("mesa: Call DXTn functions directly")
-
Dylan Baker authored
-
Lina Versace authored
In a single call to vk_errorf() in the Android code, the arguments were swapped. The bug has existed since day one. Chrome OS used to forgive the warning, but it is now a compilation error. CC: <mesa-stable@lists.freedesktop.org> Fixes: 053d4c32 "anv: Implement VK_ANDROID_native_buffer (v9)" Reviewed-by:
Tapani Pälli <tapani.palli@intel.com> (cherry picked from commit be5fc0d7)
-
Lina Versace authored
Changes to vk.xml and anv_entrypoints_gen.py broke the Autotools build on Android. The changes undef'd the VK_ANDROID_native_buffer entrypoints in anv_entrypoints.h. Fix it with CPPFLAGS += -DVK_USE_PLATFORM_ANDROID_KHR. CC: <mesa-stable@lists.freedesktop.org> See-Also: 63525ba7 "android: enable VK_ANDROID_native_buffer" Reviewed-by:
-
Samuel Pitoiset authored
This might fix some synchronization issues. I don't know if that will affect performance but it's required for correctness. Signed-off-by:Samuel Pitoiset <samuel.pitoiset@gmail.com>
-
Dylan Baker authored
-
Lucas Stach authored
When a EGLImage is newly bound to a texture, we need to make sure the driver is informed that the resource might have changed. Fixes stale texture content on Etnaviv when binding an existing EGLImage to an existing texture object. Signed-off-by:
Lucas Stach <l.stach@pengutronix.de> Reviewed-by:
Marek Olšák <marek.olsak@amd.com> (cherry picked from commit 501d0ede)
-
Michel Dänzer authored
It's optional, only implemented by the etnaviv driver so far. Fixes: 501d0ede "st/mesa: call resource_changed when binding a EGLImage to a texture" Fixes: a37cf630 "gallium: add pipe_screen::resource_changed callback wrappers" Reviewed-by:
-
Emma Anholt authored
I had mistakenly used the COHERENT flag, which can only be set when PERSISTENT is mapped, but isn't always. Fixes: a2014c2e ("vc4: Simplify the DISCARD_RANGE handling") (cherry picked from commit 50a3a283)
-
Mauro Rossi authored
pthread types are used in some files without explicitely including pthread.h. This leads to compile errors on Android 7.x nougat-x86 e.g. in src/amd/vulkan/winsys/amdgpu/radv_amdgpu_winsys.h In file included from external/mesa/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_bo.c:31: In file included from external/mesa/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_bo.h:32: external/mesa/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_winsys.h:52:2: error: unknown type name 'pthread_mutex_t' pthread_mutex_t global_bo_list_lock; ^ 1 error generated. Including pthread.h explicitely solves the building error Signed-off-by:Mauro Rossi <issor.oruam@gmail.com> Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> (cherry picked from commit 1a1f2b13)
-
Bas Nieuwenhuizen authored
Overshot it by one every time. CC: <mesa-stable@lists.freedesktop.org> Reviewed-by:
-
Bas Nieuwenhuizen authored
Used the wrong register ... CC: <mesa-stable@lists.freedesktop.org> Reviewed-by:
-
Bas Nieuwenhuizen authored
CC: <mesa-stable@lists.freedesktop.org> Reviewed-by:
-
Jan Vesely authored
They might lead to unrecoverable GPU hang. Signed-off-by:
Jan Vesely <jan.vesely@rutgers.edu> Reviewed-by:
-
Samuel Iglesias Gonsálvez authored
The assert is checking that we are not binding more descriptor sets than the supported by the driver. When binding the descriptor set number MAX_SETS-1, it was breaking the assert because descriptorSetCount = 1. Signed-off-by:
Samuel Iglesias Gonsálvez <siglesias@igalia.com> Cc: <mesa-stable@lists.freedesktop.org> Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> (cherry picked from commit 0f290062)
-
Jan Vesely authored
CC: <mesa-stable@lists.freedesktop.org> Signed-off-by:
Francisco Jerez <currojerez@riseup.net> (cherry picked from commit 154fbd03)
-
Jan Vesely authored
Abort all dependent events. v2: Abort the current event as well. CC: <mesa-stable@lists.freedesktop.org> Signed-off-by:
-
Lepton Wu authored
The current code is buggy: if there are only 12 dwords left in cbuf, we emit a zero data length command which will be rejected by virglrenderer. Fix it by calling flush in this case. Cc: mesa-stable@lists.freedesktop.org Reviewed-by:
Dave Airlie <airlied@redhat.com> (cherry picked from commit 04e278f7)
-
Karol Herbst authored
Fixes: 2f181c8c "glsl_types: vec8/vec16 support" Reviewed-by:
Jason Ekstrand <jason@jlekstrand.net> Signed-off-by:
Karol Herbst <kherbst@redhat.com> (cherry picked from commit 87c8af28)
-
Emma Anholt authored
These are not unit tests, as they rely on the host's XVMC and some user configuration. Switch them over to being general installed tools, to fix unit testing. Fixes: 22a817af ("meson: build gallium xvmc state tracker") Reviewed-by:
Dylan Baker <dylan@pnwbakers.com> (cherry picked from commit 162fcdad) Minor merge conflict resolved by Dylan Conflicts: meson_options.txt
-
Samuel Pitoiset authored
A ZPASS_DONE or PIXEL_STAT_DUMP_EVENT (of the DB occlusion counters) must immediately precede every timestamp event to prevent a GPU hang on GFX9. Signed-off-by: -
Dylan Baker authored
Which was manually backported by Samuel
-
Bas Nieuwenhuizen authored
Reinserting code directly before a jump means the block gets split and merged, removing the original block and replacing it in the process. Hence keeping a pointer to the continue block over a reinsert causes issues. This code changes nir_opt_if to simply look for the new continue block. Reviewed-by:
-
Bas Nieuwenhuizen authored
radv always needs it, so just check the header instead. Also do not declare the function if the variable is not set, so we get a nice compile error instead of failing to open a device at runtime. Fixes: b87ef9e6 "util: fix MSVC build issue in disk_cache.h" Reviewed-by:
Timothy Arceri <tarceri@itsqueeze.com> (cherry picked from commit cc10b34e)
-
Dylan Baker authored
-
Bas Nieuwenhuizen authored
There always is a continue block, so let us just do unreachable. Reviewed-by:
-
Alex Smith authored
According to the spec, these should apply to all read/write access types (so would be equivalent to specifying all other access types individually). Currently, they were doing nothing. v2: Handle VK_ACCESS_MEMORY_WRITE_BIT in dstAccessMask. Signed-off-by:
Alex Smith <asmith@feralinteractive.com> Cc: mesa-stable@lists.freedesktop.org Reviewed-by:
-
Samuel Pitoiset authored
modules[i] can be NULL for merged shaders but we have to free the NIR code. radv_can_dump_shader_stats() already handles if modules[i] is NULL, no need to check it twice. Cc: mesa-stable@lists.freedesktop.org Signed-off-by:
-
Faith Ekstrand authored
We've had several broadwell hangs that have come down to this bit just not working correctly. Most recently, we've had a pile of hangs reported with apps running under DXVK: https://github.com/doitsujin/dxvk/issues/469 Instead, use the bit that doesn't try to imply weird D3D coherency things and just force-enables the PS like we want. cc: mesa-stable@lists.freedesktop.org Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> (cherry picked from commit abd629eb)
-
Mauro Rossi authored
This patch applies the necessary changes in Android.common.mk as per automake rules, to avoid following building error: external/mesa/src/gallium/drivers/nouveau/nouveau_screen.c:159:8: error: implicit declaration of function 'disk_cache_get_function_timestamp' is invalid in C99 [-Werror,-Wimplicit-function-declaration] if (disk_cache_get_function_timestamp(nouveau_disk_cache_create, ^ 1 error generated. (v2) -DENABLE_SHADER_CACHE Android cflag is kept, to leave the AS-IS capability enabled Fixes: cc10b34e ("util/disk_cache: Fix disk_cache_get_function_timestamp with disabled cache.") Signed-off-by: -
Chih-Wei Huang authored
The commit 76dfed8a changed nir_intrinsics.h to be a generated header, but the corresponding dependency was not updated for Android. It causes the error: [ 0% 19/4336] target C: libmesa_pipe_radeonsi <= external/mesa/src/gallium/drivers/radeonsi/si_debug.c ... In file included from external/mesa/src/gallium/drivers/radeonsi/si_debug.c:25: In file included from external/mesa/src/gallium/drivers/radeonsi/si_pipe.h:28: In file included from external/mesa/src/gallium/drivers/radeonsi/si_shader.h:140: In file included from external/mesa/src/amd/common/ac_llvm_build.h:30: external/mesa/src/compiler/nir/nir.h:966:10: fatal error: 'nir_intrinsics.h' file not found ^~~~~~~~~~~~~~~~~~ 1 error generated. Fixes: 76dfed8a ("nir: mako all the intrinsics") Signed-off-by:
Chih-Wei Huang <cwhuang@linux.org.tw> Reviewed-by:
-
Dave Airlie authored
There might be a nicer way to do this, but this is at least correct. This fixes: KHR-GL44.tessellation_shader.single.max_patch_vertices KHR-GL44.tessellation_shader.tessellation_control_to_tessellation_evaluation.gl_PatchVerticesIn Reviewed-By:
Gert Wollny <gert.wollny@collabora.com> Cc: mesa-stable@lists.freedesktop.org (cherry picked from commit d73f1026)
-
Roland Scheidegger authored
The pt emit path can only handle 65535 - the number of vertices is truncated to a ushort, resulting in a too small buffer allocation, which will crash. Forcing the pipeline path looks suboptimal, then again this bug is probably there ever since GS is supported, so it seems it's not happening often. (Note that the vertex_id in the vertex header is 16 bit too, however this is only used by the draw pipeline, and it denotes the emit vertex nr, and that uses vbuf code, which will only emit smaller chunks, so should be fine I think.) Other solutions would be to simply allow 32bit counts for vertex allocation, however 65535 is already larger than this was intended for (the idea being it should be more cache friendly). Or could try to teach the pt emit path to split the emit in smaller chunks (only the non-index path can be affected, since gs output is always linear), but it's a bit tricky (we don't know the primitive boundaries up-front). Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=107295 Cc: <mesa-stable@lists.freedesktop.org> Reviewed-by:
Jose Fonseca <jfonseca@vmware.com> (cherry picked from commit 09828fea)
-
Harish Krupo authored
Clamp the x and y co-ordinates of the rectangles. v2: Clamp width/height after converting to co-ordinates (Ilia Merkin) Signed-off-by:Harish Krupo <harish.krupo.kps@intel.com> Reviewed-by:
Qiang Yu <yuq825@gmail.com> Reviewed-by:
Eric Engestrom <eric.engestrom@intel.com> (cherry picked from commit fd734608)
-
Danylo Piliaiev authored
After optimization passes and many trasfromations most of memory NIR holds is a garbage which was being freed only after shader deletion. Freeing it at the end of linking will save memory which would be useful in case there are a lot of complex shaders being compiled. The common case for this issue is 32bit game running under Wine. The cost of the optimization is around ~3-5% of compilation speed with complex shaders. V2: by Jason Ekstrand - Move nir_sweep up, right after the last change of NIR Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103274 Signed-off-by:Danylo Piliaiev <danylo.piliaiev@globallogic.com> Reviewed-by:
-
Faith Ekstrand authored
nir_sweep assumes that constants area always allocated off the variable to which they belong. Violating this assumption causes them to get freed early and leads to use-after-free bugs. Fixes: 120da009 "nir: add serialization and deserialization" Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107366 Reviewed-by:
Mark Janes <mark.a.janes@intel.com> (cherry picked from commit f214baf7)
-
Bas Nieuwenhuizen authored
That we don't have a background disk cache does not mean we should prevent the app caching anything. CC: <mesa-stable@lists.freedesktop.org> Reviewed-by:
-
Faith Ekstrand authored
The previous version was sort-of strapped on in that it just adjusted the blit rectangle and trusted in the fact that we would use texelFetch and round to the nearest integer to ensure that the component positions matched. This new version, while slightly more complicated, is more accurate because all three components end up with exactly the same dst_pos and so they will get interpolated and sampled at the same texture coordinate. This makes the workaround suitable for using with scaled blits. Reviewed-by:
Topi Pohjolainen <topi.pohjolainen@intel.com> (cherry picked from commit 293b8de1)
-
Faith Ekstrand authored
This fixes a nasty hang in Batman: Arkham City which apparently calls vkCmdClearColorImage on a linear RGB image. cc: mesa-stable@lists.freedesktop.org Reviewed-by:
-
Faith Ekstrand authored
The original pass only looked for load_uniform intrinsics but there are a number of other places that could end up loading a push constant. One obvious omission was images which always implicitly use a push constant. Legacy VS clip planes also get pushed into the shader. This fixes some new Vulkan CTS tests that test random combinations of bindings and, in particular, test lots of UBOs and images together. Cc: mesa-stable@lists.freedesktop.org Cc: Kenneth Graunke <kenneth@whitecape.org> (cherry picked from commit 820d5e51) Applied cleanly, but required backport performed by Dylan, as suggested by Jason
-
Faith Ekstrand authored
For one thing, the NIR opcodes for image load/store always take and return a vec4 value regardless of the image type. We need to fix up both the source and destination to handle it. For another thing, we weren't actually setting up a destination in the OpAtomicLoad case. Reviewed-by:
-
Dylan Baker authored
-
Dylan Baker authored
-
Timo Aaltonen authored
-
Timo Aaltonen authored
-
Timo Aaltonen authored
docs/relnotes/18.1.5.html
0 → 100644