Commits on Source (91)
-
Juan A. Suarez Romero authored
Signed-off-by:
Juan A. Suarez Romero <jasuarez@igalia.com>
-
Bas Nieuwenhuizen authored
Improves performance in Talos by about 15% (and significant improvements in RotR and possibly other but did not bench with final patch) on kernel 4.19 and earlier. On 4.20+ a similar effect comes from 433ca054949a "drm/amdgpu: try allocating VRAM as power of two" v2: Do not impact the alignment of the physical memory. Reviewed-by:
Dave Airlie <airlied@redhat.com> Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> CC: <mesa-stable@lists.freedesktop.org> (cherry picked from commit 6569644b)
-
Emil Velikov authored
Currently as the function fails, we pass uninitialized data to the authentication function. Stop doing that and print an warning when the function fails. v2: Plug memory leak in error path (Eric) Cc: mesa-stable@lists.freedesktop.org Signed-off-by:
Emil Velikov <emil.velikov@collabora.com> Reviewed-by: Tapani Pälli <tapani.palli@intel.com> (v1) Reviewed-by:
Eric Engestrom <eric.engestrom@intel.com> (cherry picked from commit c59d3aa4)
-
Emil Velikov authored
As we fail to open the node, we leak the node/device name. v2: Log and then free() (Eric) Cc: mesa-stable@lists.freedesktop.org Signed-off-by:
Emil Velikov <emil.velikov@collabora.com> Reviewed-by:
Eric Engestrom <eric.engestrom@intel.com> (cherry picked from commit ce74a7bb)
-
Nicolai Hähnle authored
Fixes: ce74a7bb ("egl/wayland: plug memory leak in drm_handle_device()") Fixes: c59d3aa4 ("egl/wayland: bail out when drmGetMagic fails") (cherry picked from commit c02390f8)
-
Dave Airlie authored
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108311 Cc: <mesa-stable@lists.freedesktop.org> (cherry picked from commit 2ddd44d9)
-
Thomas Hellstrom authored
Free the context after destruction. Cc: mesa-stable@lists.freedesktop.org Signed-off-by:
Thomas Hellstrom <thellstrom@vmware.com> Reviewed-by:
Sinclair Yeh <syeh@vmware.com> Reviewed-by:
Emil Velikov <emil.velikov@collabora.com> (cherry picked from commit 7fce3ca3)
-
Thomas Hellstrom authored
The ioctl.cap_3d member was never freed. Cc: mesa-stable@lists.freedesktop.org Signed-off-by:
Thomas Hellstrom <thellstrom@vmware.com> Reviewed-by:
Sinclair Yeh <syeh@vmware.com> Reviewed-by:
Emil Velikov <emil.velikov@collabora.com> (cherry picked from commit 058f85d4)
-
Lionel Landwerlin authored
Pipeline state pending bits should be taken into account when copying results. In the particular bug below, the results of the vkCmdCopyQueryPoolResults() command was being overwritten by the preceding vkCmdCopyBuffer() with a same destination buffer. This is because we copy the buffers using the 3D pipeline whereas we copy the query results using the command streamer. Those pieces of HW work in parallel and the results are somewhat undefined. v2: Unconditionally flush the pipeline before copying the results (Jason) v3: Wrap & expressions (Jason) Signed-off-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Suggested-by:
Jason Ekstrand <jason@jlekstrand.net> Reviewed-by:
Jason Ekstrand <jason@jlekstrand.net> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108894 Cc: mesa-stable@lists.freedesktop.org (cherry picked from commit 37f9788e)
-
Eric Engestrom authored
Per chapter 3.2 "Instances": > Providing a NULL VkInstanceCreateInfo::pApplicationInfo or providing > an apiVersion of 0 is equivalent to providing an apiVersion of > VK_MAKE_VERSION(1,0,0). Reported-by:
Niklas Haas <git@haasn.xyz> Fixes: 8c048af5 "anv: Copy the appliation info into the instance" Signed-off-by:
Eric Engestrom <eric.engestrom@intel.com> Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> (cherry picked from commit 56d126f8)
-
Bas Nieuwenhuizen authored
Mirrors AMDVLK. Looks like if we go over the alignment of height we actually start to change the addressing. Seems like the extra miplevels actually work with this. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108245 Fixes: f6cc15dc "radv/gfx9: fix block compression texture views. (v2)" Reviewed-by:
Dave Airlie <airlied@redhat.com> Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> (cherry picked from commit 08ea6b9d)
-
Eric Engestrom authored
Fixes: da997ebe "vulkan: Add KHR_display extension using DRM [v10]" Signed-off-by:
Eric Engestrom <eric.engestrom@intel.com> Reviewed-by:
Keith Packard <keithp@keithp.com> (cherry picked from commit 9575cd28)
-
Eric Engestrom authored
Fixes: 59e58c34 "vulkan/wsi: Only wait on semaphores on the first swapchain" Signed-off-by:
Eric Engestrom <eric.engestrom@intel.com> Reviewed-by:
Jason Ekstrand <jason@jlekstrand.net> (cherry picked from commit e0f1f74e)
-
Juan A. Suarez Romero authored
fixes: This commit fixes commits b4476138 and aa0fed10 which did not land in branch. Signed-off-by:
Juan A. Suarez Romero <jasuarez@igalia.com>
-
Vinson Lee authored
This patch fixes this build error. CC tests/xvmc_bench.o In file included from tests/xvmc_bench.c:35: tests/testlib.h:38:10: fatal error: 'X11/Xlib.h' file not found ^~~~~~~~~~~~ Signed-off-by:
Vinson Lee <vlee@freedesktop.org> Cc: mesa-stable@lists.freedesktop.org Reviewed-by:
Emil Velikov <emil.velikov@collabora.com> (cherry picked from commit 4f74580d)
-
Karol Herbst authored
The new approach is that samplers don't get unbound even if they won't be used in a draw and we should just leave them be as well. Fixes a regression in multiple windows games using gallium nine and nouveau. v2: adjust num_samplers to keep track of the highest sampler bound v3: rework how to set the new value of num_samplers Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106577 Fixes: 4d6fab24 "cso: don't track the number of sampler states bound" Signed-off-by:
Karol Herbst <kherbst@redhat.com> Reviewed-by:
Ilia Mirkin <imirkin@alum.mit.edu> (cherry picked from commit fc0139d2)
-
Gurchetan Singh authored
Tested running WebGL aquarium on Nvidia host (10,000 fishes) This moves us from 7 fps to 9 fps. After quadrupling, performance gains diminish. v2: Remove change ID (Erik) Tested-By:
Gert Wollny <gert.wollny@collabora.com> Reviewed-by:
Erik Faye-Lund <erik.faye-lund@collabora.com> (cherry picked from commit c0773315)
-
Gurchetan Singh authored
We flush everytime the command buffer (16 kB) is full, which is quite costly. This improves dEQP-GLES3.performance.buffer.data_upload.function_call.buffer_data.new_buffer.usage_stream_draw from 111.16 MB/s to 1930.36 MB/s. In addition, I made the benchmark produce buffers from 0 --> VIRGL_MAX_CMDBUF_DWORDS * 4, and tried ((VIRGL_MAX_CMDBUF_DWORDS * 4) / 2), ((VIRGL_MAX_CMDBUF_DWORDS * 4) / 4), etc. I didn't notice any clear differences, so let's just go with the most obvious heuristic. Tested-By:
Gert Wollny <gert.wollny@collabora.com> Reviewed-by:
Erik Faye-Lund <erik.faye-lund@collabora.com> (cherry picked from commit d18492c6)
-
Gurchetan Singh authored
We can mark the buffer unclean if it's ever bound as a TBO, SSBO, ABO, or image. This improves dEQP-GLES3.performance.buffer.data_upload.function_call.map_buffer_range.new_specified_buffer.flag_write_full.stream_draw from 9.58 MB/s to 451.17 MB/s. v2: Track buffer cleanliness as a function of bindings (Ilia). v3: virgl_modify_clean --> virgl_dirty_res (Erik) Tested-By:
Gert Wollny <gert.wollny@collabora.com> Reviewed-by:
Erik Faye-Lund <erik.faye-lund@collabora.com> (cherry picked from commit 89b4798c) [Juan A. Suarez: resolve trivial conflicts] Signed-off-by:
Juan A. Suarez Romero <jasuarez@igalia.com> Conflicts: src/gallium/drivers/virgl/virgl_encode.c
-
Juan A. Suarez Romero authored
pick: While this commit does not include the proper CC tag, it was intended to be applied only in 18.3 branch. Signed-off-by:
Juan A. Suarez Romero <jasuarez@igalia.com>
-
Tobias Klausmann authored
Without this the build breaks with: FAILED: src/amd/vulkan/src@amd@vulkan@@vulkan_radeon@sha/radv_pipeline.c.o cc -Isrc/amd/vulkan/src@amd@vulkan@@vulkan_radeon@sha -Isrc/amd/vulkan -I../src/amd/vulkan -Isrc/../include -I../src/../include -Isrc -I../src -Isrc/mapi -I../src/mapi -Isrc/mesa -I../src/mesa -I../src/gallium/include -Isrc/gallium/auxiliary -I../src/gallium/auxiliary -Isrc/amd -I../src/amd -Isrc/amd/common -I../src/amd/common -Isrc/compiler -I../src/compiler -Isrc/vulkan/util -I../src/vulkan/util -Isrc/vulkan/wsi -I../src/vulkan/wsi -Isrc/compiler/nir -I../src/compiler/nir -I/usr/include -I/usr/include/libdrm -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -std=c99 -O2 -g '-DVERSION="18.3.0-rc5"' -DPACKAGE_VERSION=VERSION '-DPACKAGE_BUGREPORT="https://bugs.freedesktop.org/enter_bug.cgi?product=Mesa" ' -DGLX_USE_TLS -DHAVE_ST_VDPAU -DENABLE_ST_OMX_BELLAGIO=0 -DENABLE_ST_OMX_TIZONIA=0 -DHAVE_X11_PLATFORM -DGLX_INDIRECT_RENDERING -DGLX_DIRECT_RENDERING -DGLX_USE_DRM -DHAVE_DRM_PLATFORM -DENABLE_SHADER_CACHE -DHAVE___BUILTIN_BSWAP32 -DHAVE___BUILTIN_BSWAP64 -DHAVE___BUILTIN_CLZ -DHAVE___BUILTIN_CLZLL -DHAVE___BUILTIN_CTZ -DHAVE___BUILTIN_EXPECT -DHAVE___BUILTIN_FFS -DHAVE___BUILTIN_FFSLL -DHAVE___BUILTIN_POPCOUNT -DHAVE___BUILTIN_POPCOUNTLL -DHAVE___BUILTIN_UNREACHABLE -DHAVE_FUNC_ATTRIBUTE_CONST -DHAVE_FUNC_ATTRIBUTE_FLATTEN -DHAVE_FUNC_ATTRIBUTE_MALLOC -DHAVE_FUNC_ATTRIBUTE_PURE -DHAVE_FUNC_ATTRIBUTE_UNUSED -DHAVE_FUNC_ATTRIBUTE_WARN_UNUSED_RESULT -DHAVE_FUNC_ATTRIBUTE_WEAK -DHAVE_FUNC_ATTRIBUTE_FORMAT -DHAVE_FUNC_ATTRIBUTE_PACKED -DHAVE_FUNC_ATTRIBUTE_RETURNS_NONNULL -DHAVE_FUNC_ATTRIBUTE_VISIBILITY -DHAVE_FUNC_ATTRIBUTE_ALIAS -DHAVE_FUNC_ATTRIBUTE_NORETURN -DUSE_SSE41 -DUSE_GCC_ATOMIC_BUILTINS -DUSE_X86_64_ASM -DMAJOR_IN_SYSMACROS -DHAVE_SYS_SYSCTL_H -DHAVE_LINUX_FUTEX_H -DHAVE_ENDIAN_H -DHAVE_DLFCN_H -DHAVE_STRTOF -DHAVE_MKOSTEMP -DHAVE_POSIX_MEMALIGN -DHAVE_TIMESPEC_GET -DHAVE_MEMFD_CREATE -DHAVE_STRTOD_L -DHAVE_DLADDR -DHAVE_DL_ITERATE_PHDR -DHAVE_ZLIB -DHAVE_PTHREAD -DHAVE_PTHREAD_SETAFFINITY -DHAVE_LIBDRM -DHAVE_LLVM=0x0600 -DMESA_LLVM_VERSION_PATCH=1 -DHAVE_WAYLAND_PLATFORM -DWL_HIDE_DEPRECATED -DHAVE_DRI3 -DHAVE_DRI3_MODIFIERS -Werror=implicit-function-declaration -Werror=missing-prototypes -Werror=return-type -fno-math-errno -fno-trapping-math -Wno-missing-field-initializers -Wno-format-truncation -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector-strong -funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection -DNDEBUG -fPIC -pthread -D__STDC_FORMAT_MACROS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_LIMIT_MACROS -fvisibility=hidden -Wno-override-init -DVK_USE_PLATFORM_XCB_KHR -DVK_USE_PLATFORM_XLIB_KHR -DVK_USE_PLATFORM_WAYLAND_KHR -DVK_USE_PLATFORM_DISPLAY_KHR -DVK_USE_PLATFORM_XLIB_XRANDR_EXT -MD -MQ 'src/amd/vulkan/src@amd@vulkan@@vulkan_radeon@sha/radv_pipeline.c.o' -MF 'src/amd/vulkan/src@amd@vulkan@@vulkan_radeon@sha/radv_pipeline.c.o.d' -o 'src/amd/vulkan/src@amd@vulkan@@vulkan_radeon@sha/radv_pipeline.c.o' -c ../src/amd/vulkan/radv_pipeline.c In file included from ../src/vulkan/util/vk_alloc.h:29, from ../src/amd/vulkan/radv_private.h:52, from ../src/amd/vulkan/radv_debug.h:27, from ../src/amd/vulkan/radv_pipeline.c:30: ../src/../include/vulkan/vulkan.h:54:10: fatal error: wayland-client.h: Datei oder Verzeichnis nicht gefunden #include <wayland-client.h> ^~~~~~~~~~~~~~~~~~ compilation terminated. The above command misses the include directory for wayland: -I/usr/include/wayland The missing include is contained in the (until now) unused radv_deps: if with_platform_wayland radv_deps += dep_wayland_client radv_flags += '-DVK_USE_PLATFORM_WAYLAND_KHR' libradv_files += files('radv_wsi_wayland.c') endif Fixes: 673dda83 "meson: build "radv" vulkan driver for radeon hardware" Signed-off-by:
Tobias Klausmann <tobias.johannes.klausmann@mni.thm.de> Reviewed-by:
Emil Velikov <emil.velikov@collabora.com> Reviewed-by:
Dylan Baker <dylan@pnwbakers.com> (cherry picked from commit 9401a2f2)
-
Bas Nieuwenhuizen authored
Fixes: b1444c9c "radv: Implement VK_ANDROID_native_buffer." Acked-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> (cherry picked from commit 51091b3e)
-
Bas Nieuwenhuizen authored
These days we don't always allocate scanout compatible textures anymore. That does mean we have to fix the radv android WSI though. Fixes: b1444c9c "radv: Implement VK_ANDROID_native_buffer." Acked-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> (cherry picked from commit 3bf48741)
-
Dave Airlie authored
This fixes some crucible 3d miptree tests I've been working on when executed using the compute shader path. Fixes: d08f2678 (radv/gfx9: fix 3d image to image transfers on compute queues.) Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> (cherry picked from commit 1363a47c)
-
Lionel Landwerlin authored
This change tracks render target writes in the pipeline and applies a render target flush before copying the query results to make sure the preceding operations have landed in memory before the command streamer initiates the copy. v2: Simplify logic in CopyQueryResults (Jason) Signed-off-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Reviewed-by:
Jason Ekstrand <jason@jlekstrand.net> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108909 Fixes: 37f9788e ("anv: flush pipeline before query result copies") Cc: mesa-stable@lists.freedesktop.org (cherry picked from commit 9a7b3199)
-
Michal Srb authored
The content is not expected to change. Cc: mesa-stable@lists.freedesktop.org Signed-off-by:
Michal Srb <msrb@suse.com> Reviewed-by:
Emil Velikov <emil.velikov@collabora.com> (cherry picked from commit c0ac038c)
-
Samuel Pitoiset authored
After investigating on this, it appears that COND_WRITE doesn't work correctly in some situations. I don't know exactly why does it fail to update DB_Z_INFO.ZRANGE_PRECISION, but as AMDVLK also uses COND_EXEC I think there is a reason. Now the driver stores a new metadata value in order to reflect the last fast depth clear state. If a TC-compat HTILE is fast cleared with 0.0f, we have to update ZRANGE_PRECISION to 0 in order to work around that hardware bug. This fixes rendering issues with The Forest and DXVK and doesn't seem to introduce any regressions. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108914 Fixes: 68dead11 ("radv: update the ZRANGE_PRECISION value for the TC-compat bug") Signed-off-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> (cherry picked from commit 824cfc1e)
-
Alex Smith authored
As done for vkCmdBeginQuery() already. Prevents timestamps from being overwritten by previous vkCmdResetQueryPool() calls if the shader path was used to do the reset. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108925 Fixes: a41e2e9c ("radv: allow to use a compute shader for resetting the query pool") Signed-off-by:
Alex Smith <asmith@feralinteractive.com> Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> (cherry picked from commit c1b6cb06) [Juan A. Suarez: resolve trivial conflicts] Signed-off-by:
Juan A. Suarez Romero <jasuarez@igalia.com> Conflicts: src/amd/vulkan/radv_query.c
-
Michal Srb authored
The original code was modifying the global drisw_lf variable, which is bad when there are multiple contexts in single process, each initialized with different loader. One may support put_image_shm and the other not. Since there are currently only two possible combinations, lets create two global tables, one for each. Lets make them const, since we won't change them and they can be shared. This fixes crash in VLC. It used two GL contexts (each in different thread), one was initialized by its Qt GUI, the other by its video output plugin. The first one set the put_image_shm=drisw_put_image_shm, the second did not, but since the same structure was used, the drisw_put_image_shm was used too. Then it crashed because the second loader did not have putImageShm set. Downstream bug: https://bugzilla.opensuse.org/show_bug.cgi?id=1113533 v2: Added Fixes and described the VLC bug. Fixes: 63c427fa ("drisw: use putImageShm if available") Signed-off-by:
Michal Srb <msrb@suse.com> Reviewed-by:
Emil Velikov <emil.velikov@collabora.com> (cherry picked from commit 63c0916a)
-
Emma Anholt authored
Fixes: 7a30517c ("broadcom/vc5: Start adding support for rendering to Z32F_S8X24_UINT.") (cherry picked from commit 3bd73d31) [Juan A. Suarez: resolve trivial conflicts] Signed-off-by:
Juan A. Suarez Romero <jasuarez@igalia.com> Conflicts: src/gallium/drivers/v3d/v3d_screen.c
-
Emma Anholt authored
Fixes: d009463a ("vc4: Switch to using u_transfer_helper for MSAA maps.") (cherry picked from commit 7f8d8b7d) [Juan A. Suarez: resolve trivial conflicts] Signed-off-by:
Juan A. Suarez Romero <jasuarez@igalia.com> Conflicts: src/gallium/drivers/vc4/vc4_screen.c
-
Emma Anholt authored
Fixes: ade416d0 ("broadcom: Add VC5 NIR compiler.") (cherry picked from commit f1d98204)
-
Nicolai Hähnle authored
Linking against LLVM built with BUILD_SHARED_LIBS fails otherwise, as the component is required for the draw module. Reviewed-by:
Dylan Baker <dylan@pnwbakers.com> (cherry picked from commit 4275cae9)
-
Juan A. Suarez Romero authored
Signed-off-by:
Juan A. Suarez Romero <jasuarez@igalia.com>
-
Juan A. Suarez Romero authored
Signed-off-by:
Juan A. Suarez Romero <jasuarez@igalia.com>
-
Juan A. Suarez Romero authored
Signed-off-by:
Juan A. Suarez Romero <jasuarez@igalia.com>
-
Timo Aaltonen authored
-
Timo Aaltonen authored
-
Timo Aaltonen authored
-
Juan A. Suarez Romero authored
Signed-off-by:
Juan A. Suarez Romero <jasuarez@igalia.com>
-
Samuel Pitoiset authored
Otherwise, Yakuza hangs the GPU with DXVK. We don't know if linetrip and pointlist are affected, so my point is to do that only for triangle strips. Cc: mesa-stable@lists.freedesktop.org Signed-off-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> (cherry picked from commit d8325f1f)
-
Kirill Burtsev authored
Currently we distinguish if the drawable is a window or pixmap by checking xcb_present_select_input throws an error or not. Yet, we don't always free the error state returned by xcb. Cc: Kirill Burtsev <kirill.burtsev@qt.io> Cc: Boyan Ding <boyan.j.ding@gmail.com> Fixes: 6bd9ba7d ("loader: Add dri3 helper") Reviewed-by:
Emil Velikov <emil.velikov@collabora.com> [Emil: add commit message, fixes tag] Signed-off-by:
Emil Velikov <emil.velikov@collabora.com> (cherry picked from commit a5393164)
-
Rob Clark authored
LinkedTransformFeedback is normally populated, which had nerf'd varying packing since the check was introduced. Fixes: dbd52585 st/nir: Disable varying packing when doing transform feedback. Signed-off-by:
Rob Clark <robdclark@gmail.com> Reviewed-by:
Timothy Arceri <tarceri@itsqueeze.com> (cherry picked from commit cfe82209)
-
Juan A. Suarez Romero authored
fixes: The changes this commit provides are already included in the branch. Signed-off-by:
Juan A. Suarez Romero <jasuarez@igalia.com>
-
Erik Faye-Lund authored
This just has one member for now; the handle. But this is about to change. Signed-off-by:
Erik Faye-Lund <erik.faye-lund@collabora.com> Reviewed-by:
Mathias Fröhlich <Mathias.Froehlich@web.de> Tested-By:
Gert Wollny <gert.wollny@collabora.com> (cherry picked from commit 8447b642)
-
Erik Faye-Lund authored
Virglrenderer does the wrong thing when given an instance divisor; it tries to use the element-index rather than the binding-index as the argument to glVertexBindingDivisor(). This worked fine as long as there was a 1:1 relationship between elements and bindings, which was the case util 19a91841 "st/mesa: Use Array._DrawVAO in st_atom_array.c.". So let's detect instance divisors, and restore a 1:1 relationship in that case. This will make old versions of virglrenderer behave correctly. For newer versions, we can consider making a better interface, where the instance divisor isn't specified per element, but rather per binding. But let's save that for another day. Signed-off-by:
Erik Faye-Lund <erik.faye-lund@collabora.com> Fixes: 19a91841 "st/mesa: Use Array._DrawVAO in st_atom_array.c." Reviewed-by:
Mathias Fröhlich <Mathias.Froehlich@web.de> Tested-By:
Gert Wollny <gert.wollny@collabora.com> (cherry picked from commit e888f28d)
-
Emil Velikov authored
Currently we have the three dri "platforms" - drm, apple and windows. Since xf86vidmode is a thing only for the drm one, adjust the preprocessor guards and correctly check for the dependency. v2: terminate the GLX_USE_WINDOWSGL hunk Cc: Jon TURNEY <jon.turney@dronecode.org.uk> Fixes: 5bc50936 ("glx: make xf86vidmode mandatory for direct rendering") Signed-off-by:
Emil Velikov <emil.velikov@collabora.com> Reviewed-by:
Dylan Baker <dylan@pnwbakers.com> Acked-by:
Eric Engestrom <eric.engestrom@intel.com> (cherry picked from commit a95ec138)
-
Alex Deucher authored
Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com> Cc: mesa-stable@lists.freedesktop.org (cherry picked from commit 56cf25a1)
-
Alex Deucher authored
Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com> Cc: mesa-stable@lists.freedesktop.org (cherry picked from commit 4db4b344)
-
Jan Vesely authored
CodeGenOptions were moved to Basic. Signed-off-by:
Jan Vesely <jan.vesely@rutgers.edu> Reviewed-by:
Aaron Watry <awatry@gmail.com> Tested-by:
Aaron Watry <awatry@gmail.com> Reviewed-by:
Kai Wasserbäch <kai@dev.carbon-project.org> CC: mesa-stable@lists.freedesktop.org (cherry picked from commit e4f9a37a)
-
Emma Anholt authored
The thrsw will invalidate rtop, just like accumulators and flags. Caught by simulator assertions in CS imulextended/umulextended tests. Fixes: 90269ba3 ("broadcom/vc5: Use THRSW to enable multi-threaded shaders.") (cherry picked from commit 3f9bcf91)
-
Emma Anholt authored
Fixes: f2e41daa ("broadcom/vc5: Update QPU instruction pack/unpack for v4.2.") (cherry picked from commit ff80e58b)
-
Jon Turney authored
Sadly, the GLX_USE_APPLEGL and GLX_USE_WINDOWSGL cases are not identical (because GLX_USE_WINDOWSGL uses vtables rather than a maze of ifdefs) Include <sys/time.h> again, as functions prototyped by it are used in the GLX_USE_WINDOWSGL path. Make the include guard around the __glxGetMscRate() definition match the one at it's declaration again, as it's referenced from dri_common.c which is built for GLX_USE_WINDOWSGL. Fixes: a95ec138 ("glx: mandate xf86vidmode only for "drm" dri platforms") Signed-off-by:
Jon Turney <jon.turney@dronecode.org.uk> Reviewed-by:
Emil Velikov <emil.velikov@collabora.com> (cherry picked from commit d512b35b)
-
Emilio Pozuelo Monfort authored
-
Emilio Pozuelo Monfort authored
-
Faith Ekstrand authored
Instead of looking at input_sizes[i] which contains the number of components for each source, we look at the bit size of input_types[i]. This fixes a regression in the 1-bit boolean series though I have no idea how we haven't seen it before now. Fixes: 35baee5d "nir/constant_folding: fix incorrect bit-size check" Fixes: 9076c4e2 "nir: update opcode definitions for different bit sizes" Reviewed-by:
Eric Anholt <eric@anholt.net> Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Tested-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> (cherry picked from commit 3595a0ab) [Juan A. Suarez: resolve trivial conflicts] Conflicts: src/compiler/nir/nir_opt_constant_folding.c
-
Iago Toral Quiroga authored
The implementation of these opcodes in the generator assumes that their arguments are packed, and it generates register regions based on that assumption. Reviewed-by:
Jason Ekstrand <jason@jlekstrand.net> (cherry picked from commit 39189432)
-
Rhys Perry authored
Fixes: f8d5b377 ('radv: set cb base tile swizzles for MRT speedups (v4)') Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108116 Signed-off-by:
Rhys Perry <pendingchaos02@gmail.com> Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> (cherry picked from commit bba94a3d)
-
Juan A. Suarez Romero authored
fixes: This commit requires commits aeaf8dbd and 7484bc89 which did not land in branch. Signed-off-by:
Juan A. Suarez Romero <jasuarez@igalia.com>
-
Ian Romanick authored
In an instruction sequence like cmp(8).ge.f0.0 vgrf17:D, vgrf2.xxxx:D, vgrf9.xxxx:D (+f0.0) sel(8) vgrf1:UD, vgrf8.xyzw:UD, vgrf1.xyzw:UD The other fields of vgrf17 may be unused, but the CMP still needs to generate the other flag bits. To my surprise, nothing in shader-db or any test suite appears to hit this. However, I have a change to brw_vec4_cmod_propagation that creates cases where this can happen. This fix prevents a couple dozen regressions in that patch. Signed-off-by:
Ian Romanick <ian.d.romanick@intel.com> Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Fixes: 5df88c20 ("i965/vec4: Rewrite dead code elimination to use live in/out.") (cherry picked from commit 440c0513)
-
Dylan Baker authored
Old versions of meson returned ppc64le as the cpu_family for little endian power8 cpus, versions >=0.48 don't do this, so the check wouldn't work in that case. This generalizes the check to work for both old and new versions of meson. Fixes: 34bbb24c ("meson: Add support for ppc assembly/optimizations") Reviewed-by:
Eric Engestrom <eric.engestrom@intel.com> (cherry picked from commit e430a034)
-
Vinson Lee authored
Fixes: 6b4c7047 ("meson: build gallium nine state_tracker") Signed-off-by:
Vinson Lee <vlee@freedesktop.org> Reviewed-by:
Emil Velikov <emil.velikov@collabora.com> (cherry picked from commit 84f39e59)
-
Vinson Lee authored
Fixes: 5e71efef ("meson: Add lmsensors support") Signed-off-by:
Vinson Lee <vlee@freedesktop.org> Reviewed-by:
Dylan Baker <dylan@pnwbakers.com> (cherry picked from commit 0f7ba575)
-
Ian Romanick authored
"There's no point in walking the program if we're never going to actually lower anything." Except we might lower compacted local arrays. In that case, modes will be 0, but there is still lowering to be done. This reverts commit 7f75cf2a. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109081 Suggested-by:
Kenneth Graunke <kenneth@whitecape.org> Reviewed-by:
Jason Ekstrand <jason@jlekstrand.net> Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Tested-by:
Clayton Craft <clayton.a.craft@intel.com> Cc: Kenneth Graunke <kenneth@whitecape.org> (cherry picked from commit 29e4b949)
-
Rhys Perry authored
This ends up refactoring visit_load_buffer() a little. Fixes: 7e7ee826 ('ac: add support for 16bit buffer loads') Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108114 Signed-off-by:
Rhys Perry <pendingchaos02@gmail.com> Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com>
-
Juan A. Suarez Romero authored
pick: This commit is nominated to stable, but fixes commit b3c61469 which is in 18.3 stable. Hence, this commit is considered as nominated to 18.3 stable. Signed-off-by:
Juan A. Suarez Romero <jasuarez@igalia.com>
-
Juan A. Suarez Romero authored
pick: This commit is nominated to stable, but fixes commit 11dc1307 which is not in the current stable branch. Signed-off-by:
Juan A. Suarez Romero <jasuarez@igalia.com>
-
Caio Oliveira authored
When updating a copy entry source value from a "non-SSA" (the data come from a copy instruction) to a "SSA" (the data or parts of it come from SSA values), it was possible to hold invalid data in ssa[0] depending on the writemask. Because the union, ssa[0] could contain a pointer to a nir_deref_instr left-over from previous non-SSA usage. Change code to clean up the array before use to avoid invalid data around. Fixes: 62332d13 "nir: Add a local variable-based copy propagation pass" Reviewed-by:
Jason Ekstrand <jason@jlekstrand.net> (cherry picked from commit 0ddc911f)
-
Emil Velikov authored
Currently our is_sha_nomination does: - folds any whitespace, attempting to extract sha-like information - checks that at least one of the shas has landed Split it in two and do sha-like validation first. This way, commits with mesa-stable and sha nominations will feature the fixes/revert/etc instead of stable (a) or will be omitted if not applicable for the respective branch (b). Misc examples from 18.3 (a) -[ stable ] 5bc50936 glx: make xf86vidmode mandatory for direct rendering +[ fixes ] 5bc50936 glx: make xf86vidmode mandatory for direct rendering (b) -[ stable ] 9a7b3199 anv/query: flush render target before copying results CC: Juan A. Suarez <jasuarez@igalia.com> CC: Dylan Baker <dylan@pnwbakers.com> CC: mesa-stable@lists.freedesktop.org Signed-off-by:
Emil Velikov <emil.velikov@collabora.com> Reviewed-by:
Andres Gomez <agomez@igalia.com> (cherry picked from commit 6b296f64)
-
Emil Velikov authored
We had cases where people would list old/invalid sha in the commit. Add a trivial checker to catch those and throw a warning. CC: Juan A. Suarez <jasuarez@igalia.com> CC: Dylan Baker <dylan@pnwbakers.com> CC: mesa-stable@lists.freedesktop.org Signed-off-by:
Emil Velikov <emil.velikov@collabora.com> Reviewed-by:
Andres Gomez <agomez@igalia.com> (cherry picked from commit e0dbfc99)
-
Alex Deucher authored
Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Signed-off-by:
Alex Deucher <alexander.deucher@amd.com> Cc: mesa-stable@lists.freedesktop.org (cherry picked from commit 516160d7)
-
Axel Davy authored
The dtor is called on allocation failure, thus we must check the volumes are allocated before trying to release them. Signed-off-by:
Axel Davy <davyaxel0@gmail.com> Tested-by:
Dieter Nützel <Dieter@nuetzel-hh.de> Cc: mesa-stable@lists.freedesktop.org (cherry picked from commit f91f748f)
-
Axel Davy authored
nine_context_box_upload uploads a ram buffer (from src) to a pipe_resource (dst). We already have a refcount on the pipe_resource, what needs to be protected from release is the ram buffer, thus a reference to src. Signed-off-by:
Axel Davy <davyaxel0@gmail.com> Tested-by:
Dieter Nützel <Dieter@nuetzel-hh.de> Cc: mesa-stable@lists.freedesktop.org (cherry picked from commit 42d672fa)
-
Axel Davy authored
Just like nine_context_box_upload, nine_context_range_upload should reference the src, which holds the ram source buffer. Fixes: https://github.com/iXit/Mesa-3D/issues/327 Signed-off-by:
Axel Davy <davyaxel0@gmail.com> Tested-by:
Dieter Nützel <Dieter@nuetzel-hh.de> Cc: mesa-stable@lists.freedesktop.org (cherry picked from commit 104681c5)
-
Lionel Landwerlin authored
We've made the choice not to use fast clears on layer > 0 with multilayer images. This is partly because we would need to store multiple clear colors for each layer, making the existing memory layout, already including aux surfaces, fast clear color, image state, etc... even more complex. Partial resolves are the operations transfering the clear colors into the auxiliary buffers. This operation is currently implemented in Blorp by loading the clear color from the image's BO, into a shader that then samples from the auxiliary buffer and writes the color only if it isn't there already. The problem here is that because we store only one clear color for all layers and it is used for partial resolves. If you trigger a partial clear on a layer > 0, then you're likely to deal with a color that is not what you actually want. In the particular issues below, we have multiple layers, each cleared with a different color but the partial resolve just writes the wrong color into the auxiliary buffers for layers > 0. Signed-off-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108910 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108911 Cc: mesa-stable@lists.freedesktop.org (cherry picked from commit e2ae5f2f)
-
Emil Velikov authored
The gallium drivers do not require a DRI loader. Drop the artificial and unnecessary restriction. Fixes: af9d2761 ("meson: build libmesa_gallium") Signed-off-by:
Emil Velikov <emil.velikov@collabora.com> Reviewed-by:
Dylan Baker <dylan@pnwbakers.com> (cherry picked from commit 9d105818)
-
Emil Velikov authored
The library is called libgalliumvl_stub - note singular. Fixes: 42ea0631 ("meson: build clover") Signed-off-by:
Emil Velikov <emil.velikov@collabora.com> Reviewed-by:
Dylan Baker <dylan@pnwbakers.com> (cherry picked from commit 2eedb79e)
-
Emil Velikov authored
The library itself (libGL) is only built when -Dglx=dri, yet it's accompanying tests are build even with -Dglx=xlib. Adjust the guards, so we don't build the tests when they are not applicable v2: - Reword commit message (Dylan) - Drop build_by_default hunk (Dylan) Fixes: a47c525f ("meson: build glx") Signed-off-by:
Emil Velikov <emil.velikov@collabora.com> Reviewed-by:
Dylan Baker <dylan@pnwbakers.com> (cherry picked from commit 9527f9ea)
-
Emil Velikov authored
When producing the final libGL.so/libGLX_mesa.so we only link the local static helper lib (libglx). Thus there's no reason for the includes. Fixes: a47c525f ("meson: build glx") Signed-off-by:
Emil Velikov <emil.velikov@collabora.com> Reviewed-by:
Dylan Baker <dylan@pnwbakers.com> (cherry picked from commit b44875e2)
-
Emil Velikov authored
Accidentally dropped with earlier commit.! Fixes: 4ccb9816 ("meson: Use consistent style for tests") Signed-off-by:
Emil Velikov <emil.velikov@collabora.com> Reviewed-by:
Dylan Baker <dylan@pnwbakers.com> (cherry picked from commit e139d7a8)
-
Emil Velikov authored
Swap '..' with the symbolic inc_glx and add glproto as dependency. That will pull the correct include, effectively fixing the tests on macOS. Fixes: a47c525f ("meson: build glx") Signed-off-by:
Emil Velikov <emil.velikov@collabora.com> Reviewed-by:
Dylan Baker <dylan@pnwbakers.com> (cherry picked from commit f331419f) [Juan A. Suarez: resolve trivial conflicts] Signed-off-by:
Juan A. Suarez Romero <jasuarez@igalia.com> Conflicts: src/glx/tests/meson.build
-
Juan A. Suarez Romero authored
Signed-off-by:
Juan A. Suarez Romero <jasuarez@igalia.com>
-
Juan A. Suarez Romero authored
Signed-off-by:
Juan A. Suarez Romero <jasuarez@igalia.com>
-
Timo Aaltonen authored
-
Timo Aaltonen authored
-
Timo Aaltonen authored
-
Timo Aaltonen authored
-
Timo Aaltonen authored
-
Andreas Boll authored
-
Andreas Boll authored
-
Andreas Boll authored
docs/relnotes/18.2.7.html
0 → 100644
docs/relnotes/18.2.8.html
0 → 100644