Commits on Source (28)
-
Samuel Iglesias Gonsálvez authored
If we have fsin or fcos trigonometric operations with constant values as inputs, we will multiply the result by 0.99997 in brw_nir_apply_trig_workarounds, making the result wrong. Adjusting the rules so they do not apply to const values we let a later constant fold to deal with it. v2: - Do not early constant fold but only apply the trig workaround for non constants (Caio). - Add fixes tag to commit log (Caio). Fixes: bfd17c76 "i965: Port INTEL_PRECISE_TRIG=1 to NIR." Signed-off-by:
Samuel Iglesias Gonsálvez <siglesias@igalia.com> Signed-off-by:
Andres Gomez <agomez@igalia.com> Reviewed-by:
Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com> (cherry picked from commit 3c474f85)
-
Haihao Xiang authored
Fixes: 89785e2d ("i965: add support for sampling from AYUV") Fixes: 7cab8d36 ("i965: Add support for sampling from XYUV images") Cc: Vivek Kasireddy <vivek.kasireddy@intel.com> Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com> Signed-off-by:
Haihao Xiang <haihao.xiang@intel.com> Reviewed-by:
Tapani Pälli <tapani.palli@intel.com> (cherry picked from commit 8a9b81ab)
-
Bas Nieuwenhuizen authored
Addresses this assert: deqp-vk: ../mesa-freedreno-9999/src/compiler/glsl_types.cpp:1244: static const glsl_type *glsl_type::get_interface_instance(const glsl_struct_field *, unsigned int, enum glsl_interface_packing, bool, const char *): Assertion `glsl_type_users > 0' failed. running dEQP-VK.api.smoke.triangle . Fixes: 624789e3 "compiler/glsl: handle case where we have multiple users for types" Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> (cherry picked from commit 7999e10c)
-
Samuel Pitoiset authored
We have to load 2 32-bit integer and to cast correctly. This fixes crashes with gs-double-interpolator.vk_shader_test. Cc: 19.2 <mesa-stable@lists.freedesktop.org> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111734 Signed-off-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> (cherry picked from commit 68820007)
-
Dylan Baker authored
-
Dylan Baker authored
-
Dylan Baker authored
--oneline shortens hashes, while --oneline=pretty doesn't, otherwise they are the same. Having full hashes is convenient as that is the format that the bin/.cherry-ignore script requires to work correctly.
-
Samuel Pitoiset authored
No GS copy shader if a pipeline enables NGG GS. This fixes dEQP-VK.pipeline.executable_properties.graphics.*geometry_stage*. Fixes: 86864eed ("radv: Implement radv_GetPipelineExecutablePropertiesKHR.") Signed-off-by:
-
Eric Engestrom authored
Akin to 1a25980c ("egl: drop incorrect pkg-config file for glvnd") and b01524ff ("meson: don't build libGLES*.so with GLVND") , removes a pkg-config file that shouldn't have been there in the first place, but was needed because of that GLVND bug. Now that the glvnd bug has been fixed, it was apparent that this gl.pc pkg-config file was forgotten to be removed, so let's do just that :) Suggested-by:
Matt Turner <mattst88@gmail.com> Cc: mesa-stable@lists.freedesktop.org Signed-off-by:
Eric Engestrom <eric.engestrom@intel.com> Reviewed-by:
-
Paulo Zanoni authored
The current code can create functions with a width of 32, which is not supported by our hardware. Add some code to simplify how we express what we want and prevent such cases. For some unknown reason, all the tests I could run seem to work even with these unsupported MOVs. Fixes: b0858c1c "intel/fs: Add a couple of simple helper opcodes" Reviewed-by:
Jason Ekstrand <jason@jlekstrand.net> Signed-off-by:
Paulo Zanoni <paulo.r.zanoni@intel.com> (cherry picked from commit 8e614c7a)
-
Tapani Pälli authored
Commit d1e1563b added a NULL check for eglGetSyncAttribKHR but eglGetSyncAttrib does not do this. Patch adds same check to happen with eglGetSyncAttrib. Fixes crashes in (when exposing EGL 1.5): dEQP-EGL.functional.fence_sync.invalid.get_invalid_value Signed-off-by:
-
Arcady Goldmints-Orlov authored
Later generations support bindless for samplers, images, and buffers and thus per-stage descriptors are not limited by the binding table size. However, gen8 doesn't support bindless images and thus needs to report a lower per-stage limit so that all combinations of descriptors that fit within the advertised limits are reported as supported by vkGetDescriptorSetLayoutSupport. Fixes test dEQP-VK.api.maintenance3_check.descriptor_set Fixes: 79fb0d27 ("anv: Implement SSBOs bindings with GPU addresses in the descriptor BO") Reviewed-by:
-
Andres Gomez authored
Currently, Vulkan 1.1. Cc: 19.2 <mesa-stable@lists.freedesktop.org> Signed-off-by:
Eric Engestrom <eric@engestrom.ch> Reviewed-by:
Dylan Baker <dylan@pnwbakers.com> (cherry picked from commit 41b0e0d7)
-
Adam Jackson authored
Cc: mesa-stable@lists.freedesktop.org Reviewed-by:
Eric Anholt <eric@anholt.net> Reviewed-by:
-
Ian Romanick authored
Some shaders do not use 'invariant' in vertex and (possibly) geometry shader stages on some outputs that are intended to be invariant. For various reasons, this optimization may not be fully applied in all shaders used for different rendering passes of the same geometry. This can result in Z-fighting artifacts (at best). For now, disable this optimization in these stages. In tessellation stages applications seem to use 'precise' when necessary, so allow the optimization in those stages. Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111490 Fixes: 09705747 ("nir/algebraic: Reassociate fadd into fmul in DPH-like pattern") All Gen8+ platforms had similar results. (Ice Lake shown) total instructions in shared programs: 16194726 -> 16344745 (0.93%) instructions in affected programs: 2855172 -> 3005191 (5.25%) helped: 6 HURT: 20279 helped stats (abs) min: 1 max: 3 x̄: 1.33 x̃: 1 helped stats (rel) min: 0.44% max: 1.00% x̄: 0.54% x̃: 0.44% HURT stats (abs) min: 1 max: 32 x̄: 7.40 x̃: 7 HURT stats (rel) min: 0.14% max: 42.86% x̄: 8.58% x̃: 6.56% 95% mean confidence interval for instructions value: 7.34 7.45 95% mean confidence interval for instructions %-change: 8.48% 8.67% Instructions are HURT. total cycles in shared programs: 364471296 -> 365014683 (0.15%) cycles in affected programs: 32421530 -> 32964917 (1.68%) helped: 2925 HURT: 16144 helped stats (abs) min: 1 max: 403 x̄: 18.39 x̃: 5 helped stats (rel) min: <.01% max: 22.61% x̄: 1.97% x̃: 1.15% HURT stats (abs) min: 1 max: 18471 x̄: 36.99 x̃: 15 HURT stats (rel) min: 0.02% max: 52.58% x̄: 5.60% x̃: 3.87% 95% mean confidence interval for cycles value: 21.58 35.41 95% mean confidence interval for cycles %-change: 4.36% 4.52% Cycles are HURT. (cherry picked from commit 92f70df8)
-
Freya Gentz authored
Currently there is no way to make no context current w/gallium + osmesa. The non-gallium version of osmesa does this if the context and buffer passed to `OSMesaMakeCurrent` are both null. This small change makes it so that this is also the case with the gallium version. Cc: mesa-stable@lists.freedesktop.org Signed-off-by:
Hal Gentz <zegentzy@protonmail.com> Reviewed-by:
-
Faith Ekstrand authored
In a3268599, I attempted to fix nir_repair_ssa for unreachable blocks. However, that commit missed the possibility that the use is in a block which, itself, is unreachable. In this case, we can end up in an infinite loop trying to replace a def with itself. Even though a no-op replacement is a fine operation, it keeps extending the end of the uses list as we're walking it. Instead of explicitly checking for the group of conditions, just check if the phi builder gives us a different def. That's guaranteed to be 100% reliable and, while it lacks symmetry with the is_valid checks, should be more reliable. Fixes: a3268599 "nir/repair_ssa: Repair dominance for unreachable..." Reviewed-by:
Ian Romanick <ian.d.romanick@intel.com> (cherry picked from commit d63162cf)
-
Marek Olšák authored
trivial and urgent Cc: 19.2 <mesa-stable@lists.freedesktop.org> (cherry picked from commit 65b69813)
-
Marek Olšák authored
Cc: 19.2 <mesa-stable@lists.freedesktop.org> Acked-by:
Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> (cherry picked from commit 48742de6)
-
Kenneth Graunke authored
From the MEDIA_VFE_STATE docs: "Starting with this configuration, the Maximum Number of Threads must be set to (#EU * 8) for GPGPU dispatches. Although there are only 7 threads per EU in the configuration, the FFTID is calculated as if there are 8 threads per EU, which in turn requires a larger amount of Scratch Space to be allocated by the driver." It's pretty clear that we need to increase this for scratch address calculations, because the FFTID has a certain bit-pattern. The quote above seems to indicate that we should increase the actual thread count programmed in MEDIA_VFE_STATE as well, but we think the intention is to only bump the scratch space. Fixes GPU hangs in Bioshock Infinite and Synmark's CSDof on Icelake 8x8. Fixes: 5ac804bd ("intel: Add a preliminary device for Ice Lake") Reviewed-by: -
Juan A. Suarez Romero authored
The script only handles commits with "Fixes: <sha1>" where <sha1> is equal or great than 8 chars. But <sha1> can be smaller, like 7 chars. This commit relax the restriction to handle <sha1> 4 or more chars. Fixes: 533fead4 ("bin/get-pick-list.sh: tweak the commit sha matching pattern") Acked-by:
Juan A. Suarez Romero <jasuarez@igalia.com> (cherry picked from commit b3c25e6f)
-
Bas Nieuwenhuizen authored
Released today and hangs on RADV. We don't have the root cause yet, but this should unblock people playing the game. No drirc because the radv debugflags are not usable from drirc and I want this backported. CC: <mesa-stable@lists.freedesktop.org> Reviewed-by:
Dave Airlie <airlied@redhat.com> (cherry picked from commit 780182f0)
-
Erik Faye-Lund authored
This code generates CVTSD2SI, which requires SSE2. So let's fix the required SSE-version. Signed-off-by:
Erik Faye-Lund <erik.faye-lund@collabora.com> Fixes: 5de29aee (util: try to use SSE instructions with MSVC and 32-bit gcc) Reviewed-by:
-
Mauro Rossi authored
This patch partially reverts 20294dce ("mesa: Enable asm unconditionally, ...") Android makefile build logic needs to disable assembler optimization in 32bit builds to avoid text relocations for libglapi.so shared Fixes the following build error with Android x86 32bit target: [ 0% 4/477] target SharedLib: libglapi (out/target/product/x86/obj/SHARED_LIBRARIES/libglapi_intermediates/LINKED/libglapi.so) FAILED: out/target/product/x86/obj/SHARED_LIBRARIES/libglapi_intermediates/LINKED/libglapi.so ... prebuilts/gcc/linux-x86/x86/x86_64-linux-android-4.9/x86_64-linux-android/bin/ld: warning: shared library text segment is not shareable prebuilts/gcc/linux-x86/x86/x86_64-linux-android-4.9/x86_64-linux-android/bin/ld: error: treating warnings as errors clang-6.0: error: linker command failed with exit code 1 (use -v to see invocation) Fixes: 20294dce ("mesa: Enable asm unconditionally, now that gen_matypes is gone.") Signed-off-by:
Mauro Rossi <issor.oruam@gmail.com> Acked-by:
-
Mauro Rossi authored
Change needed to fix the following building error: In file included from external/mesa/src/intel/vulkan/anv_device.c:43: external/mesa/src/util/xmlpool.h:115:10: fatal error: 'xmlpool/options.h' file not found ^~~~~~~~~~~~~~~~~~~ 1 error generated. Fixes: 4dcb1fff ("anv: add support for driconf") Signed-off-by: -
Eric Engestrom authored
This is a bit counter-intuitive, but the issue is that GLVND is broken in versions <= 1.1.1, so we need to keep wrongly providing these files to cover up their mistake, otherwise the rest of the world ends up broken. Suggested-by:
-
Dylan Baker authored
-
Dylan Baker authored
