Commits on Source (44)
-
Dylan Baker authored
-
Grazvydas Ignotas authored
Thanks to reproducible builds, binary file timestamps may be identical for both 32bit and 64bit packages when built from the same source. This means radv will use the same cache for both 32 and 64 bit processes, which leads to crashes. Conveniently there is a spare byte in cache_uuid, let's place the pointer size there. Fixes: f4e499ec "radv: add initial non-conformant radv vulkan driver" CC: 18.1 18.2 <mesa-stable@lists.freedesktop.org> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107601 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105904 Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> (cherry picked from commit 356f6673)
-
Nanley Chery authored
Fix rendering issues on BDW and SKL. Fixes: 0288fe8d ("i965/miptree: Use the correct BLT pitch") Fixes the following regressions seen exclusively on SKL: * KHR-GL46.texture_barrier_ARB.disjoint-texels * KHR-GL46.texture_barrier_ARB.overlapping-texels * KHR-GL46.texture_barrier.disjoint-texels * KHR-GL46.texture_barrier.overlapping-texels and both on BDW and SKL: * GTF-GL46.gtf21.GL2FixedTests.buffer_corners.buffer_corners * GTF-GL46.gtf21.GL2FixedTests.stencil_plane_corners.stencil_plane_corners v2: Note the fixed tests (Andres). Don't cause failures with multisampled buffers (Andres). Don't hamper SKL GT4 (Ken). v3: Fix the Fixes tag (Dylan). Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107359 Cc: <mesa-stable@lists.freedesktop.org> Tested-by:
Andres Gomez <agomez@igalia.com> Reviewed-by:
Jason Ekstrand <jason@jlekstrand.net> (cherry picked from commit 6d80b0b4)
-
Nanley Chery authored
We'd like to reuse this helper. Cc: <mesa-stable@lists.freedesktop.org> Reviewed-by:
Chris Wilson <chris@chris-wilson.co.uk> (cherry picked from commit 0ab25419)
-
Nanley Chery authored
Drop an if statement whose predicate never evaluates to true. row_pitch belongs to a surface with non-linear tiling. According to isl_calc_tiled_min_row_pitch, the pitch is a multiple of the tile width. By looking at isl_tiling_get_info, we see that non-linear tilings have widths greater than or equal to 128B. Cc: <mesa-stable@lists.freedesktop.org> Reviewed-by:
Chris Wilson <chris@chris-wilson.co.uk> (cherry picked from commit 3df201e3)
-
Nanley Chery authored
Retile miptrees to a linear tiling less often. Retiling can cause issues with imported BOs. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106738 Suggested-by:
Chris Wilson <chris@chris-wilson.co.uk> Cc: <mesa-stable@lists.freedesktop.org> Reviewed-by:
Chris Wilson <chris@chris-wilson.co.uk> (cherry picked from commit 0288fe8d)
-
Nanley Chery authored
This struct contains all the data of interest. can_blit_slice() will use it in the next patch to calculate the correct pitch. Suggested-by:
Chris Wilson <chris@chris-wilson.co.uk> Cc: <mesa-stable@lists.freedesktop.org> Reviewed-by:
Jason Ekstrand <jason@jlekstrand.net> (cherry picked from commit 030b6efc)
-
Nanley Chery authored
Check the destination's row pitch against the BLT engine's row pitch limitation as well. Fixes: 0288fe8d ("i965/miptree: Use the correct BLT pitch") v2: Fix the Fixes tag (Dylan). Check the destination row pitch (Chris). Reported-by:
Dylan Baker <dylan@pnwbakers.com> Cc: <mesa-stable@lists.freedesktop.org> Reviewed-by:
Jason Ekstrand <jason@jlekstrand.net> (cherry picked from commit b041fc06)
-
Gurchetan Singh authored
Without this, I get: > platform_surfaceless.c:38:10: fatal error: 'loader.h' file not found > #include "loader.h" > ^~~~~~~~~~ > 1 error generated. Fixes: 108d257a ("meson: build libEGL") Reviewed-by:
Dylan Baker <dylan@pnwbakers.com> v2: Split up patches, modify commit message (Dylan) (cherry picked from commit ec6cb01e)
-
Gurchetan Singh authored
Haven't tested this, but we do include loader.h in platform_android.c Fixes: c5ec1556 ("meson: wire up egl/android") Reviewed-by:
Dylan Baker <dylan@pnwbakers.com> (cherry picked from commit c731508b)
-
Emil Velikov authored
The requirement was bumped a while back, but we forgot to update the docs. Fixes: ed871af9 ("configure.ac: raise Mako required version to 0.8.0") Signed-off-by:
Emil Velikov <emil.velikov@collabora.com> Reviewed-by:
Dylan Baker <dylan@pnwbakers.com> Reviewed-by:
Eric Engestrom <eric.engestrom@intel.com> (cherry picked from commit e39b916d)
-
Dylan Baker authored
-
Marek Olšák authored
The extension was exposed but not the functions. This fixes: dEQP-GLES31.functional.debug.negative_coverage.get_error.buffer.readn_pixels dEQP-GLES31.functional.debug.negative_coverage.get_error.state.get_nuniformfv dEQP-GLES31.functional.debug.negative_coverage.get_error.state.get_nuniformiv Cc: 18.1 18.2 <mesa-stable@lists.freedesktop.org> Reviewed-by:
Tapani Pälli <tapani.palli@intel.com> (cherry picked from commit 37eee90d)
-
Faith Ekstrand authored
This fixes a GPU hang in DOOM 2016 running under wine. Cc: mesa-stable@lists.freedesktop.org Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=104809 Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> (cherry picked from commit 76b0e4d8)
-
Dylan Baker authored
-
Dylan Baker authored
Currently we run the script but don't actually load any files, even in a tarball where they exist. Fixes: 3218056e ("meson: Build i965 and dri stack") Reviewed-by:
Eric Engestrom <eric.engestrom@intel.com> (cherry picked from commit 7c00db95)
-
Vadym Shovkoplias authored
>From Section 4.3.4 (Inputs) of the GLSL 1.50 spec: "Only the input variables that are actually read need to be written by the previous stage; it is allowed to have superfluous declarations of input variables." Fixes: * interstage-multiple-shader-objects.shader_test v2: Update comment in ir.h since the usage of "used" field has been extended. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101247 Signed-off-by:
Vadym Shovkoplias <vadym.shovkoplias@globallogic.com> Reviewed-by:
Alejandro Piñeiro <apinheiro@igalia.com> Reviewed-by:
Timothy Arceri <tarceri@itsqueeze.com> (cherry picked from commit 4a8444d5)
-
Dylan Baker authored
-
Dylan Baker authored
-
Lionel Landwerlin authored
Newer blit tests are enabling depth&stencils blits. We currently don't support it but can do by iterating over the aspects masks (copy some logic from the CopyImage function). Signed-off-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Fixes: 9f44745e ("anv: Use blorp to implement VkBlitImage") Reviewed-by:
Jason Ekstrand <jason@jlekstrand.net> (cherry picked from commit 5a1c23d1)
-
Andrii Simiklit authored
When the SVBI Payload Enable is false I guess the register R1.4 which contains the Maximum Streamed Vertex Buffer Index is filled by zero and GS stops to write transform feedback when the transform feedback is not active. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107579 Signed-off-by:
Andrii Simiklit <andrii.simiklit@globallogic.com> Reviewed-by:
Samuel Iglesias Gonsálvez <siglesias@igalia.com> (cherry picked from commit 1b0df8a4)
-
Dylan Baker authored
-
Bas Nieuwenhuizen authored
CC: <mesa-stable@lists.freedesktop.org> Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> (cherry picked from commit 4738b6ac)
-
Faith Ekstrand authored
If it's not the right bit-size, it may not actually be the correct extraction. For now, we'll only worry about 32-bit versions. Fixes: 905ff861 "nir: Recognize open-coded extract_u16" Fixes: 76289fbf "nir: Recognize open-coded extract_u8" Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> (cherry picked from commit 116b47fe)
-
Dave Airlie authored
While adding transfer queues to radv, I started writing some tests, the first test I wrote fell over copying a buffer larger than this limit. Checked AMDVLK and found the correct limit. Cc: <mesa-stable@lists.freedesktop.org> Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Reviewed-by:
Marek Olšák <marek.olsak@amd.com> (cherry picked from commit 2c1f249f)
-
Faith Ekstrand authored
This also serves as a convenient "is this a fourcc format" check as well which we'll take advantage of in the next commit. Cc: mesa-stable@lists.freedesktop.org Tested-By:
Eero Tamminen <eero.t.tamminen@intel.com> Reviewed-by:
Eric Engestrom <eric.engestrom@intel.com> (cherry picked from commit b95896f4)
-
Faith Ekstrand authored
We already reject attempts to import images with invalid fourcc formats but don't really guard the queries all that well. This makes us error out in any calls to eglQueryDmaBufModifiersEXT if the given format is not a valid fourcc format. We also add an assert to ensure that drivers don't advertise any non-fourcc formats. Cc: mesa-stable@lists.freedesktop.org Tested-By:
Eero Tamminen <eero.t.tamminen@intel.com> Reviewed-by:
Eric Engestrom <eric.engestrom@intel.com> (cherry picked from commit 8c1b9882)
-
Bas Nieuwenhuizen authored
Mirrors 1e40f694 "ac/surface: fix CMASK fast clear for NPOT textures with mipmapping on SI/CI/VI" CC: <mesa-stable@lists.freedesktop.org> Reviewed-by:
Dave Airlie <airlied@redhat.com> Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> (cherry picked from commit 233718a1)
-
Bas Nieuwenhuizen authored
No clue what gets fixed by this but both radeonsi and amdvlk do it. CC: <mesa-stable@lists.freedesktop.org> Reviewed-by:
Dave Airlie <airlied@redhat.com> Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> (cherry picked from commit ab64891f)
-
Faith Ekstrand authored
We make the flush after a HiZ clear unconditional and add a flush/stall before the clear as well. Cc: mesa-stable@lists.freedesktop.org Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107760 Reviewed-by:
Chad Versace <chadversary@chromium.org> Reviewed-by:
Nanley Chery <nanley.g.chery@intel.com> (cherry picked from commit 62378c5e)
-
Ian Romanick authored
Page 190 of "Volume 7: 3D Media GPGPU Engine (Haswell)" says the valid range of the offset is [0, 0FFFFFFFh]. Signed-off-by:
Ian Romanick <ian.d.romanick@intel.com> Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> Cc: mesa-stable@lists.freedesktop.org (cherry picked from commit 82530ce1)
-
Ian Romanick authored
Fixes failure in the new piglit test tes-patch-input-array-vec2-index-invalid-rd.shader_test. Signed-off-by:
Ian Romanick <ian.d.romanick@intel.com> Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> Cc: mesa-stable@lists.freedesktop.org (cherry picked from commit 75666605)
-
Nanley Chery authored
According to internal docs, some gen9 platforms have a pixel shader push constant synchronization issue. Although not listed among said platforms, this issue seems to be present on the GeminiLake 2x6's we've tested. We consider the available workarounds to be too detrimental on performance. Instead, we mitigate the issue by applying part of one of the workarounds. Re-emit PUSH_CONSTANT_ALLOC at the top of every batch (as suggested by Ken). Fixes ext_framebuffer_multisample-accuracy piglit test failures with the following options: * 6 depth_draw small depthstencil * 8 stencil_draw small depthstencil * 6 stencil_draw small depthstencil * 8 depth_resolve small * 6 stencil_resolve small depthstencil * 4 stencil_draw small depthstencil * 16 stencil_draw small depthstencil * 16 depth_draw small depthstencil * 2 stencil_resolve small depthstencil * 6 stencil_draw small * all_samples stencil_draw small * 2 depth_draw small depthstencil * all_samples depth_draw small depthstencil * all_samples stencil_resolve small * 4 depth_draw small depthstencil * all_samples depth_draw small * all_samples stencil_draw small depthstencil * 4 stencil_resolve small depthstencil * 4 depth_resolve small depthstencil * all_samples stencil_resolve small depthstencil v2: Include more platforms in WA (Ken). Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=106865 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93355 Cc: <mesa-stable@lists.freedesktop.org> Tested-by:
Mark Janes <mark.a.janes@intel.com> Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> (cherry picked from commit 904c2a61)
-
Samuel Pitoiset authored
CTS doesn't test input clip/cull distances for the fragment shader stage, which explains why this was totally broken. I wrote a simple test locally that works now. This fixes a crash with GTA V and DXVK. Note that we are exporting unused parameters from the vertex shader now, but this can't be optimized easily because we don't keep the fragment shader info... Cc: mesa-stable@lists.freedesktop.org Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107477 Signed-off-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> (cherry picked from commit 6f47df31) Very minor conflicts resolved by Dylan Conflicts: src/amd/vulkan/radv_nir_to_llvm.c
-
Daniel Stone authored
Though the SARGB8888 format is used internally through its FourCC value, it is not a real format as defined by drm_fourcc.h; it cannot be used with KMS or other interfaces expecting drm_fourcc.h format codes. Ensure we don't advertise it through the dmabuf format/modifier query interfaces, preventing us from tripping over an assert. Signed-off-by:
Daniel Stone <daniels@collabora.com> Reported-by:
Michel Dänzer <michel.daenzer@amd.com> Fixes: 8c1b9882 ("egl/dri2: Guard against invalid fourcc formats") Acked-by:
Jason Ekstrand <jason.ekstrand@intel.com> (cherry picked from commit 01c0aa9f)
-
Christian Gmeiner authored
Fixes: 1755f608 ("tegra: Initial support") Signed-off-by:
Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-by:
Emil Velikov <emil.velikov@collabora.com> (cherry picked from commit d0b09e2d)
-
Dylan Baker authored
-
Dylan Baker authored
In this case the patch is fine for 18.2 as the required patches are already present, but they're not in 18.1 and they're too big to be pulled back.
-
Juan A. Suarez Romero authored
If color buffer is locked, do not set its wayland buffer to NULL; otherwise it can not be freed later. Rather, flag it in order to destroy it later on the release event. v2: instruct release event to unlock only or free wl_buffer too (Daniel) This also fixes dEQP-EGL.functional.swap_buffers_with_damage.* tests. CC: Daniel Stone <daniel@fooishbar.org>
-
Dylan Baker authored
-
Dylan Baker authored
-
Timo Aaltonen authored
-
Timo Aaltonen authored
-
Timo Aaltonen authored
docs/relnotes/18.1.8.html
0 → 100644