Commits on Source (96)
-
Dylan Baker authored
-
Kenneth Graunke authored
bound_vertex_buffers doesn't include extra draw parameters buffers. Tracking this correctly is kind of complicated, and iris_destroy_state isn't exactly in a hot path, so just loop over all VBO bindings. Fixes: 4122665d (iris: Enable ARB_shader_draw_parameters support) Reported-by:
Sergii Romantsov <sergii.romantsov@globallogic.com> (cherry picked from commit face2212)
-
Clément Guérin authored
Fixes corruption on game startup. Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/1888 Cc: 19.1 19.2 <mesa-stable@lists.freedesktop.org> Reviewed-by:
Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> (cherry picked from commit 5afbe87d)
-
Samuel Pitoiset authored
DOOM fails to handle more images than expected when the adaptative sync mode is enabled. Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/1902 Cc: 19.2 <mesa-stable@lists.freedesktop.org> Signed-off-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> (cherry picked from commit ad96c498)
-
Samuel Pitoiset authored
The spec has probably been misinterpreted during RADV bringup. This fixes GPU hangs with dEQP-VK.binding_model.*offset_nonzero*. Fixes: f4e499ec ("radv: add initial non-conformant radv vulkan driver") Signed-off-by:
-
Alejandro Piñeiro authored
Specifically when reading the primitive counters. This fixed ~700 CTS tests using this pattern: dEQP-GLES3.functional.transform_feedback.* when run after tests like dEQP-GLES3.functional.prerequisite.read_pixels on the same caselist. When run individually those tests were passing because prim_counts_offset was zero. Fixes: 0f2d1dfe ("v3d: use the GPU to record primitives written to transform feedback") Reviewed-by:
Jose Maria Casanova Crespo <jmcasanova@igalia.com> Reviewed-by:
Iago Toral Quiroga <itoral@igalia.com> (cherry picked from commit fa41a518)
-
Connor Abbott authored
Previously, for code like: loop { loop { a = load_ubo() } use(a) } adjust_block_for_loops() would return the block before the first loop. Now we compute the range of allowed blocks and then walk the dominance tree directly, guaranteeing directly that we always choose a block that dominates all the uses and is dominated by the definition. Reviewed-by:Daniel Schürmann <daniel@schuermann.dev> (cherry picked from commit af9296b8)
-
Connor Abbott authored
Previously, this could have made the resource divergent in code like that which is genereated by nir_lower_non_uniform_access. Fixes: da8ed68a ('nir: replace nir_move_load_const() with nir_opt_sink()') Reviewed-by:
-
Bas Nieuwenhuizen authored
Since we really cannot share them ever. Also remove an unused switch. Fixes: b7082970 "radv: Implement VK_KHR_external_memory" Reviewed-by:
-
Eric Engestrom authored
SCons and Meson have never supported that feature, and Autotools was deleted over 6 months ago and no-one complained yet, so it's pretty obvious nobody cares about it. Fixes: 95aefc94 ("Delete autotools") Signed-off-by:
Eric Engestrom <eric.engestrom@intel.com> Acked-by:
Dylan Baker <dylan@pnwbakers.com> (cherry picked from commit a0829cf2)
-
Eric Engestrom authored
This reflects better what is provided by glvnd or not. Fixes: 93df862b ("meson: re-add incorrect pkg-config files with GLVND for backward compatibility") Signed-off-by:
-
Eric Engestrom authored
Preparation for a later commit. Fixes: 93df862b ("meson: re-add incorrect pkg-config files with GLVND for backward compatibility") Signed-off-by:
-
Eric Engestrom authored
Fixes: 93df862b ("meson: re-add incorrect pkg-config files with GLVND for backward compatibility") Signed-off-by:
-
Eric Engestrom authored
Fixes: 93df862b ("meson: re-add incorrect pkg-config files with GLVND for backward compatibility") Signed-off-by:
-
Eric Engestrom authored
Fixes: 93df862b ("meson: re-add incorrect pkg-config files with GLVND for backward compatibility") Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/1846 Signed-off-by:
-
Bas Nieuwenhuizen authored
And after discard-only loops. Otherwise we end up with dead code which confuses nir_repair_ssa into adding a whole bunch of uses of undefined. However, for derefs, we sometimes always expect to get a variable instead of undefined. Fixes dEQP-VK.graphicsfuzz.write-red-in-loop-nest on radv. Fixes: c832820c "nir/dead_cf: Repair SSA if the pass makes progress" Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/1928 Reviewed-by:
Connor Abbott <cwabbott0@gmail.com> (cherry picked from commit 6da3bf26)
-
Timothy Arceri authored
The check to see if we were dealing with a buffer block was too late and only worked for named UBOs. Fixes: f32b01ca "glsl/linker: remove ubo explicit binding handling" Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/1900 (cherry picked from commit 1294f01e)
-
Samuel Pitoiset authored
This fixes a rendering issue with DiRT 4 on GFX10. Only GFX10 was affected because intensity formats are different. Cc: 19.2 <mesa-stable@lists.freedesktop.org> Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/1923 Signed-off-by:
-
Kenneth Graunke authored
Fixes several CTS tests: - KHR-GL46.tessellation_shader.vertex.vertex_spacing - KHR-GL46.tessellation_shader.tessellation_shader_point_mode.points_verification Fixes: 823609b1 ("iris/WIP: add broadwell support") (cherry picked from commit ac7af7c5)
-
Lucas Stach authored
GPUs with a single supported vertex stream must use the single state address to program the stream. Fixes: 3d09bb39 (etnaviv: GC7000: State changes for HALTI3..5) Signed-off-by:
Lucas Stach <l.stach@pengutronix.de> Reviewed-by:
Jonathan Marek <jonathan@marek.ca> (cherry picked from commit ce23bc92)
-
Samuel Pitoiset authored
This reverts commit 2ca8629f. This was initially ported from RadeonSI, but in the meantime it has been reverted because it might hang. Be conservative and re-introduce this packet emission. Unfortunately this doesn't fix anything known. Cc: 19.2 <mesa-stable@lists.freedesktop.org> Signed-off-by:
-
Alan Coopersmith authored
Fixes build failures on Solaris in C++ files using gcc: ../src/util/u_math.h:628:41: error: expected ‘,’ or ‘...’ before ‘dest’ 628 | util_memcpy_cpu_to_le32(void * restrict dest, const void * restrict src, size_t n) | ^~~~ ../src/util/u_math.h: In function ‘void* util_memcpy_cpu_to_le32(void*)’: ../src/util/u_math.h:641:18: error: ‘dest’ was not declared in this scope 641 | return memcpy(dest, src, n); | ^~~~ ../src/util/u_math.h:641:24: error: ‘src’ was not declared in this scope 641 | return memcpy(dest, src, n); | ^~~ ../src/util/u_math.h:641:29: error: ‘n’ was not declared in this scope; did you mean ‘yn’? 641 | return memcpy(dest, src, n); | ^ | yn Signed-off-by:Alan Coopersmith <alan.coopersmith@oracle.com> Acked-by:
-
Alan Coopersmith authored
gcc is very particular about where you place the (void) cast The previous placement made it error out with: In file included from disk_cache.c:40:0: ../../src/util/u_atomic.h:203:29: error: void value not ignored as it ought to be #define p_atomic_add(v, i) ((void) \ ^ disk_cache.c:658:4: note: in expansion of macro ‘p_atomic_add’ p_atomic_add(cache->size, size); ^ Signed-off-by: -
Alan Coopersmith authored
v2: Replace autoconf check for flock() with meson check Signed-off-by:
-
Alan Coopersmith authored
Fixes: dcf9d91a ("util: Handle differences in pthread_setname_np") Signed-off-by:
-
Alan Coopersmith authored
Signed-off-by:
-
Alan Coopersmith authored
Fixes build errors of: In file included from ../src/intel/vulkan/anv_private.h:48, from ../src/intel/vulkan/genX_blorp_exec.c:26: ../src/intel/common/gen_gem.h: In function ‘gen_ioctl’: ../src/intel/common/gen_gem.h:68:15: error: implicit declaration of function ‘ioctl’ [-Werror=implicit-function-declaration] 68 | ret = ioctl(fd, request, arg); | ^~~~~ In file included from ../include/c11/threads_posix.h:35, from ../include/c11/threads.h:66, from ../src/mesa/main/mtypes.h:39, from ../src/intel/compiler/brw_compiler.h:30, from ../src/intel/vulkan/anv_private.h:51, from ../src/intel/vulkan/genX_blorp_exec.c:26: /usr/include/unistd.h: At top level: /usr/include/unistd.h:471:12: error: conflicting types for ‘ioctl’ 471 | extern int ioctl(int, int, ...); | ^~~~~ /usr/include/unistd.h:471:1: note: a parameter list with an ellipsis can’t match an empty parameter name list declaration 471 | extern int ioctl(int, int, ...); | ^~~~~~ In file included from ../src/intel/vulkan/anv_private.h:48, from ../src/intel/vulkan/genX_blorp_exec.c:26: ../src/intel/common/gen_gem.h:68:15: note: previous implicit declaration of ‘ioctl’ was here 68 | ret = ioctl(fd, request, arg); | ^~~~~ Signed-off-by: -
Lionel Landwerlin authored
Found out by accident this was clashing with another driver. Signed-off-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Reviewed-by:
Christian Gmeiner <christian.gmeiner@gmail.com> Reviewed-by:
Kristian H. Kristensen <hoegsberg@google.com> Cc: <mesa-stable@lists.freedesktop.org> (cherry picked from commit 701e0ac0)
-
James Xiong authored
A buffer and its aux are imported separately, if the aux import is not completed yet when resource_get_param is called, merge the separate aux a.k.a the 2nd image into the main image. Fixes: 246eebba ("iris: Export and import surfaces with modifiers that have aux data") Signed-off-by:
James Xiong <james.xiong@intel.com> Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> Reviewed-by:
Jordan Justen <jordan.l.justen@intel.com> (cherry picked from commit fd235484)
-
Pierre-Eric Pelloux-Prayer authored
This commit moves the target check before using _mesa_get_current_tex_object to fix a "Mesa implementation error: bad target in _mesa_get_current_tex_object()" error. Fixes: 9dd1f7ce ("mesa: pass gl_texture_object as arg to not depend on state") Reviewed-by:
-
Eric Engestrom authored
We're trying to cast the return type to the type of the var, but instead we were casting `sizeof(*v)`. Fixes: 6df72e97 ("util: Make u_atomic.h typeless.") Fixes: 0a7f17cf ("util/u_atomic: add p_atomic_xchg") Signed-off-by:
-
Samuel Pitoiset authored
Previous fix was pretty bogus. This fixes a rendering regression with Nier (minimap too large). Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/1943 Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/1952 Fixes: ea92273c ("radv: fix DCC fast clear code for intensity formats") Signed-off-by:
-
Roland Scheidegger authored
LLVM 8 did remove both the signed and unsigned sse2/avx intrinsics in the end, and provide arch-independent llvm intrinsics instead. Fixes a crash when using snorm framebuffers (tested with piglit arb_color_buffer_float-render GL_RGBA8_SNORM -auto). Reviewed-by:
Jose Fonseca <jfonseca@vmware.com> Reviewed-by:
Dave Airlie <airlied@redhat.com> CC: <mesa-stable@lists.freedesktop.org> (cherry picked from commit 045f05a2) Conflicts resolved by Dylan Baker
-
Ian Romanick authored
Reviewed-by:
Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com> Fixes: 09705747 ("nir/algebraic: Reassociate fadd into fmul in DPH-like pattern") (cherry picked from commit 050e4e28)
-
Ian Romanick authored
DPH isn't actually commutative, so this doesn't work. If the immediate in src0 would be a VF candidate, we could do better. *shrug* No shader-db changes on any Intel platform. Reviewed-by:
-
Lucas Stach authored
The rbug wire format defines the texture size parameters to be uint32_t sized and uses memcpy to move the function parameters to the message structure. This caused totally wrong transmitted texture sizes since the height and depth paramterds have been changed to uint16_t in the gallium API. Fix this by doing an explicit conversion to the correct representation before packing into the wire message. Fixes: e6428092 (gallium: decrease the size of pipe_resource - 64 -> 48 bytes) Signed-off-by:
-
Lucas Stach authored
All resources passed to the drivers below rbug need to be unwrapped before being passed down. We missed to do this for the index buffer resource when this was made part of the draw_info structure. Fixes: 330d0607 (gallium: remove pipe_index_buffer and set_index_buffer) Signed-off-by:
-
Lionel Landwerlin authored
With inline uniform blocks descriptor, the meaning of descriptorCount is a number of bytes to copy into the descriptor. Don't try to use that size as an index into the descriptor table. Signed-off-by:
Jason Ekstrand <jason@jlekstrand.net> (cherry picked from commit 3f8f52b2)
-
Lionel Landwerlin authored
v2: handle vma destruction if vkCreateDevice fails (Jordan) Signed-off-by:
-
Lepton Wu authored
We currently doesn't maintain it correctly and the buffer gets leaked if surface is destroyed before calling swapping buffers. From Android frameworks/native/libs/nativewindow/include/system/window.h: The window holds a reference to the buffer between dequeueBuffer and either queueBuffer or cancelBuffer, so clients only need their own reference if they might use the buffer after queueing or canceling it. v2: Remove our own reference. Fixes: 0212db35 ("egl/android: Cancel any outstanding ANativeBuffer in surface destructor") Reviewed-by: Chia-I Wu <olvaffe@gmail.com> (v1) Reviewed-By:
Tapani Pälli <tapani.palli@intel.com> Signed-off-by:
Lepton Wu <lepton@chromium.org> (cherry picked from commit f4ba31ff)
-
Bas Nieuwenhuizen authored
e.g. a VERTEX only flush with tess on Vega should look at the TCS to see which bits are needed. CC: <mesa-stable@lists.freedesktop.org> Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/1953 Reviewed-by:
-
Samuel Pitoiset authored
On GFX9, the driver is able to do an optimized fast depth/stencil clear with only one aspect (ie. clear the stencil part of a depth/stencil image). When this happens, the driver should only update the clear values of the given aspect. Note that it's currently only supported on GFX9 but I have some local patches that extend this optimized path for other gens. Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/1967 Cc: 19.2 <mesa-stable@lists.freedesktop.org> Signed-off-by:
-
Dylan Baker authored
-
Dylan Baker authored
-
Lionel Landwerlin authored
We're skipping the context destruction in some cases which is the grand scheme of thing is not that important because closing device->fd will destroy the associated context as well. Signed-off-by:
-
Samuel Pitoiset authored
The driver only supports up to 8 samples, so it's useless to create more pipelines than needed. This fixes a conditional jump reported by Valgrind on GFX10: ==194282== Conditional jump or move depends on uninitialised value(s) ==194282== at 0xDBF925A: radv_gfx10_compute_bin_size (radv_pipeline.c:3242) ==194282== by 0xDBF95A6: radv_pipeline_generate_binning_state (radv_pipeline.c:3334) ==194282== by 0xDBFC1A0: radv_pipeline_generate_pm4 (radv_pipeline.c:4440) ==194282== by 0xDBFD15E: radv_pipeline_init (radv_pipeline.c:4764) ==194282== by 0xDBFD23E: radv_graphics_pipeline_create (radv_pipeline.c:4788) ==194282== by 0xDBB95A3: create_pipeline (radv_meta_clear.c:114) ==194282== by 0xDBB9AC5: create_color_pipeline (radv_meta_clear.c:297) ==194282== by 0xDBBCF05: radv_device_init_meta_clear_state (radv_meta_clear.c:1277) ==194282== by 0xDB9ACD9: radv_device_init_meta (radv_meta.c:363) ==194282== by 0xDB7FE3A: radv_CreateDevice (radv_device.c:2080 This is caused by an out of bound access of 'fmask_array' (ie. index is 4 as for 16 samples). Cc: <mesa-stable@lists.freedesktop.org> Signed-off-by:
-
Samuel Pitoiset authored
Fixes some crashes with dEQP-VK.geometry.layered.*.secondary_cmd_buffer on Raven and other chips that allow rbplus. This just prevents a crash and rbplus probaby needs more work. Cc: 19.2 <mesa-stable@lists.freedesktop.org> Signed-off-by:
-
Samuel Pitoiset authored
GFX10 does act like GFX9 actually. This fixes dEQP-VK.glsl.texture_functions.query.texturesize.*sampler3d_*. Cc: 19.2 <mesa-stable@lists.freedesktop.org> Signed-off-by:
-
Samuel Pitoiset authored
descriptorCount is the number of bytes into the descriptor, so it shouldn't be used as an index. srcArrayElement/dstArrayElement specify the starting byte offset within the binding to copy from/to. This fixes new CTS tests: dEQP-VK.binding_model.descriptor_copy.*.inline_uniform_block_* dEQP-VK.binding_model.descriptor_copy.*.mix_3 dEQP-VK.binding_model.descriptor_copy.*.mix_array1 Fixes: 8d2654a4 ("radv: Support VK_EXT_inline_uniform_block.") Signed-off-by:
-
Marek Olšák authored
This fixes a deadlock in pthread_barrier_destroy. Cc: 19.1 19.2 <mesa-stable@lists.freedesktop.org> Reviewed-by:
-
Thomas Hellstrom authored
Even with banded DMA uploads, st->hwbuf is always non-NULL, but when we've allocated a software buffer to hold the full upload, unmapping of the hardware buffer has already been done before svga_texture_transfer_unmap_dma(), and the code was performing an unmap of an already mapped buffer. Fix this by testing for software buffer not present. Fixes: a9c4a861 ("svga: refactor svga_texture_transfer_map/unmap functions") Signed-off-by:
Thomas Hellstrom <thellstrom@vmware.com> Reviewed-by:
Brian Paul <brianp@vmware.com> Reviewed-by:
Charmaine Lee <charmainel@vmware.com> Reviewed-by:
Roland Scheidegger <sroland@vmware.com> (cherry picked from commit 00db9769)
-
Thomas Hellstrom authored
The kernel total GMR/DMA size is limited, but it's definitely possible for the kernel to allow a larger buffer allocation to succeed, but command submission using that buffer as a GMR would fail typically causing an application crash. So have the winsys limit the size of GMR/DMA buffers. The pipe driver will then resort to allocating smaller buffers and perform the DMA transfer in multiple bands, also allowing for the pre-flush mechanism to kick in. This avoids the related application crashes. Fixes: e7843273 ("winsys/svga: Update to vmwgfx kernel module 2.1") Signed-off-by:
-
Jon Turney authored
[12/60] Compiling C object 'src/gallium/auxiliary/eb820e8@@gallium@sta/rbug_rbug_texture.c.o'. FAILED: src/gallium/auxiliary/eb820e8@@gallium@sta/rbug_rbug_texture.c.o [...] ../src/gallium/auxiliary/rbug/rbug_texture.c: In function 'rbug_send_texture_info_reply': ../src/gallium/auxiliary/rbug/rbug_texture.c:302:21: error: implicit declaration of function 'alloca'; did you mean 'malloc'? [-Werror=implicit-function-declaration] uint32_t *height = alloca(sizeof(uint32_t) * height_len); ^~~~~~ malloc ../src/gallium/auxiliary/rbug/rbug_texture.c:302:21: warning: initialization makes pointer from integer without a cast [-Wint-conversion] ../src/gallium/auxiliary/rbug/rbug_texture.c:303:20: warning: initialization makes pointer from integer without a cast [-Wint-conversion] uint32_t *depth = alloca(sizeof(uint32_t) * height_len); ^~~~~~ cc1: some warnings being treated as errors Include c99_alloca.h to portably make the alloca() prototype available. See also: 498d9d0f, adfb9c5c, fc8139b1 Fixes: 6174cba7 ("rbug: fix transmitted texture sizes") Reviewed-by:Eric Engestrom <eric@engestrom.ch> Reviewed-by:
-
Illia Iorin authored
This reverts commit a113a42e. Per https://github.com/KhronosGroup/OpenGL-API/issues/45 it was a wrong way to fix the issue. Signed-off-by:
Illia Iorin <illia.iorin@globallogic.com> Reviewed-by:
-
Dylan Baker authored
Previously this would result in the .0 warning be generated for .z > 0 and the .z == 0 would get the other message. Fixes: 86079447 ("scripts: Add a gen_release_notes.py script") Reviewed-by:
Juan A. Suarez <jasuarez@igalia.com> (cherry picked from commit 69f540c0)
-
Dylan Baker authored
If they use the `Fixes: #1` form. Fixes: 86079447 ("scripts: Add a gen_release_notes.py script") Reviewed-by:
-
Dylan Baker authored
Which is very likely .Z > 0 releases. Fixes: 86079447 ("scripts: Add a gen_release_notes.py script") Reviewed-by:
-
Dylan Baker authored
I made a bad assumption; I assumed this would be run in the release branch. But we don't do that, we run in the master branch. As a result we need to pass the version as an argument. Fixes: 3226b12a ("release: Add an update_release_calendar.py script") Reviewed-by:
-
Dylan Baker authored
Fixes: 3226b12a ("release: Add an update_release_calendar.py script") Reviewed-by:
-
Dylan Baker authored
oops. Fixes: 3226b12a ("release: Add an update_release_calendar.py script") Reviewed-by:
-
Dylan Baker authored
All of these (bug titles, patch titles, features, and people's names) can contain characters that are not valid html. Just escape everything for safety. Fixes: 86079447 ("scripts: Add a gen_release_notes.py script") Reviewed-by:
-
Dylan Baker authored
Fixes: 86079447 ("scripts: Add a gen_release_notes.py script") Reviewed-by:
-
Tapani Pälli authored
Commit d2b60e43 introduced restrictions (as per GLES spec) on the internal format. We need to setup a sized format for the texture image so framebuffers created with that are considered complete. This change fixes following Android CTS test in AHardwareBufferNativeTests category: SingleLayer_ColorTest_GpuColorOutputAndSampledImage_R10G10B10A2_UNORM Signed-off-by:
-
Danylo Piliaiev authored
Better be safe, even if we could technically avoid this for some fields. Cc: <mesa-stable@lists.freedesktop.org> Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/1999 Signed-off-by:
Danylo Piliaiev <danylo.piliaiev@globallogic.com> Tested-by:
Witold Baryluk <witold.baryluk@gmail.com> Reviewed-by:
-
Nanley Chery authored
add_aux_state_tracking_buffer() actually checks the aux usage when determining how many dwords to allocate for state tracking. Move the function call to the point after the CCS_E aux usage is assigned. Fixes: de3be618 ("anv/cmd_buffer: Rework aux tracking") Reviewed-by:
-
Nanley Chery authored
We'll start doing slow depth clears more often on HIZ_CCS buffers in a future commit. Reduce the performance impact by making them use less bandwidth. From the Depth Test section of the BSpec: This function is enabled by the Depth Test Enable state variable. If enabled, the pixel's ("source") depth value is first computed. After computation the pixel's depth value is clamped to the range defined by Minimum Depth and Maximum Depth in the selected CC_VIEWPORT state. Then the current ("destination") depth buffer value for this pixel is read. and from the Depth Buffer Updates section of the BSpec: If depth testing is disabled or the depth test passed, the incoming pixel's depth value is written to the Depth Buffer. Taken together, it's clear that depth testing isn't necessary to perform a depth buffer clear. Mark Janes and I analyzed this patch with frameretrace and a depthrange piglit test. I disabled HiZ to ensure we'd get slow depth clears. We've observed the bandwidth consumption by the depth buffer access to be cut ~50% on BDW and SKL during depth clears. On a more graphically intensive workload, the Shadowmapping Sascha benchmark, I took the average of 3 runs on a BDW with a display resolution of about 1920x1200 (minus some desktop environment decorations). I measured a 22.61% FPS improvement when HiZ is disabled. v2. The BSpec doesn't mandate this behavior, update comment accordingly. (Ken) Fixes: bc4bb5a7 ("intel/blorp: Emit more complete DEPTH_STENCIL state") Reviewed-by: -
Nanley Chery authored
Fixes: 2cddc953 ("iris: some initial HiZ bits") Reviewed-by:
-
Nanley Chery authored
Make sure the res struct is free'd before returning. Fixes: 2dce0e94 ("iris: Initial commit of a new 'iris' driver for Intel Gen8+ GPUs.") Reviewed-by:
Sagar Ghuge <sagar.ghuge@intel.com> Reviewed-by:
-
Nanley Chery authored
If a modifier specifies an aux, it must be created. Fixes: 75a3947a ("iris/resource: Fall back to no aux if creation fails") Reviewed-by:
-
Caio Oliveira authored
The anv_batch_bo contents are linked one to another, and when printing we have to start with the first of those. Since in `u_vector` new elements are added to the head, to get the first element we need the vector's tail. Fixes: 32ffd900 ("anv: add support for INTEL_DEBUG=bat") Reviewed-by:
-
Sagar Ghuge authored
We never saw any failures regarding this typo but it's good to assign correct stencil view while constructing blorp_params. Fixes: 0cabf93b "intel/blorp: Add an entrypoint for clearing depth and stencil" Signed-off-by:
Nanley Chery <nanley.g.chery@intel.com> (cherry picked from commit ce208be2)
-
Jonathan Marek authored
Fixes remaining failures in these deqp tests (tested on GC3000/GC7000L): dEQP-GLES2.functional.polygon_offset.* Fixes: 6c3c05dc ("etnaviv: fix polygon offset") Signed-off-by:
-
Ilia Mirkin authored
Observed an issue when looking at the code generatedy by the image-vertex-attrib-input-output piglit test. Even though the test itself worked fine (due to TIC 0 being used for the image), this needs to be fixed. Signed-off-by:
Ilia Mirkin <imirkin@alum.mit.edu> Cc: mesa-stable@lists.freedesktop.org (cherry picked from commit 1b9d1e13)
-
Bas Nieuwenhuizen authored
libdrm returns -errno instead of directly the ioctl ret of -1. Fixes: 1c3cda7d "radv: Add syncobj signal/reset/wait to winsys." Reviewed-by:
-
Bas Nieuwenhuizen authored
The resulting locale is not used for Vulkan, and it is not reference counted, giving issues when multiple instances are created. CC: 19.2 19.3 <mesa-stable@lists.freedesktop.org> Reviewed-by:
-
Bas Nieuwenhuizen authored
The resulting locale is not used for Vulkan, and it is not reference counted, giving issues when multiple instances are created. CC: 19.2 19.3 <mesa-stable@lists.freedesktop.org> Reviewed-by:
-
Bas Nieuwenhuizen authored
The resulting locale is not used for Vulkan, and it is not reference counted, giving issues when multiple instances are created. CC: 19.2 19.3 <mesa-stable@lists.freedesktop.org> Reviewed-by:
-
Pierre-Eric Pelloux-Prayer authored
If the DrawBuffer sample count is > 1 and msaa is enabled we must also enable msaa when clearing it. Fixes: ea5b7de1 ("radeonsi: make gl_SampleMaskIn = 0x1 when MSAA is disabled") Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/1991 Reviewed-by:
-
Faith Ekstrand authored
Fixes: 731c4adc "anv/allocator: Add support for non-userptr" Reviewed-by:
-
Faith Ekstrand authored
Some of the tests were actually relying on some of those uninitialized bits to be non-zero. In particular, a couple want use_softpin = true. Cc: mesa-stable@lists.freedesktop.org Reviewed-by:
-
Dylan Baker authored
-
Lionel Landwerlin authored
Signed-off-by:
-
Jon Turney authored
Since struct timespec's tv_sec member is of type time_t, adjust the expected value to allow for the truncation which will occur with 32-bit time_t. Reviewed-by:
Adam Jackson <ajax@redhat.com> (cherry picked from commit dd1dba80) Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/2043
-
Dylan Baker authored
Python has the identity operator `is`, and the equality operator `==`. Using `is` with strings sometimes works in CPython due to optimizations (they have some kind of cache), but it may not always work. Fixes: 96c4b135 ("nir/algebraic: Don't put quotes around floating point literals") Reviewed-by:
Matt Turner <mattst88@gmail.com> (cherry picked from commit 717606f9)
-
Kenneth Graunke authored
In 2ca0d913, we began updating cso_fb->layers to the actual layer count, rather than 0. This fixed cases where we were setting "Force Zero RTA Index Enable" even when doing layered rendering. Sadly, it also broke the check entirely: cso_fb->layers is now 1 for non-layered cases, but the Force Zero RTA Index check was still comparing for 0. Fixes: 2ca0d913 ("iris: Fix framebuffer layer count") (cherry picked from commit fc7b7480)
-
Paulo Zanoni authored
Commit 5847de6e implemented a restriction that applies to ICL, but wrongly marked it as also applying to GLK. Reviewers or MR !1125 pointed this, and the commit history shows removal of GLK to parts of the patch, but it turns there was still a left-over GLK check in the code. This code was breaking some of the i8vec2 tests on GLK, for example: dEQP-VK.subgroups.arithmetic.compute.subgroupadd_i8vec2 Removing the GLK check solves the issue for GLK. I don't see a reason on why implementing this restriction would actually break GLK, so there's still more to investigate here since this bug may be affecting ICL+, but let's apply the real GLK fix while we analyze and discuss the other possible issues. Fixes: 5847de6e ("intel/compiler: don't use byte operands for src1 on ICL") BSpec: 3017 Reviewed-by:
Paulo Zanoni <paulo.r.zanoni@intel.com> (cherry picked from commit b57383a9)
-
Dylan Baker authored
Otherwise if glvnd is not installed systemwide, but only in a prefix, it's headers wont be found. This happens because if it's headers are in /usr/include/ then another dependence will provide the necessary -I arguments and compilation will work. Fixes: 035ec7a2 ("meson: Add support for EGL glvnd") Acked-by:
-
Dylan Baker authored
-
Dylan Baker authored
-
Timo Aaltonen authored
-
Timo Aaltonen authored
-
Timo Aaltonen authored
create-gles-pc-files-with-old-glvnd.diff: Drop the revert with a proposed patch to fix creating gles pc files with old glvnd.
-
Timo Aaltonen authored
-
Timo Aaltonen authored
-
Timo Aaltonen authored
-
Timo Aaltonen authored
docs/relnotes/19.2.2.html
0 → 100644
docs/relnotes/19.2.3.html
0 → 100644
include/GL/gl_mangle.h
deleted
100644 → 0
This diff is collapsed.
include/GL/glx_mangle.h
deleted
100644 → 0