Commits on Source (24)
-
Samuel Pitoiset authored
When a fragment shader includes an input variable decorated with SampleId or SamplePosition, sample shading should be enabled because minSampleShadingFactor is expected to be 1.0. Cc: 19.2, 19.3 <mesa-stable@lists.freedesktop.org> Signed-off-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> (cherry picked from commit 86a5fbfd)
-
Samuel Pitoiset authored
This implementation is loosely based on ROCm. https://github.com/RadeonOpenCompute/ROCm-Device-Libs/blob/master/ockl/src/wfredscan.cl This fixes dEQP-VK.subgroups.arithmetic.*.subgroupexclusive* on GFX10. Fixes: 227c29a8 ("amd/common/gfx10: implement scan & reduce operations") Signed-off-by:
-
Kenneth Graunke authored
Many applications use multi-pass rendering and require their vertex shader position to be computed the same way each time. Optimizations may consider, say, fusing a multiply-add based on global usage of an expression in a shader. But a second shader with the same expression may have different code, causing that optimization to make the other choice the second time around. The correct solution is for applications to mark their VS outputs 'invariant', indicating they need multiple shaders to compute that output in the same manner. However, most applications fail to do so. So, we add a new driconf option - vs_position_always_invariant - which forces the gl_Position output in vertex shaders to be marked invariant. Fixes: 7025dbe7 ("nir: Skip emitting no-op movs from the builder.") Reviewed-by:
Eric Anholt <eric@anholt.net> Reviewed-by:
Ian Romanick <ian.d.romanick@intel.com> (cherry picked from commit 9b577f2a)
-
Kenneth Graunke authored
When drawing the main character in Shadow of Mordor, the game appears to draw Talion with one vertex shader, and the Wraith with another. If the compiler optimizes those in different ways which lead to slight imprecisions, then the resulting positions may not line up, leading to Z-fighting occurring as the game decides which of the two are in front. brw_nir_opt_peephole_ffma looks at usages of multiply adds across the entire shader, and may make different decisions between the two, leading to such imprecisions and Z-fighting. This started happening recently after a NIR change to eliminate unnecessary MOVs (7025dbe7), but that change simply exposed the existing problem. Improves performance on Skylake GT4e by 1.22945% +/- 0.398672% (n=3), likely due to the fixed rendering. Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/1985 Fixes: 7025dbe7 ("nir: Skip emitting no-op movs from the builder.") Reviewed-by:
-
Bas Nieuwenhuizen authored
They were out of sync. Besides syncing, lets ensure they never diverge again. Fixes: 8d2654a4 "radv: Support VK_EXT_inline_uniform_block." Reviewed-by:
-
Jonathan Gray authored
pthread_mutex_unlock() when unlocked is documented by posix as being undefined behaviour. On OpenBSD pthread_mutex_unlock() will call abort(3) if this happens. This occurs in amdgpu_winsys_create() after cb446dc0 winsys/amdgpu: Add amdgpu_screen_winsys Signed-off-by:
Jonathan Gray <jsg@jsg.id.au> Cc: 19.2 19.3 <mesa-stable@lists.freedesktop.org> Signed-off-by:
Marek Olšák <marek.olsak@amd.com> (cherry picked from commit 3fe3bde4)
-
Bas Nieuwenhuizen authored
Was totally broken ... Removed two if(point) {} because point is always non-NULL and we were counting on that already for counting, since we NULL our references to semaphores without active point earlier. Fixes: 4aa75bb3 "radv: Add wait-before-submit support for timelines." Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/2137 Reviewed-by: -
Boris Brezillon authored
BACK_LEFT attachment can be outdated when the user calls KHR_partial_update() (->lastStamp != ->texture_stamp), leading to a damage region update on the wrong pipe_resource object. Let's delay the ->set_damage_region() call until the attachments are updated when we're in that case. Reported-by:
Carsten Haitzler <raster@rasterman.com> Fixes: 492ffbed ("st/dri2: Implement DRI2bufferDamageExtension") Cc: <mesa-stable@lists.freedesktop.org> Signed-off-by:
Boris Brezillon <boris.brezillon@collabora.com> Reviewed-by:
-
Boris Brezillon authored
We must reset the damage info of our render targets here even though a damage reset normally happens when the DRI layer swaps buffers. That's because there can be implicit flushes the GL app is not aware of, and those might impact the damage region: if part of the damaged portion is drawn during those implicit flushes, you have to reload those areas before next draws are pushed, and since the driver can't easily know what's been modified by the draws it flushed, the easiest solution is to reload everything. Reported-by:
Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com> (cherry picked from commit c6e2096c)
-
Jonathan Gray authored
brw_performance_query_metrics.h was removed in 134e750e and brw_performance_query.h was removed in 8ae66679 remove reference to these files from Makefile.sources Signed-off-by:
Eric Engestrom <eric.engestrom@intel.com> (cherry picked from commit 34dda0ca)
-
Christian Gmeiner authored
ptiled is always NULL so the if statement is useless. CoverityID: 1415572 Fixes: b9627765 ("etnaviv: rework compatible render base") CC: <mesa-stable@lists.freedesktop.org> Reviewed-by:
Jonathan Marek <jonathan@marek.ca> Signed-off-by:
Christian Gmeiner <christian.gmeiner@gmail.com> (cherry picked from commit 1be22083)
-
Rhys Perry authored
Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/2156 Fixes: 93c8ebfa ('aco: Initial commit of independent AMD compiler') Signed-off-by:
Rhys Perry <pendingchaos02@gmail.com> Reviewed-by:
Daniel Schürmann <daniel@schuermann.dev> (cherry picked from commit ff70ccad)
-
Rhys Perry authored
Fixes: 93c8ebfa ('aco: Initial commit of independent AMD compiler') Signed-off-by:
-
Rhys Perry authored
LLVM and the proprietary compiler seem to do this Fixes: b01847bd ("aco/gfx10: Fix mitigation of VMEMtoScalarWriteHazard.") Signed-off-by:
-
Daniel Schürmann authored
Fixes: 93c8ebfa 'aco: Initial commit of independent AMD compiler' Reviewed-by:
-
Rhys Perry authored
Fixes: 13ab63bb ('radv: Implement VK_EXT_buffer_device_address.') Signed-off-by:
-
Rhys Perry authored
Some backends require that there are no array varyings. If there were no arrays in the input shader, the pass shouldn't have to create new ones. Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/2103 Closes: https://gitlab.freedesktop.org/mesa/mesa/issues/2167 Fixes: bcd14756 ('nir/lower_io_to_vector: add flat mode') Signed-off-by:
Connor Abbott <cwabbott0@gmail.com> (cherry picked from commit 5404b7aa)
-
Jordan Justen authoredReworks: * Adjust comment to list the state packets that curro found to be affected. Fixes: 8125d796 ("intel/dev: Add preliminary device info for Tigerlake") Cc: 19.3 <mesa-stable@lists.freedesktop.org> Signed-off-by:
Jordan Justen <jordan.l.justen@intel.com> Acked-by:
Kenneth Graunke <kenneth@whitecape.org> Reviewed-by:
Francisco Jerez <currojerez@riseup.net> (cherry picked from commit e277009d)
-
Faith Ekstrand authored
gl_Viewport is also in the VUE header so we need to whack the read offset to 0 and emit a default (no overrides) SBE_SWIZ entry in that case as well. Cc: mesa-stable@lists.freedesktop.org Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> (cherry picked from commit b1f37688)
-
Daniel Schürmann authored
Fixes: 3a20ef4a 'aco: refactor value numbering' Reviewed-by:
-
Dylan Baker authored
-
Timo Aaltonen authored
-
Timo Aaltonen authored
-
Timo Aaltonen authored
