Commits on Source (98)
-
Juan A. Suarez Romero authored
Signed-off-by:Juan A. Suarez Romero <jasuarez@igalia.com>
-
Lionel Landwerlin authored
Begin/Reset of command buffer both reset the content of the command buffer. Don't forget to wipe them on Begin. Signed-off-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> Fixes: 4438188f ("vulkan/overlay: record stats in command buffers and accumulate on exec/submit") Acked-by:
Eric Engestrom <eric.engestrom@intel.com> Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> (cherry picked from commit 8f0f727f)
-
Bas Nieuwenhuizen authored
alignment=0 does weird things with align64. CC: <mesa-stable@lists.freedesktop.org> Reviewed-by:
Dave Airlie <airlied@redhat.com> (cherry picked from commit e46b41b3)
-
Chia-I Wu authored
compatibleHandleTypes must include the queried handle type. Signed-off-by:
Chia-I Wu <olvaffe@gmail.com> Cc: <mesa-stable@lists.freedesktop.org> Reviewed-by:
-
Chia-I Wu authored
It was reported as unsupported previously. It should be importable and is compatible with itself. Signed-off-by:
-
Ian Romanick authored
Previously, an instruction like mul(8) vgrf29.xy:F, vgrf25.yxxx:F, [-1F, 1F, 0F, 0F] would get rewritten as mul(8) vgrf0.yz:F, vgrf25.yyxx:F, [-1F, 1F, 0F, 0F] The latter does not produce the correct result. The VF immediate in the second should be either [-1F, -1F, 1F, 1F] or [0F, -1F, 1F, 0F]. This commit produces the former. Fixes: 1ee1d8ab ("i965/vec4: Reswizzle sources when necessary.") Reviewed-by:
Matt Turner <mattst88@gmail.com> (cherry picked from commit 47c2aa5b)
-
Ian Romanick authored
Each tests has a comment with the expected before and after NIR. The tests don't actually check this. The tests only check whether or not the optimization pass reported progress. I couldn't think of a robust, future-proof way to check the before and after code. Reviewed-by:
-
Ian Romanick authored
This is important because, for example nir_op_fne has dest.dest.ssa.bit_size == 1, but the source operands can be 16-, 32-, or 64-bits. Fixing this helps partial redundancy elimination for compares in a few more shaders. v2: Add unit tests for nir_opt_comparison_pre that are fixed by this commit. All Intel platforms had similar results. total instructions in shared programs: 17179408 -> 17179081 (<.01%) instructions in affected programs: 43958 -> 43631 (-0.74%) helped: 118 HURT: 2 helped stats (abs) min: 1 max: 5 x̄: 2.87 x̃: 2 helped stats (rel) min: 0.06% max: 4.12% x̄: 1.19% x̃: 0.81% HURT stats (abs) min: 6 max: 6 x̄: 6.00 x̃: 6 HURT stats (rel) min: 5.83% max: 6.06% x̄: 5.94% x̃: 5.94% 95% mean confidence interval for instructions value: -3.08 -2.37 95% mean confidence interval for instructions %-change: -1.30% -0.85% Instructions are helped. total cycles in shared programs: 360959066 -> 360942386 (<.01%) cycles in affected programs: 774274 -> 757594 (-2.15%) helped: 111 HURT: 4 helped stats (abs) min: 1 max: 1591 x̄: 169.49 x̃: 36 helped stats (rel) min: <.01% max: 24.43% x̄: 8.86% x̃: 2.24% HURT stats (abs) min: 1 max: 2068 x̄: 533.25 x̃: 32 HURT stats (rel) min: 0.02% max: 5.10% x̄: 3.06% x̃: 3.56% 95% mean confidence interval for cycles value: -200.61 -89.47 95% mean confidence interval for cycles %-change: -10.32% -6.58% Cycles are helped. Reviewed-by: Jason Ekstrand <jason@jlekstrand.net> [v1] Suggested-by:
Jason Ekstrand <jason@jlekstrand.net> Reviewed-by:
-
Ian Romanick authored
Set the absolute minimum possible GLSL version. API_OPENGL_CORE can mean an OpenGL 3.0 forward-compatible context, so that implies a minimum possible version of 1.30. Otherwise, the minimum possible version 1.20. Since Mesa unconditionally advertises GL_ARB_shading_language_100 and GL_ARB_shader_objects, every driver has GLSL 1.20... even if they don't advertise any extensions to enable any shader stages (e.g., GL_ARB_vertex_shader). Converts about 2,500 piglit tests from crash to skip on NV18. Reviewed-by:
Ilia Mirkin <imirkin@alum.mit.edu> Reviewed-by:
Emil Velikov <emil.velikov@collabora.com> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109524 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110955 Cc: mesa-stable@lists.freedesktop.org (cherry picked from commit 0349bc3c)
-
Lionel Landwerlin authored
It is legal to call vkFreeCommandBuffers() on NULL command buffers. This fix requires eb41ce1b ("util/hash_table: Properly handle the NULL key in hash_table_u64"). Signed-off-by:
-
Marek Olšák authored
Bindless textures can update descriptors with WRITE_DATA. Cc: 19.1 <mesa-stable@lists.freedesktop.org> Acked-by:
Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer@amd.com> Acked-by:
-
Connor Abbott authored
This is simple now, but we're going to be adding a few more conditions to this later. Reviewed-by:
Timothy Arceri <tarceri@itsqueeze.com> (cherry picked from commit a1c73792)
-
Faith Ekstrand authored
Reviewed-by:
-
Faith Ekstrand authored
One issue was that the original version didn't check that swizzles matched when comparing ALU instructions so it could end up matching very different instructions. Using the nir_instrs_equal function from nir_instr_set.c which we use for CSE should be much more reliable. Another was that the loop assumes it will only run two iterations which may not be true. If there's something which guarantees that this case only happens for phis after ifs, it wasn't documented. Fixes: 9e6b39e1 "nir: detect more induction variables" Reviewed-by:
-
Faith Ekstrand authored
Reviewed-by:
-
Faith Ekstrand authored
The current code assumes everything is 32-bit which is very likely true but not guaranteed by any means. Instead, use nir_eval_const_opcode to do the calculations in a bit-size-agnostic way. We also use the new constant constructors to build the correct size constants. Fixes: 6772a17a "nir: Add a loop analysis pass" Reviewed-by:
-
Faith Ekstrand authored
None of the current code knows what to do with swizzles. Take the safe option for now and bail if we see one. This does have a small shader-db impact but it is at least safe. Shader-db results on Kaby Lake: total loops in shared programs: 4364 -> 4388 (0.55%) loops in affected programs: 5 -> 29 (480.00%) helped: 5 HURT: 29 Shader-db results on Haswell: total loops in shared programs: 4373 -> 4370 (-0.07%) loops in affected programs: 5 -> 2 (-60.00%) helped: 5 HURT: 2 Fixes: 6772a17a "nir: Add a loop analysis pass" Reviewed-by: -
Faith Ekstrand authored
This is the MOCS setting used for the A64 stateless messages which we sometimes use for SSBO operations. Fixes: 48ed2a7b "anv: Implement VK_EXT_buffer_device_address" Fixes: 79fb0d27 "anv: Implement SSBOs bindings with GPU addr..." Reviewed-by:
Chad Versace <chadversary@chromium.org> Reviewed-by:
-
Timothy Arceri authored
Without this the restored program will fail the pipeline validation checks when we attempt to use an SSO program. Fixes: c20fd744 ("mesa: Add Mesa ARB_get_program_binary helper functions") Reviewed-by:
Jordan Justen <jordan.l.justen@intel.com> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111010 (cherry picked from commit 3043908c)
-
Caio Oliveira authored
When using softpin, the first allocation was not calculating the padding and offset correctly for the case the first allocation needed to grow. We were missing initialize the state.end right after expanding the pool for the first time. This is not a problem for non-softpin since there we don't use leftover padding so the ends would re-arrange incrementally. This fixes running dEQP-VK.ssbo.phys.layout.random.16bit.scalar.13 in SKL -- the test uses a shader larger than the initial size for the instruction pool. Fixes: dfc9ab2c "anv/allocator: Add padding information." Reviewed-by:
Rafael Antognolli <rafael.antognolli@intel.com> Reviewed-by:
-
Emma Anholt authored
Cherry-picks a0d4d7fe upstream The TTN path needs access to the screen to make the right decisions about lowering, but we didn't have pctx->screen set up at fdN_prog_init time. Reviewed-by:
Rob Clark <robdclark@gmail.com> Tested-by:
Eduardo Lima Mitev <elima@igalia.com> Signed-off-by:
John Stultz <john.stultz@linaro.org>
-
Vinson Lee authored
Fix this build error on Ubuntu 18.04. /usr/bin/ld: src/util/libmesa_util.a(u_cpu_detect.c.o): undefined reference to symbol 'pthread_once@@GLIBC_2.2.5' Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110663 Suggested-by: Eric Engestrom <eric@@engestrom.ch> Signed-off-by:
Vinson Lee <vlee@freedesktop.org> Reviewed-by:
Eric Anholt <eric@anholt.net> Acked-by:
Eric Engestrom <eric@engestrom.ch> (cherry picked from commit 730ceedd)
-
Lionel Landwerlin authored
anv_render_pass_compile() turns an unused attachment into a NULL depth_stencil_attachment pointer so check that pointer before accessing it. Found with updates to existing CTS tests. Signed-off-by:
-
Bas Nieuwenhuizen authored
Specifically needed for nativewindow for some VK_EXT_external_memory_android_hardware_buffers functions, where we call into some AHardwareBuffer functions. The legacy Android ext did not have us call into any Android function at all and hence it was not noticed. Fixes: 755c633b "anv: Fix vulkan build in meson." Reviewed-by:
-
Faith Ekstrand authored
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111071 Fixes: 2a74296f "nir: add opt_if_loop_terminator()" Reviewed-by:
-
Faith Ekstrand authored
We need this when doing full software 64-bit emulation. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110309 Fixes: cbad201c "nir/algebraic: Add missing 64-bit extract_[iu]8..." Reviewed-by:
Kenneth Graunke <kenneth@whitecape.org> Reviewed-by:
Ian Romanick <ian.d.romanick@intel.com> (cherry picked from commit 0ba508d7)
-
Caio Oliveira authored
Use alignment to calculate the stride associated with the pointer types. That stride is used when the pointers are casted to arrays. Note that size alone is not sufficient, e.g. struct { vec2 a; vec1 b; } will have element an element size of 12 bytes, but the stride needs to be 16 bytes to respect the 8 byte alignment. Fixes: 050eb638 "spirv: Ignore ArrayStride in OpPtrAccessChain for Workgroup" Reviewed-by: -
Sergii Romantsov authored
Meta of CopyPixel generates a buffer object but does not free it on cleanup. Fixes: 37d11b13 (meta: Don't pollute the buffer object namespace in _mesa_meta_setup_vertex_objects) Signed-off-by:
Sergii Romantsov <sergii.romantsov@globallogic.com> Reviewed-by:
-
Faith Ekstrand authored
In 6ce85928 we started looking at the dynamic stencil state and disabling stencil writes when the stencil mask is zero. Unfortunately, we never updated the PMA fix code accordingly so 3DSTATE_WM_DEPTH_STENCIL and the PMA fix were getting out-of-sync causing hangs. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109203 Fixes: 6ce85928 "anv: Disable stencil writes when both write..." Reviewed-by:
-
Yevhenii Kolesnikov authored
ctx->Unpack.BufferObj wasn't unreferenced. Fixes: d492e7b0 (meta: Fix invalid PBO access from DrawPixels when trying to just alloc.) CC: Eric Anholt <eric@anholt.net> Signed-off-by:
Yevhenii Kolesnikov <yevhenii.kolesnikov@globallogic.com> Reviewed-by:
-
Faith Ekstrand authored
Sources of phi instructions act as if they occur at the very end of the predecessor block not the block in which the phi lives. In order to handle them correctly, we have to skip phi sources on the normal instruction walk and handle them as a separate walk over the successor phis. While registers in phi instructions is a bit of an oddity it can happen when we temporarily go out-of-SSA for control-flow manipulations. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111075 Cc: mesa-stable@lists.freedesktop.org Reviewed-by:
Caio Marcelo de Oliveira Filho <caio.oliveira@intel.com> (cherry picked from commit 6fb685fe)
-
Gert Wollny authored
Thanks to Eric Engestrom for pointing out that there was something wrong with that function. Fixes: 724a7350 softpipe: Prepare handling explicit gradients Signed-off-by:
Gert Wollny <gert.wollny@collabora.com> Reviewed-by:
-
Faith Ekstrand authored
This commit reworks both get_induction_and_limit_vars() and try_find_trip_count_vars_in_iand to return true on success and not modify their output parameters on failure. This makes their callers significantly simpler. Reviewed-by:
-
Faith Ekstrand authored
There are various cases in which we want to chase SSA values through ALU ops ranging from hand-written optimizations to back-end translation code. In all these cases, it can be very tricky to do properly because of swizzles. This set of helpers lets you easily work with a single component of an SSA def and chase through ALU ops safely. Reviewed-by:
-
Faith Ekstrand authored
This commit re-plumbs all of nir_loop_analyze to use nir_ssa_scalar for all intermediate values so that we can properly handle swizzles. Even though if conditions are required to be scalars, they may still consume swizzles so you could have ((a.yzw < b.zzx).xz && c.xx).y == 0 as your loop termination condition. The old code would just bail the moment it saw its first non-zero swizzle but we can now properly chase the scalar from the if condition to all the way to a, b, and c. Shader-db results on Kaby Lake: total loops in shared programs: 4388 -> 4364 (-0.55%) loops in affected programs: 29 -> 5 (-82.76%) helped: 29 HURT: 5 Shader-db results on Haswell: total loops in shared programs: 4370 -> 4373 (0.07%) loops in affected programs: 2 -> 5 (150.00%) helped: 2 HURT: 5 Reviewed-by: -
Lionel Landwerlin authored
With the following chain of events : vkQueuePresent() <- Surface resize vkQueuePresent() We should be able to report SUBOPTIMAL or OUT_OF_DATE on the second vkQueuePresent() call. Currently we only look at X11 events in the vkAcquireNextImage() path so we're not able to report this. This change checks the queue of events and process any available ones to update the swapchain status. v2: Be consistent about reporting the current error state of the swapchain (Jason) Signed-off-by: -
Lionel Landwerlin authored
Spec says : "timestampComputeAndGraphics specifies support for timestamps on all graphics and compute queues. If this limit is set to VK_TRUE, all queues that advertise the VK_QUEUE_GRAPHICS_BIT or VK_QUEUE_COMPUTE_BIT in the VkQueueFamilyProperties::queueFlags support VkQueueFamilyProperties::timestampValidBits of at least 36." On gen7+ this should be true (we only have 32bits of timestamp on gen6 and below). Signed-off-by:Timothy Strelchun <timothy.strelchun@intel.com> Reviewed-by:
-
Bas Nieuwenhuizen authored
After reset, if valid does not contain the relevant bit the descriptor can be != NULL but still not be valid. CC: <mesa-stable@lists.freedesktop.org> Reviewed-by:
-
Lepton Wu authored
The set of meta data was removed by commit 80834640. It broke lots of dEQP tests when running with pbuffer surface type. Fixes: 80834640 ("virgl: remove dead code") Signed-off-by:
Lepton Wu <lepton@chromium.org> Reviewed-by:
Erik Faye-Lund <erik.faye-lund@collabora.com> Reviewed-by:
-
Lionel Landwerlin authored
anv_format is supposed to have a pointer back to the associated VkFormat, we were missed this for depth/stencil formats. This doesn't fix anything afaict, but will be needed for future changes. Signed-off-by:
-
Samuel Iglesias Gonsálvez authored
There are tests in CTS for alpha to coverage without a color attachment that are failing. This happens because we remove the shader color outputs when we don't have a valid color attachment for them, but when alpha to coverage is enabled we still want to preserve the the output at location 0 since we need the alpha component. In that case we will also need to create a null render target for RT 0. v2: - We already create a null rt when we don't have any, so reuse that for this case (Jason) - Simplify the code a bit (Iago) v3: - Take alpha to coverage from the key and don't tie this to depth-only rendering only, we want the same behavior if we have multiple render targets but the one at location 0 is not used. (Jason). - Rewrite commit message (Iago) v4: - Make sure we take into account the array length of the shader outputs, which we were no handling correctly either and make sure we also create null render targets for any invalid array entries too. v5: - Simplify removal of unused outputs by using rt_used[] so we don't have to special case alpha to coverage there too. Fixes the following CTS tests: dEQP-VK.pipeline.multisample.alpha_to_coverage_no_color_attachment.* Signed-off-by:Samuel Iglesias Gonsálvez <siglesias@igalia.com> Signed-off-by:
Iago Toral Quiroga <itoral@igalia.com> Reviewed-by:
-
Samuel Pitoiset authored
Found by inspection. Cc: <mesa-stable@lists.freedesktop.org> Signed-off-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by:
-
Dave Airlie authored
Enabling tracing, and then having a vmfault, can leads to a segfault before we print out the traces, as if a meta shader is executing and we don't have the NIR for it. Just pass the stage and give back a default. Fixes: 9b9ccee4 ("radv: take LDS into account for compute shader occupancy stats") Reviewed-by:
-
Juan A. Suarez Romero authored
Signed-off-by: -
Juan A. Suarez Romero authored
Signed-off-by: -
Juan A. Suarez Romero authored
Signed-off-by: -
Samuel Pitoiset authored
depth_stencil_attachment and/or ds_resolve attachment can be NULL. This fixes crashes with dEQP-VK.renderpass.suballocation.unused_clear_attachments.* Cc: 19.1 <mesa-stable@lists.freedesktop.org> Signed-off-by:
-
Nataraj Deshpande authored
color_buffers[] is currently hard coded to 3 for android which fails in droid_window_dequeue_buffer when ANativeWindow creates color_buffers >3 while querying buffer age during dEQP partial_update tests on chromeOS. The patch removes static color_buffers[], queries for MIN_UNDEQUEUED_BUFFERS, sets native window buffer count and allocates the correct number of color_buffers as per android. Fixes dEQP-EGL.functional.partial_update* tests on chromebooks with enabling EGL_KHR_partial_update. v2: update comment instead of removing (Eric Engestrom) v3: change static array to dynamic allocated color_buffers querying MIN_UNDEQUEUED_BUFFERS (Chia-I Wu olv@chromium.org) Fixes: 2acc69da "EGL/Android: Add EGL_EXT_buffer_age extension" Signed-off-by:Nataraj Deshpande <nataraj.deshpande@intel.com> Acked-by:
-
Faith Ekstrand authored
Normally, we haven't worried too much about stack sizes as Linux tends to be fairly friendly towards large stacks. However, when running DXVK apps under wine, we're suddenly subject to Windows' more stringent stack limitations and can run out of space more easily. In particular, some of the shaders in Elite Dangerous: Horizons have quite a few registers and the arrays in split_virtual_grfs are large enough to blow a 1 MiB stack leading to crashes during shader compilation. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108662 Reviewed-by:
-
Kenneth Graunke authored
pbuffers are internally single-buffered. Marek fixed DrawBuffers to handle this case, but we need to fix ReadBuffers too. Otherwise, pretty much every conformance test fails because glReadPixels breaks. v2: Refactor the switch into a helper (suggested by Eric Anholt) Fixes: 35294f2e ("mesa: fix pbuffers because internally they are front buffers") Acked-by: Eric Engestrom <eric.engestrom@intel.com> (v1) Reviewed-by:
-
Kenneth Graunke authored
pbuffer configs cause a million of these warnings to trigger, but when using pixmaps or buffers, there is only one surface, so this warning doesn't make much sense. Retain it for window surfaces for now. Fixes: dacb11a5 ("egl: Add a 565 pbuffer-only EGL config under X11.") Reviewed-by:
-
Kenneth Graunke authored
In commit dacb11a5, Eric found the first matching 565 pbuffer config, and stopped. Our double-buffered configs come first in the list, so we added that, making a pbuffer-only config that claimed to be double buffered. This doesn't make sense, since pixmaps/pbuffers are fundamentally not double buffered. When using that config, every call to eglCreatePbufferSurface would fail with EGL_BAD_MATCH. The call chain looks like this: - eglCreatePbufferSurface - dri3_create_pbuffer_surface - dri3_create_surface - dri2_get_dri_config which eventually does: const bool double_buffer = surface_type == EGL_WINDOW_BIT; and then fails to find a matching config, because it ends up looking for a single-buffered config - and there aren't any. To fix this, make the 565 pbuffer config single-buffered. This fixes at least 51 dEQP-EGL.* tests. Fixes: dacb11a5 ("egl: Add a 565 pbuffer-only EGL config under X11.") Reviewed-by:
-
Kenneth Graunke authored
Glamor in xorg-server 1.20 cannot expose 16bpp pixmaps when running in the usual 24bpp mode. This meant our 565 pbuffer configs would ultimately fail to create a backing pixmap, leading to crashes. To hack around this, make a 16bpp pixmap and try and export it. If it works, expose the configs. Otherwise, just skip them. This also disables them on DRI2. These configs were only added to pass conformance requirements, and I doubt anybody cares about testing out 565 pbuffer visuals on DRI2-only drivers. v2: Don't leak the fds (caught by Eric Anholt) v3: Don't free(fds), it's not malloc'd Fixes: dacb11a5 ("egl: Add a 565 pbuffer-only EGL config under X11.") Reviewed-by:
-
Dave Airlie authored
The comment even justifies the wrongness wrongly. We should be translating to pipe values properly here or else fragment maps to tess ctrl. Fixes: 3d7611e9 ("st/nir: use NIR for asm programs") Reviewed-by:
Marek Olšák <marek.olsak@amd.com> (cherry picked from commit 365f2470)
-
Eric Engestrom authored
Fixes: 14531d67 ("nir: make nir_const_value scalar") Signed-off-by:
Karol Herbst <kherbst@redhat.com> (cherry picked from commit 3acc4278)
-
Lionel Landwerlin authored
This doesn't fix any bug at the moment because the next statement is 'true' which happens to be APIMODE_D3D, but if that changes it could. The fixes tags is as far I could go but the error predates it (2016 is probably far enough). Signed-off-by:
-
Dylan Baker authored
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111016 Fixes: a47c525f ("meson: build glx") Acked-by:
-
Eric Engestrom authored
Fixes: b8e077da ("util: no-op __builtin_types_compatible_p() for non-GCC compilers") Signed-off-by:
-
Eric Engestrom authored
Fixes: ed23335a ("gallium: use enums in p_shader_tokens.h (v2)") Signed-off-by:
-
Andrii Simiklit authored
warning: struct 'fs_reg' was previously declared as a class Fixes: e64be391 ("intel/compiler: generalize the combine constants pass") Reviewed-by:
Andrii Simiklit <andrii.simiklit@globallogic.com> (cherry picked from commit fa2fc68d)
-
Yevhenii Kolesnikov authored
Add freeing of SubroutineIndexes to the _mesa_free_shader_state. Fixes: 4566aaaa ("mesa/subroutines: start adding per-context subroutine index support (v1.1)") Signed-off-by:
-
Nicolas Dufresne authored
This fixes eglExportDMABUFImageQueryMESA() so it will report the modififers of the underlying image. Without this information, re-importing will likely be broken as it is rare these days that no modifiers are used. Reviewed-by:
Daniel Stone <daniels@collabora.com> Fixes: 8f7338f2 ("egl: add initial EGL_MESA_image_dma_buf_export v2.4") (cherry picked from commit 08f1cefe)
-
Daniel Schürmann authored
Semantically, the memory barrier has to come first to wait for the completion of pending memory requests. Afterwards, the workgroups can be synchronized. Reviewed-by:
-
Arcady Goldmints-Orlov authored
Report VK_EXTERNAL_MEMORY_HANDLE_TYPE_HOST_ALLOCATION_BIT_EXT as supported for images. It was being shown supported for buffers, but not images. Fixes: 69cc6272 ("anv: Implement VK_EXT_external_memory_host") Reviewed-by:
-
Bas Nieuwenhuizen authored
Without correct size, radeonsi assumes the metadata is incorrect, which can and will cause issues. Since the metadata is really incorrect without the size, let us fix that. Fixes: e43cc3e3 "radv/gfx9: handle GFX9 opaque metadata" Reviewed-by:
-
Faith Ekstrand authored
It's totally implementable, it's just that the plumbing is a bit different and we never hooked it up. Don't advertise a broken feature. Fixes: 36ee2fd6 "anv: Implement the basic form of VK_EXT_transform_feedback" (cherry picked from commit 295e5a17) [Juan A. Suarez: resolve trivial conflicts] Signed-off-by:
-
Mark Menzynski authored
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111007 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111167 Signed-off-by:
Mark Menzynski <mmenzyns@redhat.com> Reviewed-by:
Tobias <Klausmann<tobias.klausmann@freenet.de> (cherry picked from commit 7493fbf0)
-
Lionel Landwerlin authored
SPIRV added the ability to access variables and have expressions non dynamically uniform and because spirv_to_nir generates deref instructions, we'll need to have that access there. Signed-off-by:
-
Boyuan Zhang authored
MaxPicOrderCntLsb should be at least 16 according to the spec, therefore add minimum value check. Also use poc value passed from st instead of calculation in slice header encoding. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110673 Cc: mesa-stable@lists.freedesktop.org V2: Fix typo V3: Use MAX2 macro instead of coding. Also MaxPicOrderCntLsb should be power of 2 according to spec. Signed-off-by:
Boyuan Zhang <boyuan.zhang@amd.com> Acked-by:
Leo Liu <leo.liu@amd.com> (cherry picked from commit 77cf700f)
-
Boyuan Zhang authored
MaxPicOrderCntLsb should be at least 16 according to the spec, therefore add minimum value check. Also use poc value passed from st instead of calculation in slice header encoding. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110673 Cc: mesa-stable@lists.freedesktop.org V2: Fix typo V3: Use MAX2 macro instead of coding. Also MaxPicOrderCntLsb should be power of 2 according to spec. Signed-off-by:
-
Boyuan Zhang authored
Set cu_qp_delta_enable_flag on when rate control is enabled, and set it off when rate control is disabled (e.g. constant qp). Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110673 Cc: mesa-stable@lists.freedesktop.org V2: fix typo and add bugzilla info Signed-off-by:
-
Boyuan Zhang authored
Set cu_qp_delta_enable_flag on when rate control is enabled, and set it off when rate control is disabled (e.g. constant qp). Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110673 Cc: mesa-stable@lists.freedesktop.org V2: fix typo and add bugzilla info Signed-off-by:
-
Ilia Mirkin authored
This caused nouveau's function handling logic to think that the MAIN function was due to receive external parameters, and cascaded some failures after that. Instead avoid having the undefined components in the first place. Fixes: f6ac0b5d (gallium/auxiliary/vl: Add compute shader to support video compositor render) Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111213 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111217 Signed-off-by:
-
Ilia Mirkin authored
Apparently vl (or vdpau) wants to pass that in now. Handle it. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111213 Signed-off-by:
-
Ilia Mirkin authored
Previously the code only handled it for positions 1 and up (as would be for UBO's in GL). It's not a lot of trouble to handle this, and vl or vdpau want this. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111213 Signed-off-by:
-
Ilia Mirkin authored
This can happen if it's e.g. a uniform or a function argument. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111217 Signed-off-by:
-
Caio Oliveira authored
The key reason for that mechanism is gone: all the extra optional data that could be in the anv_push_constants was moved elsewhere. At this point, just put anv_push_constants directly in anv_cmd_state (part of anv_cmd_buffer). v2: Remove a NULL check we don't need anymore in anv_cmd_buffer_push_constants(). (Lionel) Fix size we consider for valid push params. (Lionel) Reviewed-by: -
Connor Abbott authored
In the next commit, we'll properly handle access qualifiers on struct members by propagating them to load/store instructions, but these instructions had no way to specify the qualifier. Reviewed-by:
-
Lionel Landwerlin authored
This refactor allows for common code to apply decoration on all ssa/pointer values. In particular this will allow to propagage access qualifiers. Signed-off-by:
-
Lionel Landwerlin authored
Not only variables can be flagged as NonUniformEXT but also expressions. We're currently ignoring it in an expression such as : imageLoad(data[nonuniformEXT(rIndex)], 0) The associated SPIRV : OpDecorate %69 NonUniformEXT ... %69 = OpLoad %61 %68 This changes propagates access qualifiers through ssa & pointers so that when it hits a OpLoad/OpStore style instructions, qualifiers are not forgotten. Fixes failure the following tests : dEQP-VK.descriptor_indexing.* Signed-off-by:
-
Rhys Perry authored
Seems to fix some hair artifacts in Max Payne 3: https://github.com/daniel-schuermann/mesa/issues/76 Signed-off-by:
Rhys Perry <pendingchaos02@gmail.com> Fixes: f4e499ec ('radv: add initial non-conformant radv vulkan driver') Reviewed-by:
-
Faith Ekstrand authored
On Haswell, the format works but it doesn't properly do an sRGB decode. It appears to act identically to R8G8B8_UNORM. Only Vulkan uses this format so this only affects Vulkan on HSW. Cc: mesa-stable@lists.freedesktop.org Reviewed-by:
-
Faith Ekstrand authored
Cc: mesa-stable@lists.freedesktop.org (cherry picked from commit 99d04a5b)
-
Bas Nieuwenhuizen authored
Fixes: b5e04e92 "radv: Support allocating variable size descriptor sets." Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111019 Reviewed-by:
-
Emma Anholt authored
There is a single ir3_compiler in the screen, and each context may be compiling ir3 shaders, which call ir3_create. ralloc doesn't do any locking on its own, so eventually you can end up racing to break ralloc's linked lists. We really don't want struct ir3 to live as long as the compiler (maybe struct ir3_shader's lifetime, if anything), so you'd better be freeing it anyway. Fixes: 8fe20762 ("freedreno/ir3: convert over to ralloc") Reviewed-by:
-
Andrii Simiklit authored
This could help somebody to be noticed about meson issue: https://github.com/mesonbuild/meson/pull/3274 as result NDEBUG won't be defined even if b_ndebug is true and buildtype is release. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109791 Cc: mesa-stable@lists.freedesktop.org Acked-by:
-
Andres Rodriguez authored
When vkGetQueryPoolResults() is called with VK_QUERY_RESULT_WAIT_BIT set, the driver is supposed to wait for the query to become available before returning. Currently, radv returns once the query is indeed ready, but it returns VK_NOT_READY. It also fails to populate the results. The problem is a missing volatile in the secondary check for query availability. This patch removes the secondary check altogether since it is redundant with the preceding loop. This bug was found with an unreleased version of SteamVR. Reviewed-by:
-
Lionel Landwerlin authored
We can have a access flag already set here so just augment the existing ones. Signed-off-by:
-
Bas Nieuwenhuizen authored
Set all the handles to VK_NULL_HANDLE: "If the creation of any of those descriptor sets fails, then the implementation must destroy all successfully created descriptor set objects from this command, set all entries of the pDescriptorSets array to VK_NULL_HANDLE and return the error." (Vulkan 1.1.117 Spec, section 13.2) CC: <mesa-stable@lists.freedesktop.org> Reviewed-by:
-
Eric Engestrom authored
Originally introduced in c7f36574 ("darwin: Suppress type conversion warnings for GLhandleARB") to fix Bugzilla #66346 [1], this workaround was never ported to Scons or Meson. [1] https://bugs.freedesktop.org/66346 Cc: mesa-stable@lists.freedesktop.org Signed-off-by:
Jose Fonseca <jfonseca@vmware.com> (cherry picked from commit bf8b5de6)
-
Faith Ekstrand authored
The issue here was discovered by a set of Vulkan CTS tests: dEQP-VK.glsl.derivate.*.dynamic_* These tests use ballot ops to construct a branch condition that takes the same path for each 2x2 quad but may not be uniform across the whole subgroup. They then tests that derivatives work and give the correct value even when executed inside such a branch. Because the derivative isn't executed in uniform control-flow and the values coming into the derivative aren't smooth (or worse, linear), they nicely catch bugs that aren't uncovered by simpler derivative tests. Unfortunately, these tests require Vulkan and the equivalent GL test would require the GL_ARB_shader_ballot extension which requires int64. Because the requirements for these tests are so high, it's not easy to test on older hardware and the bug is only proven to exist on gen7; gen4-6 are a conjecture. Cc: mesa-stable@lists.freedesktop.org Reviewed-by: -
Faith Ekstrand authored
This fixes dEQP-VK.subgroups.quad.compute.subgroupquadswaphorizontal_* on all gen7 platforms. Cc: mesa-stable@lists.freedesktop.org Reviewed-by:
-
Emil Velikov authored
Currently, if we error out before gbm_dri is set (say due to a different name of the backing GBM implementation, or otherwise) the tear down will trigger a NULL ptr deref and crash out. Move the gbm_dri initialization as early as possible. v2: Drop check in dri2_teardowm_drm (Eric) Reported-by:
Christian Gmeiner <christian.gmeiner@gmail.com> Cc: Christian Gmeiner <christian.gmeiner@gmail.com> Cc: mesa-stable@lists.freedesktop.org Signed-off-by:
-
Eric Engestrom authored
These were left after a rebase and happen to make NIR_INTRINSIC_SWIZZLE_MASK == NIR_INTRINSIC_SRC_ACCESS, which is how it was noticed. Fixes: 6f20643b ("nir: Allow qualifiers on copy_deref and image instructions") Cc: Connor Abbott <cwabbott0@gmail.com> Signed-off-by:
-
Francisco Jerez authored
Specifically the optimization of a conditional BREAK + WHILE sequence into a conditional WHILE seems pretty broken. The list of successors of "earlier_block" (where the conditional BREAK was found) is emptied and then re-created with the same edges for no apparent reason. On top of that the list of predecessors of the block immediately after the WHILE loop is emptied, but only one of the original edges will be added back, which means that potentially several blocks that still have it on their list of successors won't be on its list of predecessors anymore, causing all sorts of hilarity due to the inconsistency in the control flow graph. The solution is to remove the code that's removing valid edges from the CFG. cfg_t::remove_block() will already clean up after itself. The assert in bblock_t::combine_with() also needs to be removed since we will be merging a block with multiple children into the first one of them. Found the issue on a hardware enabling branch originally, but apparently somebody reproduced the same problem independently on master in the meantime. Fixes: d13bcdb3 ("i965/fs: Extend predicated break pass to predicate WHILE.") Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=111009 Cc: jiradet.jd@gmail.com Cc: Sergii Romantsov <sergii.romantsov@globallogic.com> Cc: Matt Turner <mattst88@gmail.com> Cc: mesa-stable@lists.freedesktop.org Tested-by:
Paul Chelombitko <qamonstergl@gmail.com> Reviewed-by:
-
Tapani Pälli authored
This fixes problems spotted within vk-gl-cts. Problem is that the builtin functions refer to types and we should not release types before builtins are released. Fixes: 624789e3 ("compiler/glsl: handle case where we have multiple users for types") Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=110796 Signed-off-by:
Tapani Pälli <tapani.palli@intel.com> Acked-by:
-
Juan A. Suarez Romero authored
Signed-off-by: -
Juan A. Suarez Romero authored
Signed-off-by:
docs/relnotes/19.1.3.html
0 → 100644
docs/relnotes/19.1.4.html
0 → 100644