Don't assert on void function parameters. (#2047)
The type manager in spirv-opt currently asserts if a function parameter has type void. It is not exactly clear from the spec that this is disallowed, even if it probably will be disallowed. In either case, asserts should be used to verify assumptions that will actually make a difference to the code. As far as the optimizer is concerned, a void parameter does not matter. I don't see the point of the assert. I'll just remove it and let the validator decide whether to accept it or not. No test was added because it is not clear that it is legal, and should not force us to accept it in the future unless the spec make it clear that it is legal. Fixes crbug.com/903088.
Loading
Please register or sign in to comment