Commits on Source 3

  • Eli Schwartz's avatar
    debian/local/xvfb-run: Fix use of deprecated tempfile utility · fdabbaca
    Eli Schwartz authored and Julien Cristau's avatar Julien Cristau committed
    tempfile is pretty well guaranteed to not be available on other
    distributions, and continuing to use it over mktemp just encourages bad
    scripting practices.
    
    It was unnecessary here anyway as the parent directory was already
    securely created and it was only being used to combine file creation and
    variable assignment in one command (by taking advantage of the fact that
    tempfile, when given a hardcoded filename, will also print the same
    filename back to you). It makes much more sense to simply set the
    variable, and `touch` the file separately.
    fdabbaca
  • Eli Schwartz's avatar
    debian/local/xvfb-run: Use builtin `case` to test variable value, rather than external `expr` · 72da781e
    Eli Schwartz authored and Julien Cristau's avatar Julien Cristau committed
    This is both faster and more pretty. Because case statements are just
    that awesome.
    72da781e
  • Julien Cristau's avatar
    xvfb-run: use "command -v" rather than "which" · 819b2f0c
    Julien Cristau authored
    Using a shell builtin is preferable to an external command, and "which"
    may not be available on some systems such as Arch Linux.
    
    This is not currently strictly conformant with Debian policy as "command
    -v" is not part of SUSv3, but policy is in the process of being updated,
    see bug#864615.
    
    Debian bug#889676
    819b2f0c
Loading
Loading