Commit 5292931c authored by Felix Lechner's avatar Felix Lechner

Remove empty Test-Against: statements in test descriptions.

These statements have an effect only during test selection. The normal
course of action should be, after editing a check, to use the check:
selector to ensure your changes work as expected.

You can also use the tag: selector, but that normally just invokes
check: for the check the tag belongs to. Since the other tags in the
check could interact with your selected tag, there is a reasonable
assumption that they might interfere. To locate false positives, it is
therefore best to run all related tests.

The Test-Against: statements change that behavior. They are a holdover
from when the test suite was focused on tags rather than checks. In an
ideal situation, tests are specific to one tag and checks group only
narrowly related tags. (Broad checks like 'files' and unfocused tests
like 'manpages-general' are antithetical to the new design.) The
Test-Against statements change which tests are run when a tag: is
selected. That is all they do.

Broad checks like 'files' group many unrelated tags. The tests
intended for them are usually, but not always, a bit narrower. A
Test-Against: statement says that the test at hand is a good indicator
for false positives only for the listed tags. It prevents the test
from running to find false positives for tags that do not appear in
either 'tags' or Test-Against.

The author would prefer to remove all Test-Against: statements. For
that to happen, broad checks must be split into smaller pieces. An
example would be to remove nodejs-related tags from the check 'files'.
During that effort, Test-Against statements can be helpful to identify
related tags. That's why Test-Against: is still around.

Empty Test-Against statements do not serve that purpose. They only
prevent tests from being run to look for false positive for tags other
then the small subset calculated above.  Without it, all tests are run
if they relate to the check the selected tag is in. Removing
Test-Against simply results in more tests being run when the tag:
selector is used. They do nothing else.

Unfortunately, the content of the Test-Against: statements was never
properly verified.  The semantics are unclear perhaps to anyone except
the auther. The field is also of limited utility. Finally, the field's
function is not what people may think from looking at old surviving
documentation. The fields should go away when possible.

We are keeping Test-Against: fields that have values so they can aid
in debulking broad checks. The empty statements are herewith deleted.

Gbp-Dch: ignore
parent 348a9237
......@@ -2,5 +2,4 @@ Skeleton: upload-native
Testname: apache2-modules-general
Version: 1.0
Description: Several tests related to Apache2 module packages
Test-Against:
Check: apache2
......@@ -2,5 +2,4 @@ Skeleton: upload-native
Testname: apache2-webapplications-general
Version: 1.0
Description: Several tests related to Apache2 web application packages
Test-Against:
Check: apache2
......@@ -2,5 +2,4 @@ Skeleton: upload-native
Testname: appstream-metadata
Version: 1.0
Description: Test AppStream and udev metadata in binary package
Test-Against:
Check: appstream-metadata
......@@ -4,5 +4,4 @@ Version: 1.0
Description: Test for development packages shipping ELF binaries in $PATH
Default-Build-Depends: debhelper (>= 9.20160114~)
Dh-Compat-Level: 9
Test-Against:
Check: binaries
......@@ -4,5 +4,4 @@ Version: 1.0
Default-Build-Depends: debhelper (>= 9.20151004~)
Dh-Compat-Level: 9
Description: Test for library package that does not match SONAME
Test-Against:
Check: binaries
......@@ -3,5 +3,4 @@ Testname: binaries-embedded-libs
Package-Architecture: any
Version: 1.0
Description: Package with binary with library-unique strings
Test-Against:
Check: binaries
......@@ -4,5 +4,4 @@ Test-Architectures: amd64 i386
Package-Architecture: any
Version: 1.0
Description: Test package with a pseudo binary from a different architecture
Test-Against:
Check: binaries
......@@ -3,5 +3,4 @@ Testname: binaries-general
Version: 1.0
Description: Misc errors related to binaries
Package-Architecture: any
Test-Against:
Check: binaries
......@@ -4,5 +4,4 @@ Version: 1.0
Description: Check for missing hardening features
Test-Architectures: amd64 i386 armhf arm64
Package-Architecture: any
Test-Against:
Check: binaries
......@@ -3,5 +3,4 @@ Testname: binaries-libc-link
Version: 1.0
Description: Binaries not linked against libc
Package-Architecture: any
Test-Against:
Check: binaries
......@@ -2,5 +2,4 @@ Skeleton: upload-native
Testname: binaries-misplaced
Version: 1.0
Description: Test binaries in /etc
Test-Against:
Check: binaries
......@@ -5,5 +5,4 @@ Default-Build-Depends: debhelper (>= 9.20151004~)
Dh-Compat-Level: 9
Description: Test for missing libc depends
Package-Architecture: any
Test-Against:
Check: binaries
......@@ -4,5 +4,4 @@ Version: 1.0
Description: Test for missing dependency on python-numpy-abiN
Package-Architecture: any
Extra-Build-Depends: python-all-dev, python-numpy, dh-python
Test-Against:
Check: binaries
......@@ -3,5 +3,4 @@ Testname: binaries-missing-depends-on-xapi
Version: 1.0
Description: Test for missing perlapi depends
Package-Architecture: any
Test-Against:
Check: binaries
......@@ -5,5 +5,4 @@ Default-Build-Depends: debhelper (>= 9.20151004~)
Dh-Compat-Level: 9
Description: Test for missing depends line
Package-Architecture: any
Test-Against:
Check: binaries
......@@ -6,5 +6,4 @@ Dh-Compat-Level: 9
Description: Test for missing lfs
Test-Architectures: i386 armhf
Package-Architecture: any
Test-Against:
Check: binaries
......@@ -5,5 +5,4 @@ Package-Architecture: any
Default-Build-Depends: debhelper (>= 9.20151004~)
Dh-Compat-Level: 9
Description: Test of multiarch same package with unsafe binaries
Test-Against:
Check: binaries
......@@ -3,5 +3,4 @@ Testname: binaries-obsolete-des
Version: 1.0
Description: Check detection of obsolete DES functions
Package-Architecture: any
Test-Against:
Check: binaries
......@@ -3,5 +3,4 @@ Testname: binaries-spelling
Version: 1.0
Description: Spelling errors in binaries
Package-Architecture: any
Test-Against:
Check: binaries
......@@ -3,5 +3,4 @@ Version: 1.0-1
Package-Architecture: any
Skeleton: upload-non-native
Description: Test checks related to static libs
Test-Against:
Check: binaries
......@@ -4,5 +4,4 @@ Source: binary
Sequence: 9999
Version: 4-1.1
Description: Legacy test "binary"
Test-Against:
Check: binaries
......@@ -6,5 +6,4 @@ Version: 1.0
Default-Build-Depends: debhelper (>= 9.20151004~)
Dh-Compat-Level: 5
Description: Legacy test "debug"
Test-Against:
Check: binaries
......@@ -6,5 +6,4 @@ Version: 1-1
Default-Build-Depends: debhelper (>= 9.20151004~)
Dh-Compat-Level: 6
Description: Legacy test "libbaz"
Test-Against:
Check: binaries
......@@ -3,5 +3,4 @@ Skeleton: upload-native
Version: 1.0
Distribution: experimental
Description: Test upload with unstable in changes but experimental in changelog
Test-Against:
Check: changelog-file
......@@ -3,5 +3,4 @@ Testname: changelog-file-become-native
Version: 1.0
Description: Test for packages where the version suddenly becomes native
References: Debian Bug #504070
Test-Against:
Check: changelog-file
......@@ -2,5 +2,4 @@ Skeleton: upload-native
Testname: changelog-file-dch-wrong-name-native
Version: 1.0
Description: Test if Debian changelog has the wrong name
Test-Against:
Check: changelog-file
......@@ -2,5 +2,4 @@ Testname: changelog-file-dch-wrong-name
Skeleton: upload-non-native
Version: 1.0-1
Description: Test if Debian changelog has the wrong name
Test-Against:
Check: changelog-file
......@@ -2,5 +2,4 @@ Skeleton: upload-native
Testname: changelog-file-empty-entry
Version: 1.0
Description: Check changelog empty entry
Test-Against:
Check: changelog-file
......@@ -2,5 +2,4 @@ Testname: changelog-file-etch
Skeleton: upload-non-native
Version: 1.0-1etch1
Description: Test for a code name in an unstable upload
Test-Against:
Check: changelog-file
......@@ -3,5 +3,4 @@ Testname: changelog-file-experimental
Version: 1.0-3
Description: Check experimental to unstable changes
Options: --pedantic
Test-Against:
Check: changelog-file
......@@ -2,5 +2,4 @@ Testname: changelog-file-general
Skeleton: upload-non-native
Version: 1.0-1
Description: General tests for changelog-file tags
Test-Against:
Check: changelog-file
......@@ -3,5 +3,4 @@ Skeleton: upload-non-native
Options: --pedantic
Version: 1.0-1
Description: Test for short changelog entries
Test-Against:
Check: changelog-file
......@@ -2,5 +2,4 @@ Testname: changelog-file-missing-explicit-entry
Skeleton: upload-non-native
Version: 1.2-3~deb9u1
Description: Test for missing (stable update, etc.) entries
Test-Against:
Check: changelog-file
......@@ -2,5 +2,4 @@ Testname: changelog-file-missing
Skeleton: upload-non-native
Version: 1.0-1
Description: Test if Debian changelog is missing
Test-Against:
Check: changelog-file
......@@ -2,5 +2,4 @@ Skeleton: upload-native
Testname: changelog-file-national-encoding
Version: 1.0
Description: Test for changelog with national encoding
Test-Against:
Check: changelog-file
......@@ -2,5 +2,4 @@ Testname: changelog-file-new-upstream
Skeleton: upload-non-native
Version: 1.0-2
Description: Check a new upstream version without a version change
Test-Against:
Check: changelog-file
......@@ -2,5 +2,4 @@ Skeleton: upload-native
Testname: changelog-file-news-and-changelog-not-compressed
Version: 1.0
Description: General tests for changelog-file tags
Test-Against:
Check: changelog-file
......@@ -2,5 +2,4 @@ Skeleton: upload-native
Testname: changelog-file-news-general
Version: 1.0
Description: General checks for NEWS.Debian
Test-Against:
Check: changelog-file
......@@ -2,5 +2,4 @@ Skeleton: upload-native
Testname: changelog-file-news-version
Version: 1.0
Description: Check mismatches of the NEWS.Debian version
Test-Against:
Check: changelog-file
......@@ -2,5 +2,4 @@ Skeleton: upload-native
Testname: changelog-file-news-wrong-name
Version: 1.0
Description: Check for NEWS.Debian installed with wrong name
Test-Against:
Check: changelog-file
......@@ -2,5 +2,4 @@ Skeleton: upload-native
Testname: changelog-file-no-dch-native
Version: 1.0
Description: Test if Debian changelog is missing in native pkg
Test-Against:
Check: changelog-file
......@@ -2,5 +2,4 @@ Skeleton: upload-native
Testname: changelog-file-reuses-existing-version
Version: 1.0
Description: Check changelog for re-used version numbers
Test-Against:
Check: changelog-file
......@@ -4,5 +4,4 @@ Version: 2.0
Description: Test some strange date in changelog
References: Debian Bug#794674
Extra-Build-Depends: dpkg (<< 1.18.2)
Test-Against:
Check: changelog-file
......@@ -2,5 +2,4 @@ Skeleton: upload-native
Testname: changelog-file-symlink
Version: 1.0
Description: Test if Debian changelog is a symlink
Test-Against:
Check: changelog-file
......@@ -2,5 +2,4 @@ Skeleton: deb
Testname: changelog-file-syntax
Version: 1.0
Description: Test for syntax errors in changelogs
Test-Against:
Check: changelog-file
......@@ -2,5 +2,4 @@ Testname: changelog-file-upstream-html-only
Skeleton: upload-non-native
Version: 1.0-1
Description: Check HTML-only upstream changelog
Test-Against:
Check: changelog-file
......@@ -2,5 +2,4 @@ Testname: changelog-file-wrong-name-upstream
Skeleton: upload-non-native
Version: 1.0-1
Description: Check a wrong name for an upstream changelog
Test-Against:
Check: changelog-file
......@@ -4,5 +4,4 @@ Version: 1.0
Profile: lintian-test
Options: --include-dir ./lintian-include-dir
Description: Test for wrong weekday in changelog date
Test-Against:
Check: changelog-file
......@@ -4,5 +4,4 @@ Source: binary
Sequence: 9999
Version: 4-1.1
Description: Legacy test "binary"
Test-Against:
Check: changelog-file
......@@ -6,5 +6,4 @@ Version: 1.0
Default-Build-Depends: debhelper (>= 9.20151004~)
Dh-Compat-Level: 5
Description: Legacy test "debug"
Test-Against:
Check: changelog-file
......@@ -4,5 +4,4 @@ Source: etcfiles
Sequence: 9999
Version: 1
Description: Legacy test "etcfiles"
Test-Against:
Check: changelog-file
......@@ -4,5 +4,4 @@ Source: fields
Sequence: 9999
Version: 1.5-.3
Description: Legacy test "fields"
Test-Against:
Check: changelog-file
......@@ -4,5 +4,4 @@ Source: foo++
Sequence: 9999
Version: 5
Description: Legacy test "foo++"
Test-Against:
Check: changelog-file
......@@ -6,5 +6,4 @@ Version: 1-1
Default-Build-Depends: debhelper (>= 9.20151004~)
Dh-Compat-Level: 6
Description: Legacy test "libbaz"
Test-Against:
Check: changelog-file
......@@ -5,5 +5,4 @@ Sequence: 9999
Version: 7+dfsg-0.1
Description: Legacy test "maintainer-scripts"
Extra-Build-Depends: dash (>= 0.5.10.2)
Test-Against:
Check: changelog-file
......@@ -4,5 +4,4 @@ Source: relations
Sequence: 9999
Version: 5
Description: Legacy test "relations"
Test-Against:
Check: changelog-file
......@@ -3,5 +3,4 @@ Version: 1.0-1
Skeleton: upload-non-native
Source-Format: 3.0 (quilt)
Description: General checks for spelling errors
Test-Against:
Check: changelog-file
......@@ -2,5 +2,4 @@ Skeleton: changes
Testname: changed-by-localhost
Version: 1.0
Description: Test Changed-By field with localhost address
Test-Against:
Check: changes-file
......@@ -2,5 +2,4 @@ Skeleton: changes
Testname: changed-by-malformed
Version: 1.0
Description: Test malformed Changed-By field
Test-Against:
Check: changes-file
......@@ -2,5 +2,4 @@ Skeleton: changes
Testname: changed-by-no-name
Version: 1.0
Description: Test Changed-By field with missing name
Test-Against:
Check: changes-file
......@@ -2,5 +2,4 @@ Skeleton: changes
Testname: changed-by-root-email
Version: 1.0
Description: Test Changed-By field with root user
Test-Against:
Check: changes-file
......@@ -2,5 +2,4 @@ Skeleton: changes
Testname: changed-by-root
Version: 1.0
Description: Test Changed-By field with root user
Test-Against:
Check: changes-file