- Apr 13, 2024
-
-
Luca Boccassi authored
-
Luca Boccassi authored
-
Luca Boccassi authored
-
Luca Boccassi authored
Update to upstream version '36' with Debian dir b6d5c44b1ab2cb6c83a3a3f4ef957689f9d321fa
-
Luca Boccassi authored
-
- Apr 12, 2024
-
-
David Rheinsberg authored
Prepare a bug-fix release. Update the release-notes as well as the author information. Signed-off-by: David Rheinsberg <david@readahead.eu>
-
- Apr 11, 2024
-
-
David Rheinsberg authored
Duplicate all FDs attached to a message when queuing it for sending. Messages can be queued for arbitrary times, so we cannot rely on borrowed FDs to be available for long enough. Reported-by: Camron Carter <reefoe@proton.me> Signed-off-by: David Rheinsberg <david@readahead.eu>
-
David Rheinsberg authored
Create a new constructor that duplicates the provided FDs and thus takes ownership of the FDs, but does not borrow the FDs of the caller. Signed-off-by: David Rheinsberg <david@readahead.eu>
-
David Rheinsberg authored
Ensure that the config file for packit is visible. We avoid hidden files whenever allowed by the tools. Signed-off-by: David Rheinsberg <david@readahead.eu>
-
David Rheinsberg authored
Propose downstream releases whenever upstream releases happen. Signed-off-by: David Rheinsberg <david@readahead.eu>
-
David Rheinsberg authored
Ensure that we always build and test the main-branch, since parallel PRs can lead to insufficient tests, or tests on outdated merges. Signed-off-by: David Rheinsberg <david@readahead.eu>
-
David Rheinsberg authored
Use the upstream YML style (see .github/...) as well as the known directory layout. Signed-off-by: David Rheinsberg <david@readahead.eu>
-
David Rheinsberg authored
Use proper path-joining operators of meson, rather than string-concatenation. Signed-off-by: David Rheinsberg <david@readahead.eu>
-
David Rheinsberg authored
Use proper suite-names for the different tests, rather than using the man-page references from our documentation. Signed-off-by: David Rheinsberg <david@readahead.eu>
-
David Rheinsberg authored
Do not test for aux-groups in credential reports on dbus-daemon. This is a relatively new feature and might not be reported by the tested instance. Signed-off-by: David Rheinsberg <david@readahead.eu>
-
David Rheinsberg authored
Use the kwargs to share all common test arguments and then reduce the verbosity by keeping all tests on a single line each. Signed-off-by: David Rheinsberg <david@readahead.eu>
-
David Rheinsberg authored
Change the configuration option to include tests in the distribution to just `tests`. We try to never conditionalize which parts to build, but rather always build everything that can be built with the selected dependencies. Hence, a `tests` configuration would never imply that it builds tests, and we can safely use it to mean the tests will be part of the distribution. There are some exceptions to this rule, but those we likely cannot change for compatibility reasons. Signed-off-by: David Rheinsberg <david@readahead.eu>
-
David Rheinsberg authored
Do not print the executed binary as test-output. We have no such debug output in our other tests. If we ultimately decide to include it, we should fetch this information early and pass it to each test, rather than print it over and over. Signed-off-by: David Rheinsberg <david@readahead.eu>
-
David Rheinsberg authored
Use proper curly brackets around all blocks, and ensure we use `c_assert()` over `assert()`. Signed-off-by: David Rheinsberg <david@readahead.eu>
-
Frantisek Sumsal authored
This introduces a new meson option 'install-tests' (disabled by default) that allows installing built test executables along with regular stuff, which can be used to ensure the installed dbus-broker works as expected. The tests are installed into <prefix>/lib/dbus-broker/tests directory, and split into 'unit' and 'dbus' subdirectories, similarly as they're in the source tree: $ meson setup --prefix=/usr -Dselinux=true -Dreference-test=true -Dinstall-tests=true build ... $ DESTDIR=$PWD/install-test ninja -C build install ... $ tree install-test/ install-test/ └── usr ├── bin │ ├── dbus-broker │ └── dbus-broker-launch └── lib ├── dbus-broker │ └── tests │ ├── dbus │ │ ├── bench-connect │ │ ├── bench-message │ │ ├── test-broker │ │ ├── test-driver │ │ ├── test-fdstream │ │ ├── test-lifetime │ │ └── test-matches │ └── unit │ ├── test-address │ ├── test-apparmor │ ├── test-config ... │ ├── test-systemd │ └── test-user └── systemd ├── catalog │ ├── dbus-broker.catalog │ └── dbus-broker-launch.catalog ├── system │ └── dbus-broker.service └── user └── dbus-broker.service 12 directories, 36 files $ install-test/usr/lib/dbus-broker/tests/dbus/test-broker Using dbus-broker binary /usr/bin/dbus-broker Using dbus-broker binary /usr/bin/dbus-broker Using dbus-broker binary /usr/bin/dbus-broker Using dbus-broker binary /usr/bin/dbus-broker
-
Frantisek Sumsal authored
Let's make the reference and benchmark tests work standalone, i.e. without a build dir, since they're useful on their own. This introduces a matching counterpart for the $DBUS_BROKER_TEST_DAEMON env variable - $DBUS_BROKER_TEST_BROKER - that can be used to override the path to the dbus-broker binary.
-
- Mar 13, 2024
-
-
Frantisek Sumsal authored
dbus-daemon v1.15.2 switched from using abstract sockets to path-based sockets. Let's tweak the reference tests to support both cases.
-
Frantisek Sumsal authored
Newer meson doesn't like colons in test names: test/dbus/meson.build:78: DEPRECATION: ":" is not allowed in test name "dbus-daemon(1): Connection", it has been replaced with "_" test/dbus/meson.build:79: DEPRECATION: ":" is not allowed in test name "dbus-daemon(1): Message passing", it has been replaced with "_" ... Let's instead separate the reference tests/benchmarks into their own suite. This also makes running just the reference tests easier by using meson test's --suite= argument: $ meson test -C build --list --suite 'dbus-daemon(1)' dbus-broker:dbus-daemon(1) / Broker API dbus-broker:dbus-daemon(1) / Driver API dbus-broker:dbus-daemon(1) / FD Stream Constraints dbus-broker:dbus-daemon(1) / Client Lifetime dbus-broker:dbus-daemon(1) / Signals and Matches
-
Frantisek Sumsal authored
get_pkgconfig_variable() was deprecated in 0.56.0. test/dbus/meson.build:76: WARNING: Project targets '>=0.60.0' but uses feature deprecated since '0.56.0': dependency.get_pkgconfig_variable. use dependency.get_variable(pkgconfig : ...) instead
-
- Mar 12, 2024
-
-
Frantisek Sumsal authored
Let's follow-up on 0a0b0fad and introduce a second Packit job that runs integration tests on the just built RPMs in Testing Farm [0]. The test organization and execution is handled by tmt [1]. To not unnecessarily pollute the dbus-broker's git root, the tmt root is initialized in the test/integration/ subdirectory (meaning that for the tmt commands to work correctly you need to be somewhere below this directory). Since there are no pre-existing integration tests, add a simple one that runs dfuzzer on the org.freedesktop.systemd1 D-Bus interface to exercise dbus-broker a bit. A short README file is provided as well with instructions on how to easily add a new test case, and with some links where to find more information about tmt. [0] https://packit.dev/docs/configuration/upstream/tests [1] https://tmt.readthedocs.io/en/stable/overview.html
-
- Mar 09, 2024
-
-
Frantisek Sumsal authored
Build (and test) dbus-broker on all active Fedora releases using Packit. This uses Fedora's spec file (from Rawhide) with a couple of tweaks, so we don't have to ship our own. Replaces: #279
-
- Feb 16, 2024
-
-
Luca Boccassi authored
-
Luca Boccassi authored
-
Luca Boccassi authored
pkg-config is deprecated and replaced by pkgconf
-
Luca Boccassi authored
d/p/github_apparmor_support.patch: enable apparmor support See merge request utopia-team/dbus-broker!4
-
Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
-
- Jan 11, 2024
-
-
David Rheinsberg authored
Include the name of the activated peer in D-Bus errors when propagating. We already build custom error descriptions so it is simple to include a bit more information. Reported-by: Jake Dane Signed-off-by: David Rheinsberg <david@readahead.eu>
-
- Dec 30, 2023
-
-
Luca Boccassi authored
We just need the pkg-config file
-
- Dec 24, 2023
-
-
Luca Boccassi authored
-
Luca Boccassi authored
Update to upstream version '35' with Debian dir 85614a71495ca9cd6ad980fd8006df318d078815
-
Luca Boccassi authored
-
- Dec 20, 2023
-
-
David Rheinsberg authored
Release dbus-broker 35. Signed-off-by: David Rheinsberg <david@readahead.eu>
-
- Dec 19, 2023
-
-
David Rheinsberg authored
When the directory-iteration was changed to use fs_dir_list(), the loop was changed to no longer check for `errno`. Unfortunately, the trailing `errno`-check was not dropped. This means any `errno`-leftovers from the loop will cause the entire operation to fail. This can certainly happen when we handle syscall/libc failures gracefully. In particular, this breaks when stale or broken service files are left on the system. Fix this and drop the error-checking remnant. Reported-by: Allison Karlitskaya <allison.karlitskaya@redhat.com> Reported-by: Lily Danzig <ldenardo@dealerinspire.com> Signed-off-by: David Rheinsberg <david@readahead.eu>
-
- Dec 14, 2023
-
-
Luca Boccassi authored
-
Luca Boccassi authored
-