Skip to content

WIP: Updating packaging for 1.3.2 release

Tim Kuester requested to merge tkuester-guest/liquid-dsp:master into master

I've done some initial work on the package to get it to build, and tested the generated debian packages by compiling a small test program I'd written. (If it matters, I'm doing this on an Ubuntu machine.) Everything seemed to work well. Since this is my first contribution, there are some things that should be reviewed by a more experienced maintainer.

General Workflow

I imported the new files from github with gbp import-orig --uscan. Everything seemed to work quite smoothly. Then, I ran gbp dch to bump the changelog file for 1.3.2.

Unfortunately, the .gitignore file got wiped out in the import, as has happened previously in 9fcf28bc, 61997a34. This brings up two questions:

  • If we "forked" the github repo, would this avoid having to reset the .gitignore file?
  • It seems there are a build artificats that could be added to .gitignore. Should I include those as well?

From there, gbp buildpackage complained about fuzzy patches. I hacked the correct changes back in with quilt, but I'm not wonderful at makefiles or quilt yet. Did I correctly update the files?

The package still wouldn't build, complaining now about symbol changes. Examining the diff, it seems that there were several functions removed. I kept that commit separate so you could check my work, it's in 65d7fdbd. Am I correct in assuming this requires a soname bump?

From there, the package built successfully. I attempted to update and re-check the debian/copyright file with debmake, but it seemed to be including files inside the debian directory. Is there a suggested way of doing this?

Finally, I have updated the debian/changelog to include a summary of changes. However, since this is pending review, I left it in the "UNRELEASED" state.

With respect to git, I generated a gpg signing key and uploaded it to salsa, but haven't really used it to sign commits. Additionally, I switch tenses in a few of my commits -- "Changing" vs "Change". It wouldn't be much extra work to redo things, if that would help.

Thank you for helping mentor me! I welcome your feedback, and look forward to helping contribute!

Merge request reports