Skip to content
Snippets Groups Projects

Document currently supported short options (DBTS: #846242)

Merged deadjoe requested to merge deadjoe/adduser:DBTS-846242-short-options into master
1 unresolved thread

DBTS: #846242

The changes here are a bit more sweeping. However, no functionality is changed... just documentation.

I was a bit disappointed at how permissive Perl option processing is. I think it allows too much, but changing that is a separate issue from this one. Hopefully, that discussion will be had one day.

Let me know what you think!

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Marc Haber approved this merge request

    approved this merge request

    • I agree with you on most things but on the editor control lines. But I am opinionated as well, and your points are solid. Especially since the current sources have hysterically grown in the last decades, it doesnt make much point to keep those control lines.

      I might add some of the vim lines back if I begin working again on adduser, though.

      I like the way you have structured the commits, that makes it really easy to work with them.

      gbp dch supports some meta tags in the commit message which can then be used to automatically generate changelog entries Closes: clauses and thanks. I would like you to use them, it makes generating the changelog before an upload way easier. see gbp-dch(1) section META TAGS. I'll have to be more careful with the next upload's changelog anyway, so there is no need to pay close attention to those right now. In the future it would be nice though.

    • Author Contributor

      Understood!

      I'll take a look at the docs for these tags and attempt to make use of them in my next PR.

      Thanks!

    • Please register or sign in to reply
  • merged

  • Marc Haber mentioned in commit ef554c48

    mentioned in commit ef554c48

Please register or sign in to reply
Loading