scripts/debcheckout.pl: handle DEBEMAIL including DEBFULLNAME in name <mail> format
What is the canonical definition of how DEBEMAIL
should look like? I was setting up a new system and made the mistake of using the man page of dch
to learn that DEBEMAIL
can be of the format name <mail>
and if it is, DEBFULLNAME
does not need to be set. The problem is, that debcheckout
does not understand this format and in my case it creates a ~/.git/config
containing:
[user]
email = Johannes Schauer Marin Rodrigues <josch@debian.org>
This leads to commits that look like this:
Author: Johannes Schauer Marin Rodrigues <Johannes Schauer Marin Rodrigues josch@debian.org>
Unfortunately, I noticed this too late and now several Debian git repositories contain git commits by me with a completely garbage email address including the packaging repositories of zxing-cpp, fakechroot, clapper, mmdebstrap as well as devscript itself! See the Author field of the commits in !320 (merged)
Lets make sure I'm the last person who has a garbage email address enshrined for all eternity in several git repositories that i cannot change the history of without breaking other people's clones...
Please merge this or help me make this change mergable.
Thanks!
Merge request reports
Activity
added 1 commit
- 59ff5bb3 - scripts/debcheckout.pl: handle DEBEMAIL including DEBFULLNAME in name <mail> format
- Resolved by Jelmer Vernooij
LGTM
I wonder if there's a canonical definition of DEBEMAIL and DEBFULLNAME somewhere, there's probably a few other tools that misbehave in subtle ways. python-debian mostly seems to follow what dch/your PR do, but AFAIK discards the fullname bit from DEBEMAIL if DEBFULLNAME is also provided.
(FWIW if you weren't aware of it, .mailmap should at least allow you to fixup things in the Git UI)
mentioned in merge request !320 (merged)
added 26 commits
-
59ff5bb3...b4c2ba63 - 25 commits from branch
master
- 94d32d02 - scripts/debcheckout.pl: handle DEBEMAIL including DEBFULLNAME in name <mail> format
-
59ff5bb3...b4c2ba63 - 25 commits from branch
enabled an automatic merge when the pipeline for 94d32d02 succeeds
mentioned in commit f9995f33