Skip to content

Import upstream fixes for miscompilations and a FTBFS due to aliasing

Eduardo Barretto requested to merge ebarretto/libscrypt:debian/latest into master

Add sysendian.h-fix-aliasing-violations.patch: Accessing uint32_t as uint8_t is an aliasing violation. Add b64-fix-Wold-style-definition.patch: Drop K&R declarations. Add crypto_scrypt-nosse-fix-aliasing-violations.patch: replace blkcpy with memcpy to fix aliasing violations.

This PR also fixes some lintian and blhc issues with the package and make it possible work with gbp.

If this gets integrated, I think we could rename the master branch to be debian/latest and become the repo's default branch. Also, we could create both upstream/latest and pristine-tar just like I did on my fork for gbp.

https://salsa.debian.org/ebarretto/libscrypt/-/tree/upstream/latest?ref_type=heads

https://salsa.debian.org/ebarretto/libscrypt/-/tree/pristine-tar?ref_type=heads

This is my first time contributing directly to a package and some feedback would be great.

Merge request reports

Loading