Skip to content

FreedomBox Setup cleanup

Sunil Mohan Adapa requested to merge SunilMohanAdapa:setup-cleanup into master

Created by: SunilMohanAdapa

Pull request #998 which moves Plinth setup out of freedombox-setup's firstrun is a major change with a lot of possibility for things breaking. If we are doing that, we could very easily go one further setup and eliminate the need for reboot after firstrun and even firstrun process itself. This patch does most of the work necessary for that. Only network connection setup is remaining which can also be done in Plinth.

I tested the following:

  • When sso and apache are due for setup, apache setup runs before sso setup.
  • Reverting all Apache setup done by freedombox-setup and Plinth and running then Plinth sets up all Apache modules, configurations and sites. Rerunning it is safe.
  • When SSH key are removed and Plinth is started (with ssh module not setup), SSH keys are generated and SSH is automatically started. Rerunning does not discard the keys.
  • Enabling disabling SSH from Plinth properly enables and disables the ssh service and shows the running status properly.
  • All entries removed from firewall setup are handled by corresponding application properly. This is tested by enabling/disabling and monitoring their firewall services.
  • firewall module automatically sets up the default firewall ports when Plinth run and triggers firewall module setup. Rerunning is safe.

Merge request reports