Skip to content

diagnostics: Improve exception handling in app diagnostics

Veiko Aasa requested to merge vexch/freedombox:diagnostics-exceptions-show into master

Fixes the problem when the app throws an error when running diagnostics, the app's diagnostics page shows an html 500 error and on the diagnostics app page, only an excpetion message is shown without other apps diagnostics. (I encountered this when the network app diagnostics threw an exception because of a particular network configuration.)

Tests performed:

  • Checked that an app diagnostics page and the diagnostics app shows all info correctly.
  • Modified the networks app diagnostics code so that it throws an exception. Checked that the app diagnostics page shows an exception message and the diagnostics module shows all the apps and the networks app section shows an exception message.
Commit 2

diagnostics: Show app name and fallback to app id if not exist

Tests performed:

  • The diagnostics app page and individual app diagnostics pages have app names.
  • When the app name is missing (the apache app), app id is shown instead.

Merge request reports