Skip to content

users: Fix unit test failures when LDAP is empty

Veiko Aasa requested to merge vexch/freedombox:users-tests-fix-cleanup-admin into master

When LDAP is set up but the first admin is not yet set up, some of the users module tests fail because known admin users is deleted before other users. A known admin user must exist to delete existing users.

Fix this by deleting a known admin user only after deleting other users when cleaning up tests.

Tests performed on Debian stable and testing:

  • All the users module unit tests pass:
    • when LDAP is not set up yet
    • after LDAP is set up but empty
    • after first admin user has set up using the web UI

Merge request reports