Skip to content

action_utils: Use flag on disk to indicate that freedombox package was held

  • action_utils: Separate function to hold freedombox package
  • action_utils: Use flag to indicate freedombox package has been held
    • In case the plinth process is interrupted, the "finally" block that is meant to unhold the package may not be executed, and the package will stay held. The flag is used to indicate this situation, so it can be resolved the next time apt_hold_freedombox is used.
  • upgrades: Check for held freedombox package in manual update
    • This is to recover from a situation where the package is held, and then plinth process is interrupted so it cannot release the hold.
    • We check for and recover from this situation when installing new apps, and when running dist upgrade. This provides another way to recover from the problem, by running manual update.
  • upgrades: Check for held freedombox package daily
    • Guard against removing a hold while the package manager is busy.

Tests: Besides those listed in the commit messages, I ran functional tests and a dist-upgrade to testing. Ensured that freedombox package was not held at the end.

Helps #2090.

Signed-off-by: James Valleroy jvalleroy@mailbox.org

Edited by James Valleroy

Merge request reports

Loading