Skip to content

*: Always pass check= argument to subprocess.run()

Sunil Mohan Adapa requested to merge sunilmohan/freedombox:subprocess-run-check-arg into master

  • Avoid flake8 warnings.

  • Makes the call more explicitly readable in case an exception is expected but check=True is not passed by mistake.

Tests:

  • Many tests are skipped since the changes are considered trivial. check=False is already the default for subprocess.run() method.

  • actions/package: Install an app when it is not installed.

  • actions/upgrade: Run manual upgrades.

  • actions/users: Change a user password. Login. Create/remove a user.

  • actions/zoph: Restore a database.

  • container: On a fresh repository, run ./container up,ssh,stop,destroy for a testing container.

  • plinth/action_utils.py: Enable/disable an app that has a running service.

Signed-off-by: Sunil Mohan Adapa sunil@medhas.org

Merge request reports