Skip to content

mumble: Use privileged decorator for superuser actions & more fixes

Sunil Mohan Adapa requested to merge sunilmohan/freedombox:mumble-privileged-actions into master

  • Don't use command line argument for sending the join password for security.

  • murmurd can switch to mumble-server UID before performing database operations. Remove code to switch to mumble-server user.

  • murmurd seems to return correct response code of 0 upon successfully setting the password. Simplify code accordingly.

  • Use subprocess.run() instead of subprocess.Popen for convenience.

Tests:

  • Run functional and unit tests on Debian stable.

  • Perform a fresh installation.

  • Verify that setting super user password works.

  • Verify that setting root channel names works.

  • Verify that setting join password works.

Signed-off-by: Sunil Mohan Adapa sunil@medhas.org

Merge request reports