Skip to content
Snippets Groups Projects

app: Implement basic uninstallation

Closed Sunil Mohan Adapa requested to merge sunilmohan/freedombox:uninstall into master
All threads resolved!

This is merely the basic implementation on uninstall operation. It prominently lacks:

  • App specific handling of configuration and other setup removal
  • App specific handling of packages not be removed
  • Purging of packages instead of removing them (some FreedomBox installed files will get removed sometimes).

I believe we can merge this because this shows a 'experimental' warning to users and we can continue to work on improvements.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Sunil Mohan Adapa added 18 commits

    added 18 commits

    • 59acfff3 - package: Implement low-level methods for uninstalling
    • a880be93 - forms: Implement form for uninstallation
    • 7dc38f7a - setup: Drop check for already running operation
    • f79c5393 - app: Add API to uninstall an app
    • d00527ae - package: Implement uninstall in Package component
    • 9f8d08b1 - setup: Implement operation to uninstall an app
    • 08103c25 - views: Implement a view to uninstall an app
    • 32ba3655 - app: Add a menu item to trigger uninstallation
    • e4ad717e - tests: functional: Add install/uninstall test for all apps
    • 0a38ca73 - backups: Use AppView for the main app page
    • c26827ab - diagnostics: Use AppView for app page
    • effe6aa8 - names: Use AppView for app page
    • 0b6c136e - networks: Use AppView for app page
    • 830fb16d - power: Use AppView for app page
    • 3d0245c4 - security: Use AppView for app page
    • e51e219a - snapshot: Use AppView for app page
    • d4e3acfc - letsencrypt: Use AppView for app page
    • 9a4e99f4 - tor: Use AppView and Operation for app page

    Compare with previous version

  • The pushed the following changes:

    • Remove unused import to fix failing code quality checks.
    • Added a check to make sure that uninstall view can't be shown for essential apps.
    • Converted all the remaining app pages to use AppView (since uninstall feature requires sending additional context). This includes long pending significant updates to Tor app page.
  • Sunil Mohan Adapa resolved all threads

    resolved all threads

  • James Valleroy
  • James Valleroy
  • added 4 commits

    • 7d4c1e76 - security: Use AppView for app page
    • a3bd666e - snapshot: Use AppView for app page
    • b63b4f55 - letsencrypt: Use AppView for app page
    • a790960d - tor: Use AppView and Operation for app page

    Compare with previous version

  • Sunil Mohan Adapa resolved all threads

    resolved all threads

  • I ran functional tests on all the apps which have switched to AppView.

  • mentioned in issue #266 (closed)

  • James Valleroy mentioned in merge request !2369 (closed)

    mentioned in merge request !2369 (closed)

  • Please register or sign in to reply
    Loading