Skip to content

*: Move modules-enabled files to /usr/bin

Sunil Mohan Adapa requested to merge sunilmohan/freedombox:move-modules-enabled-files into master

  • This will leave /etc/{plinth,freedombox} empty by default making service more robust to run across various environments and situations. See systemd's explanation for more details.

  • Use Debian maintainer scripts remove all the existing files in /etc/plinth/modules-enabled.

  • Read from /usr/share/freedombox/modules-enabled then from /etc/plinth/modules-enabled and finally from /etc/freedombox/modules-enabled. Later read ones override previously read files. Any file pointing to /dev/null will mean the module must be ignored.

Tests:

  • Clean up /etc/plinth, /etc/freedombox and /usr/share/freedombox/modules-enabled. Run service and notice that files are getting loaded from development folder using a debug message.

  • Run setup.py and notice that files get installed in /usr/share/freedombox/modules-enabled/ and in the next run they get loaded from there.

  • Create a override file in /etc/plinth/modules-enabled/transmission and notice that overriden file gets priority over the one in /usr/share/freedombox/modules-enabled.

  • Link the file /etc/plinth/modules-enabled/transmission to /dev/null and notice that is not loaded.

  • Create another file in /etc/freedombox/modules-enabled/transmission and notice that it overrides the previous two files.

  • All affected modules are loaded.

  • Build a new Debian package and ensure that upgrading 23.8 to new version removes are all configuration files.

Signed-off-by: Sunil Mohan Adapa sunil@medhas.org

Merge request reports