Skip to content

*: Add type hints for diagnose method

Sunil Mohan Adapa requested to merge sunilmohan/freedombox:add-type-hints-for-diagnostics into master

Helps: #2410 (closed).

  • Ensure that diagnostics methods and parameters are type checked so that we can catch any potential issues.

  • Move plinth/modules/diagnostics/check.py to plinth/diagnostic_check.py to avoid many circular dependencies created. This is due to plinth.modules.diagnostics automatically imported when plinth.modules.diagnostics.check is imported. Also app.py is already (type) dependent on diagnostic_check due to diagnose() method. To make the Check classes independent of diagnostic module is okay.

Tests:

  • Run make check-type.

  • Run full diagnostics with following apps installed: torproxy, tor.

    • Test to netcat to 9051 in tor works.
    • Test 'port available for internal/external networks' in firewall works.
    • Test 'Package is latest' works.
    • Test 'Access url with proxy' in privoxy works.

Signed-off-by: default avatarSunil Mohan Adapa sunil@medhas.org

Merge request reports